Page MenuHomePhabricator
Create Task
Maniphest T337780

Prevent UniversalLanguageSelector from setting preferences for temporary accounts
Closed, ResolvedPublic4 Estimated Story Points
Actions

Description

Following T335971, it appears the extension is saving preferences for temporary users.
Update the code to treat temporary users like anon users.

Wherever these do something different based on whether a user is anonymous or registered, they may need updating (including comments).

Tests and comments should also be updated.

Notes
To help with searching:

In PHP preferences are saved via UserOptionsManager::saveOptions
In JS preferences are saved via methods defined on options.js: https://gerrit.wikimedia.org/g/mediawiki/core/+/809d4c9a9dd2cff6321cdae7a41e75b6c362cbbd/resources/src/mediawiki.api/options.js

Details

SubjectRepoBranchLines +/-
ULS Frontend: Save preferences only for named usersmediawiki/extensions/UniversalLanguageSelectormaster+24 -13
Save preferred language only for named usersmediawiki/extensions/UniversalLanguageSelectormaster+1 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

• AGueyte created this task.May 30 2023, 6:15 PM
Aklapper added a project: UniversalLanguageSelector.May 30 2023, 9:47 PM
Aklapper removed a subscriber: Language-Team.

(Please add codebase project tags to tasks when possible, so such tasks can be found when looking for open tasks related to that codebase - thanks!)

Niharika added a project: Language-Team.Jun 6 2023, 5:42 PM
Niharika subscribed.

@Aklapper we want to add the Language-Team so that we can track which team is owning this (beyond the project it falls into). Is that alright?

Aklapper added a comment.Jun 7 2023, 1:22 PM

@Niharika: sure, of course - just please add project tags as projects instead of subscribers, otherwise tasks don't end up being shown on workboards. Thanks!

• Nikerabbit moved this task from Backlog to Scheduled on the Language-Team board.Jun 19 2023, 11:16 AM
• Nikerabbit added a parent task: T326879: Update Language Team-owned products that may be affected by IP Masking.Jun 29 2023, 10:30 AM
• Nikerabbit edited projects, added Language-Team (Language-2023-July-September), Localization Infrastructure FY2023-24; removed Language-Team.Jul 10 2023, 8:24 AM
• Nikerabbit moved this task from Backlog to Support (LM) on the Localization Infrastructure FY2023-24 board.
• Nikerabbit moved this task from Quarter Backlog to Priority: Localization infrastructure on the Language-Team (Language-2023-July-September) board.
• Nikerabbit triaged this task as Medium priority.Jul 10 2023, 8:27 AM
• Nikerabbit set the point value for this task to 4.Jul 10 2023, 8:29 AM
gerritbot added a comment.Jul 24 2023, 10:37 AM

Change 940884 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/UniversalLanguageSelector@master] Save preferred language only for named users

https://gerrit.wikimedia.org/r/940884

gerritbot added a project: Patch-For-Review.Jul 24 2023, 10:37 AM
abi_ claimed this task.Jul 24 2023, 10:37 AM
abi_ moved this task from Priority: Localization infrastructure to In Review on the Language-Team (Language-2023-July-September) board.
abi_ added a comment.Jul 24 2023, 10:59 AM

There are two usages of options in the ULS extension:

  1. To save the language (In ApiULSSetLanguage.php). I've changed this to only save options for a named user.
  2. Whether user has enabled 'compact-language-links'. This I believe is a beta feature which can be enabled only if a user is logged in. So nothing to do here.
gerritbot added a comment.Aug 10 2023, 2:21 PM

Change 947853 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/UniversalLanguageSelector@master] ULS Frontend: Save preferences only for named users

https://gerrit.wikimedia.org/r/947853

gerritbot added a comment.Aug 21 2023, 9:17 AM

Change 940884 merged by jenkins-bot:

[mediawiki/extensions/UniversalLanguageSelector@master] Save preferred language only for named users

https://gerrit.wikimedia.org/r/940884

gerritbot added a comment.Aug 21 2023, 11:08 AM

Change 947853 merged by jenkins-bot:

[mediawiki/extensions/UniversalLanguageSelector@master] ULS Frontend: Save preferences only for named users

https://gerrit.wikimedia.org/r/947853

Maintenance_bot removed a project: Patch-For-Review.Aug 21 2023, 11:10 AM
abi_ closed this task as Resolved.Aug 29 2023, 8:12 AM
abi_ moved this task from In Review to Done on the Language-Team (Language-2023-July-September) board.

Changes have been made to both the front-end and back-end code base to avoid storing preferences for temporary users.

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.25; 2023-09-05).Aug 29 2023, 11:01 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits