Page MenuHomePhabricator

Prevent extensions from setting preferences for temporary accounts
Closed, ResolvedPublic3 Estimated Story Points

Description

Background

Temporary accounts will not be able to store preferences, and will instead have the same set of preferences that anon users have.

Following T332415: Update UserOptions classes to prevent temporary users having access to preferences, some extensions may encounter errors, if they are setting preferences for temporary accounts. They should be updated to not do so.

What needs doing
  • Investigate which extensions set preferences (via PHP or JS)
  • Check which of these might try to set a preference for a temporary account
  • File tasks for any that set preferences for temporary accounts, or where it's inconclusive
Notes

To help with searching:

Related Objects

StatusSubtypeAssignedTask
Resolved AGueyte
Resolved AGueyte
ResolvedMusikAnimal
Resolved AGueyte
Resolvedabi_
Resolved AGueyte
Resolved AGueyte
Resolved AGueyte
Resolvedabi_
Resolvedabi_
Resolved TThoabala
Resolved TThoabala
Resolved AGueyte
Resolvedmatmarex
ResolvedTchanders
Resolvedjsn.sherman
Resolved AGueyte
Resolvedmatmarex
Resolved AGueyte
Resolved AGueyte
Resolvedtstarling
Resolved kostajh
Resolved TThoabala
DeclinedNone
Resolved TThoabala
OpenNone
OpenNone

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
AGueyte set the point value for this task to 8.May 25 2023, 2:16 PM

https://codesearch.wmcloud.org/deployed/?q=UserOptionsManager

Some extensions were left out because the user of userOptionsManager was only on test files.

The tasks created cover the cases of userOptionsManager being set and saved.

AGueyte changed the point value for this task from 8 to 5.May 31 2023, 2:27 PM

Change 925840 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/RevisionSlider@master] Don't set references for temporary accounts

https://gerrit.wikimedia.org/r/925840

Change 925840 merged by jenkins-bot:

[mediawiki/extensions/RevisionSlider@master] Don't set preferences for temporary accounts

https://gerrit.wikimedia.org/r/925840