Page MenuHomePhabricator
Create Task
Maniphest T337775

Prevent TranslationNotifications from setting preferences for temporary accounts
Closed, ResolvedPublic4 Estimated Story Points
Actions

Description

Following T335971, it appears the extension is saving preferences for temporary users.
Update the code to treat temporary users like anon users.

Wherever these do something different based on whether a user is anonymous or registered, they may need updating (including comments).

Tests and comments should also be updated.

Notes
To help with searching:

In PHP preferences are saved via UserOptionsManager::saveOptions
In JS preferences are saved via methods defined on options.js: https://gerrit.wikimedia.org/g/mediawiki/core/+/809d4c9a9dd2cff6321cdae7a41e75b6c362cbbd/resources/src/mediawiki.api/options.js
Code Search: https://codesearch.wmcloud.org/deployed/?q=UserOptionsManager

Related Objects
Search...

Event Timeline

• AGueyte created this task.May 30 2023, 5:53 PM
Aklapper added a project: TranslationNotifications.May 30 2023, 9:47 PM

(Please add codebase project tags to tasks when possible, so such tasks can be found when looking for open tasks related to that codebase - thanks!)

Niharika added a project: Language-Team.Jun 6 2023, 5:41 PM
• AGueyte updated the task description. (Show Details)Jun 6 2023, 7:34 PM
• Nikerabbit moved this task from Backlog to Scheduled on the Language-Team board.Jun 19 2023, 11:16 AM
• Nikerabbit added a parent task: T326879: Update Language Team-owned products that may be affected by IP Masking.Jun 29 2023, 10:30 AM
• Nikerabbit edited projects, added Language-Team (Language-2023-July-September), Localization Infrastructure FY2023-24; removed Language-Team.Jul 10 2023, 8:25 AM
• Nikerabbit moved this task from Backlog to Support (LM) on the Localization Infrastructure FY2023-24 board.
• Nikerabbit moved this task from Quarter Backlog to Priority: Localization infrastructure on the Language-Team (Language-2023-July-September) board.
• Nikerabbit triaged this task as Medium priority.Jul 10 2023, 8:27 AM
• Nikerabbit set the point value for this task to 4.Jul 10 2023, 8:29 AM
abi_ subscribed.Jul 19 2023, 10:19 AM

I see two usages of saveOption in TranslationNotifications. Both of these usages are in maintenance scripts and operate on subscribers who have subscribed to receive notifications which temporary users cannot do.

abi_ claimed this task.Jul 19 2023, 10:19 AM
abi_ moved this task from Priority: Localization infrastructure to In Progress on the Language-Team (Language-2023-July-September) board.
• AGueyte added a comment.Jul 19 2023, 12:01 PM

Hi @abi_ thank you for doing the research.
Then in that case we can close the task.

abi_ added a comment.Jul 20 2023, 4:04 PM

@AGueyte Reviewing the documentation on Meta-Wiki regarding temporary accounts, I see that temporary accounts cannot log in to their account. The special page from where translators signup (Special:TranslatorSignup) to receive notifications requires that user's log in to access it (See: GitHub code URL). I think this should ensure that temporary users cannot use that page right?

• AGueyte added a comment.Jul 20 2023, 10:25 PM
In T337775#9031841, @abi_ wrote:

@AGueyte Reviewing the documentation on Meta-Wiki regarding temporary accounts, I see that temporary accounts cannot log in to their account. The special page from where translators signup (Special:TranslatorSignup) to receive notifications requires that user's log in to access it (See: GitHub code URL). I think this should ensure that temporary users cannot use that page right?

This is correct, and testing will still be needed to confirm. Happy to help with this if needed!

abi_ closed this task as Resolved.Jul 21 2023, 4:48 PM
abi_ moved this task from In Progress to Done on the Language-Team (Language-2023-July-September) board.

I checked translation notification subscribers on MediaWiki and Meta-Wiki, and found that there are no temporary users, so I think the current system is working as expected.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits