Page MenuHomePhabricator
Create Task
Maniphest T337966

Use Codex CSS Typeahead Search in Vector
Closed, ResolvedPublic3 Estimated Story Points
Actions

Assigned To
Jdlrobson
Authored By
bwang
Jun 1 2023, 5:49 PM
Tags
Referenced Files
F37107497: Screen Recording 2023-06-16 at 3.27.33 PM.mov.gif
Jun 16 2023, 10:34 PM
F37107494: Screen Recording 2023-06-16 at 3.26.18 PM.mov.gif
Jun 16 2023, 10:34 PM
F37107490: Screen Recording 2023-06-16 at 3.25.30 PM.mov.gif
Jun 16 2023, 10:34 PM
F37107488: Screen Recording 2023-06-16 at 3.22.29 PM.mov.gif
Jun 16 2023, 10:24 PM
F37107486: Screen Recording 2023-06-16 at 3.19.55 PM.mov.gif
Jun 16 2023, 10:24 PM
F37107484: Screen Recording 2023-06-16 at 3.14.19 PM.mov.gif
Jun 16 2023, 10:24 PM
Subscribers
Aklapper
bwang
Edtadros
Jdlrobson

Description

Split off from T336526. This work is part of the epic T322077 to reduce the maintenance cost of Typeahead Search in Vector

AC

  • Use Codex Typeahead Search markup and classes
  • Remove custom Vector typeahead search styles

QA

  • Ensure search design remains the same when loading in Vue (i.e. after focusing and typing into the searchbar)
  • Ensue search still works when JS is disabled

QA Results - Beta

ACStatusDetails
1✅T337966#8939824
2✅T337966#8939824

QA Results - Prod

ACStatusDetails
1✅T337966#8939866
2✅T337966#8939866

Details

SubjectRepoBranchLines +/-
Use Codex for typeahead search stylesmediawiki/skins/Vectormaster+154 -161
Customize query in gerrit

Related Objects
Search...

Event Timeline

bwang created this task.Jun 1 2023, 5:49 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 1 2023, 5:49 PM
bwang mentioned this in T336526: Use Codex button/icon markup instead of mediawiki ui markup in Vector.Jun 1 2023, 5:50 PM
bwang mentioned this in T322077: Lower the maintenance costs of TypeaheadSearch in Vector.
bwang triaged this task as Medium priority.Jun 1 2023, 5:52 PM
bwang moved this task from Incoming to Web Team FY2022-23 Q4 Sprint 5 on the Web-Team-Backlog board.
bwang edited projects, added Web-Team-Backlog ( Web Team FY2022-23 Q4 Sprint 5); removed Web-Team-Backlog.
gerritbot added a comment.Jun 1 2023, 6:35 PM

Change 922928 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):

[mediawiki/skins/Vector@master] Use Codex for typeahead search styles

https://gerrit.wikimedia.org/r/922928

gerritbot added a project: Patch-For-Review.Jun 1 2023, 6:35 PM
LGoto set the point value for this task to 3.Jun 5 2023, 5:39 PM
LGoto moved this task from Incoming to Ready for Development on the Web-Team-Backlog ( Web Team FY2022-23 Q4 Sprint 5) board.
bwang claimed this task.Jun 8 2023, 7:28 PM
bwang moved this task from Ready for Development to Doing on the Web-Team-Backlog ( Web Team FY2022-23 Q4 Sprint 5) board.
bwang added a parent task: T322077: Lower the maintenance costs of TypeaheadSearch in Vector.Jun 8 2023, 7:40 PM
gerritbot added a comment.Jun 8 2023, 8:58 PM

Change 922928 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):

[mediawiki/skins/Vector@master] Use Codex for typeahead search styles

https://gerrit.wikimedia.org/r/922928

bwang removed bwang as the assignee of this task.Jun 8 2023, 9:41 PM
bwang moved this task from Doing to Code Review on the Web-Team-Backlog ( Web Team FY2022-23 Q4 Sprint 5) board.
Jdlrobson claimed this task.Jun 10 2023, 12:13 AM
Jdlrobson subscribed.

@bwang sorry for the delay in review relating to the Codex work. I've been clearing out my email/Gerrit backlog but hope to get to this Monday.

gerritbot added a comment.Jun 13 2023, 1:25 AM

Change 922928 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Use Codex for typeahead search styles

https://gerrit.wikimedia.org/r/922928

Jdlrobson moved this task from Code Review to QA on the Web-Team-Backlog ( Web Team FY2022-23 Q4 Sprint 5) board.Jun 13 2023, 1:50 AM
ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.15; 2023-06-27).Jun 13 2023, 3:00 AM
Jdrewniak reassigned this task from Jdlrobson to bwang.Jun 13 2023, 4:45 PM
bwang mentioned this in T338957: Regression: Search button shown by default on page load .Jun 13 2023, 5:18 PM
bwang updated the task description. (Show Details)Jun 13 2023, 5:47 PM
Jdlrobson reassigned this task from bwang to Edtadros.Jun 14 2023, 8:17 PM
Jdlrobson raised the priority of this task from Medium to High.Jun 15 2023, 9:00 PM

This is now in production.

Edtadros moved this task from QA to Ready for Signoff on the Web-Team-Backlog ( Web Team FY2022-23 Q4 Sprint 5) board.Jun 16 2023, 10:24 PM

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Ventura
Browser: Chrome
Device: MBP
Emulated Device:NA

Test Artifact(s):

QA Steps

✅ AC1: Ensure search design remains the same when loading in Vue (i.e. after focusing and typing into the searchbar)

Screen Recording 2023-06-16 at 3.14.19 PM.mov.gif (594×1 px, 462 KB)
Screen Recording 2023-06-16 at 3.19.55 PM.mov.gif (594×1 px, 389 KB)

✅ AC2: Ensure search still works when JS is disabled

Screen Recording 2023-06-16 at 3.22.29 PM.mov.gif (594×1 px, 287 KB)

Edtadros removed Edtadros as the assignee of this task.Jun 16 2023, 10:34 PM
Edtadros subscribed.

Test Result - Prod

Status: ✅ PASS
Environment: Enwiki
OS: macOS Ventura
Browser: Chrome
Device: MBP
Emulated Device:NA

Test Artifact(s):

QA Steps

✅ AC1: Ensure search design remains the same when loading in Vue (i.e. after focusing and typing into the searchbar)

Screen Recording 2023-06-16 at 3.25.30 PM.mov.gif (594×1 px, 783 KB)

Screen Recording 2023-06-16 at 3.26.18 PM.mov.gif (594×1 px, 364 KB)

✅ AC2: Ensure search still works when JS is disabled

Screen Recording 2023-06-16 at 3.27.33 PM.mov.gif (594×1 px, 670 KB)

Edtadros updated the task description. (Show Details)Jun 16 2023, 10:43 PM
Jdlrobson closed this task as Resolved.Jun 16 2023, 10:57 PM
Jdlrobson claimed this task.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits