As a mentor at es.wp, I have been suggested for praise a couple of accounts that are already blocked: one for vandalic edits and other due identity theft. This situation could be frustrating for mentors. They may find it disappointing and time-costly to be suggested newcomers that aren't praiseworthy at all.
So, blocked accounts should be removed from the personalised praise suggestions.
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Personalized praise: Do not suggest blocked mentees | mediawiki/extensions/GrowthExperiments | master | +20 -0 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | KStoller-WMF | T248330 [EPIC] Growth: Positive reinforcement | |||
| Open | None | T317817 [EPIC] Positive Reinforcement: Personalized Praise | |||
| Resolved | Urbanecm_WMF | T338525 Exclude blocked accounts from the Personalized praise suggestions |
Thanks for noticing this and filling the task @Zapipedia-WMF! This certainly makes a lot of sense. Let's fix this :).
I think we should leave out mentees with any block at all, as even a partial block is a strong indicator that the mentee is actually not really praiseworthy.
Change 928828 had a related patch set uploaded (by Urbanecm; author: Urbanecm):
[mediawiki/extensions/GrowthExperiments@master] Personalized praise: Do not suggest blocked mentees
Change 928828 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Personalized praise: Do not suggest blocked mentees
Checked on testwiki wmf.17 - tried several types of blocks - a blocked user doesn't appear in Personalized Praise module.