I have been suggested for praise a mentee that not only has all their edits reverted but it is already permanently blocked. Block accounts should not be suggested for praise neither.

In T338263#8915809, @Zapipedia-WMF wrote:

I have been suggested for praise a mentee that not only has all their edits reverted but it is already permanently blocked. Block accounts should not be suggested for praise neither.

FTR, this should be handled by the changes implemented in T338525: Exclude blocked accounts from the Personalized praise suggestions. If blocked users are still getting recommended, please raise it up on that task or ping me directly. Thanks!

Change 940338 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@master] Personalized praise: Allow mentors to customize maximum number of reverted edits

https://gerrit.wikimedia.org/r/940338

As we now have T337510: Add revert scorecard to Personalized praise module on Mentor dashboard done, this is an easy task to complete, so I uploaded a patch. The settings dialog will look like this once it is merged:

@KStoller-WMF @Trizek-WMF @Zapipedia-WMF Do you have any suggestions/feedback for the copy I used?

Thanks, @Urbanecm_WMF! I can't think of improved copy that doesn't also increase the length of the copy significantly.
But we might want to opt for using "mentee" rather than "user":

Maximum number of reverts the mentee can have

And I think this copy helps clarify the feature further:

Maximum number of reverts the mentee can have and still be surfaced as praise-worthy.

But that might be too long for that space; so I'm fine with the current shorter copy if you prefer.

As for the text that helps clarify the text field...

Current copy:

If the field is empty, the number of the mentee's reverted edits is ignored

I suggest:

If this field is empty, then the mentee's reverted edit count is ignored

I had to read the interface twice to understand what I was supposed to do to ignore the number of reverts.
I would go with a pre-filled, like 3, and not allow an empty state. If someone wants to get newcomers with reverts, they can change this number to 100.

Thanks for the feedback. The longer text takes more than one line (and translations tend to get it longer rather than shorter), so I prefer the shorter version:

We can definitely disallow the empty state -- I didn't want to change the behaviour for current users, but I don't insist on that :). So, final interface as of my patch:

In T338263#9062062, @Urbanecm_WMF wrote:
Thanks for the feedback. The longer text takes more than one line (and translations tend to get it longer rather than shorter), so I prefer the shorter version

👍 Totally understandable, that was my assumption.

I didn't want to change the behaviour for current users

👍 agreed, this new field should just be an extra for Mentors who care to make the adjustment. Thanks!

Change 940338 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Personalized praise: Allow mentors to customize maximum number of reverted edits

https://gerrit.wikimedia.org/r/940338