Vector-2022: language selector doesn't work without JS (IE, Windows XP)
Closed, ResolvedPublic2 Estimated Story PointsBUG REPORT
Actions

Assigned To

None

Authored By

	Nux
	Jun 16 2023, 2:31 AM

Description

Steps to replicate the issue (include links if applicable):

Browser without JS or Grade C (or Grade X without JS probably).
Open some page with i18n (WD). E.g. https://en.wikipedia.org/wiki/Wikipedia:Village_pump_(technical)
Try to choose a different language.

What happens?:

Menu remains closed when clicking on it.

What should have happened instead?:

Make the menu visible in a sidebar or something that is shown when JS is disabled.

Software version (skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

QA Results - Beta

AC	Status	Details
1	✅	T339321#8959730

QA Results - Prod

AC	Status	Details
1	✅	T339321#8974953

Details

	Subject	Repo	Branch	Lines +/-
	Ensure language button works for no js users,	mediawiki/skins/Vector	master	+21 -17

Customize query in gerrit

Event Timeline

Nux created this task.Jun 16 2023, 2:31 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 16 2023, 2:31 AM

Jdlrobson added a project: Language-Team.Jun 16 2023, 2:51 PM

This looks like a web team bug that we should prioritize high since languages are part of the content.

Note that on Village pump someone mentioned that the i18n menu doesn't work in Opera GX so that is kind of weird. I don't have that one but I tested with IE on Windows 10 (via Edge).

• Nikerabbit moved this task from Backlog to Other teams/Watching on the Language-Team board.Jun 19 2023, 11:06 AM

LGoto set the point value for this task to 2.Jun 20 2023, 4:32 PM

Jdlrobson moved this task from Incoming to Ready for Development on the Web-Team-Backlog (Web Team FY2022-23 Q4 Sprint 6) board.Jun 20 2023, 4:32 PM

bwang claimed this task.Jun 21 2023, 7:02 PM

bwang moved this task from Ready for Development to Doing on the Web-Team-Backlog (Web Team FY2022-23 Q4 Sprint 6) board.

Change 931998 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):

[mediawiki/skins/Vector@master] Ensure language button works for no js users, factor out mixin for right aligning menus

https://gerrit.wikimedia.org/r/931998

gerritbot added a project: Patch-For-Review.Jun 21 2023, 8:13 PM

bwang moved this task from Doing to Code Review on the Web-Team-Backlog (Web Team FY2022-23 Q4 Sprint 6) board.Jun 21 2023, 8:34 PM

bwang removed bwang as the assignee of this task.Jun 21 2023, 8:55 PM

bwang subscribed.

Jdlrobson claimed this task.Jun 22 2023, 4:31 PM

Jdlrobson reassigned this task from Jdlrobson to Edtadros.Jun 22 2023, 9:18 PM

Jdlrobson moved this task from Code Review to QA on the Web-Team-Backlog (Web Team FY2022-23 Q4 Sprint 6) board.

Change 931998 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Ensure language button works for no js users,

https://gerrit.wikimedia.org/r/931998

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.15; 2023-06-27).Jun 22 2023, 10:00 PM

Maintenance_bot removed a project: Patch-For-Review.Jun 22 2023, 10:10 PM

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Ventura
Browser: Chrome
Device: MBP
Emulated Device:NA

Test Artifact(s):

QA Steps

Browser without JS or Grade C (or Grade X without JS probably).
Open some page with i18n (WD). E.g. https://en.wikipedia.org/wiki/Wikipedia:Village_pump_(technical)
Try to choose a different language.
✅ AC1: Language menu should open

Screen Recording 2023-06-22 at 5.23.01 PM.mov.gif (766×1 px, 551 KB)

Edtadros updated the task description. (Show Details)Jun 23 2023, 7:04 PM

Jdlrobson claimed this task.Jun 26 2023, 5:21 PM

Jdlrobson moved this task from Ready for Signoff to QA in Production on the Web-Team-Backlog (Web Team FY2022-23 Q4 Sprint 6) board.Jun 27 2023, 12:06 AM

It should be possible to QA this on he.wikipedia.org on Wednesday. https://he.wikipedia.org/wiki/%D7%94%D7%90%D7%99%D7%9E%D7%A4%D7%A8%D7%99%D7%94_%D7%94%D7%A8%D7%95%D7%9E%D7%99%D7%AA is broken at time of writing.

Test Result - Prod

Status: ✅ PASS
Environment: hewiki
OS: macOS Ventura
Browser: Chrome
Device: MBP
Emulated Device:NA

Test Artifact(s):

QA Steps

Browser without JS or Grade C (or Grade X without JS probably).
Open some page with i18n (WD). E.g. https://he.wikipedia.org/wiki/%D7%94%D7%90%D7%99%D7%9E%D7%A4%D7%A8%D7%99%D7%94_%D7%94%D7%A8%D7%95%D7%9E%D7%99%D7%AA
Try to choose a different language.
✅ AC1: Language menu should open

Screen Recording 2023-06-28 at 4.37.52 PM.mov.gif (950×1 px, 877 KB)

Edtadros updated the task description. (Show Details)Jun 28 2023, 11:41 PM

Hi, on the Village pump of frwiki an anonymous user has reported that language switcher is not working for him, starting from June 26.

	F37122533: Screen Recording 2023-06-28 at 4.37.52 PM.mov.gif
	Jun 28 2023, 11:39 PM

	F37115002: Screen Recording 2023-06-22 at 5.23.01 PM.mov.gif
	Jun 23 2023, 7:03 PM

Vector-2022: language selector doesn't work without JS (IE, Windows XP)Closed, ResolvedPublic2 Estimated Story PointsBUG REPORTActions

Description

QA Results - Beta

QA Results - Prod

Details

Event Timeline

Test Result - Beta

QA Steps

Test Result - Prod

QA Steps

Vector-2022: language selector doesn't work without JS (IE, Windows XP)
Closed, ResolvedPublic2 Estimated Story PointsBUG REPORT
Actions