We've accumulated quite some warnings on the MentorDashboard coming from the mentees table and the personalized praise module. Cleaning them would facilitate the T338830: Migrate GrowthExperiments to Vue 3 task.
Also we have a "fail on console warning" script that should catch this warnings. If it didn't it could be for two reasons, (1) The code producing the warning is not tested. (2) The script is not working correctly. Might be worth confirming which is the case.
Checklist
- [Vue warn]: injection "RENDER_MODE" not found. Several.
- [Vue warn]: Invalid prop: type check failed for prop "title". Expected String with value "Settings", got Object
- [Vue warn]: Invalid prop: type check failed for prop "closeButtonLabel". Expected String with value "Cancel", got Object
- [Vue warn]: Invalid prop: type check failed for prop "mentee". Expected Array, got Object
- [Vue warn]: Invalid prop: type check failed for prop "renderThirdPerson". Expected Boolean, got String with value "true".
Acceptance criteria
- Mentor dashboard only shows "known warnings" (see list).
- Confirm fail-on-console-script is working for mentor dashboard files
Nice to have
- Add missing coverage for the missed warnings. (A snapshot could just work fine)