Page MenuHomePhabricator

Clean mentor dashboard warnings
Closed, ResolvedPublic

Description

We've accumulated quite some warnings on the MentorDashboard coming from the mentees table and the personalized praise module. Cleaning them would facilitate the T338830: Migrate GrowthExperiments to Vue 3 task.

Also we have a "fail on console warning" script that should catch this warnings. If it didn't it could be for two reasons, (1) The code producing the warning is not tested. (2) The script is not working correctly. Might be worth confirming which is the case.

Checklist

  • [Vue warn]: injection "RENDER_MODE" not found. Several.
  • [Vue warn]: Invalid prop: type check failed for prop "title". Expected String with value "Settings", got Object
  • [Vue warn]: Invalid prop: type check failed for prop "closeButtonLabel". Expected String with value "Cancel", got Object
  • [Vue warn]: Invalid prop: type check failed for prop "mentee". Expected Array, got Object
  • [Vue warn]: Invalid prop: type check failed for prop "renderThirdPerson". Expected Boolean, got String with value "true".

Acceptance criteria

  • Mentor dashboard only shows "known warnings" (see list).
  • Confirm fail-on-console-script is working for mentor dashboard files

Nice to have

  • Add missing coverage for the missed warnings. (A snapshot could just work fine)

Event Timeline

Sgs renamed this task from Clea< to Clean mentor dashboard warnings.Jun 22 2023, 10:37 AM
Sgs removed Sgs as the assignee of this task.
Sgs updated the task description. (Show Details)
Sgs edited subscribers, added: Urbanecm_WMF; removed: Catrope, egardner.

Change 932329 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@master] MentorDashboard: Fix several Vue warnings

https://gerrit.wikimedia.org/r/932329

Urbanecm_WMF triaged this task as Medium priority.

Fixing patch uploaded, I'll work on the coverage soon.

Sgs updated the task description. (Show Details)

Change 932329 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] MentorDashboard: Fix several Vue warnings

https://gerrit.wikimedia.org/r/932329

Change 932593 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@master] [WIP] Add basic coverage for PersonalizedPraise

https://gerrit.wikimedia.org/r/932593

Change 932593 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] [tests] Add basic test coverage for PersonalizedPraise

https://gerrit.wikimedia.org/r/932593

Etonkovidova subscribed.

Checked in wmf.17 testwiki - the warnings listed in the task are not present.