See migration instructions in T289020.
This code was written after the first part of the Vue 2->3 migration, so there hopefully shouldn't be much to migrate.
Modules/folders
Checklist per module
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Duplicate | • STH | T302350 <Core Technology> Upgrade MediaWiki to Vue 3 | |||
| In Progress | None | T289017 [EPIC] <Core Technology> Upgrade MediaWiki projects from Vue 2 to Vue 3 | |||
| Resolved | egardner | T289020 Migrate all extension/skin code to Vue 3 | |||
| Resolved | Sgs | T338830 Migrate GrowthExperiments to Vue 3 | |||
| Resolved | Urbanecm_WMF | T340104 Clean mentor dashboard warnings |
Change 932203 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):
[mediawiki/extensions/GrowthExperiments@master] Mentor dashboard: migrate to Vue 3
Change 932203 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Mentor dashboard: migrate to Vue 3
Change 933607 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):
[mediawiki/extensions/GrowthExperiments@master] NewImpact: migrate to Vue 3
Change 933607 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] NewImpact: migrate to Vue 3
Note for QA engineers; only the mentor dashboard and the (new) impact module are affected by this change. For testing we should check that "nothing is broken" and that the Vue warnings ([Vue warn]:...) thrown in the JS console are safe to ignore, see warnings that can be ignored.
Change 936255 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):
[mediawiki/extensions/GrowthExperiments@master] Mentor dashboard: add Vue compiler options
Even with the new patch I just +2'ed, I can see a new warning present:
[Vue warn]: (deprecation ATTR_FALSE_VALUE) Attribute "aria-disabled" with v-bind value `false` will render aria-disabled="false" instead of removing it in Vue 3. To remove the attribute, use `null` or `undefined` instead. If the usage is intended, you can disable the compat behavior and suppress this warning with:
configureCompat({ ATTR_FALSE_VALUE: false })
Details: https://v3-migration.vuejs.org/breaking-changes/attribute-coercion.html
at <CdxMenuItem key=5 ref_for=true ref=fn<ref> ... >
at <CdxMenu id="cdx-select-menu-3" ref="menu" selected=10 ... >
at <CdxSelect selected=10 onUpdate:selected= (2) [ƒ, ƒ] class="ext-growthExperiments-DataTableLimit__select" ... >
at <Anonymous limit-options= (5) [5, 10, 15, 20, 25] limit=10 onUpdate=fn<bound onLimitChange> >
at <Anonymous key=0 class="ext-growthExperiments-MenteeOverview__table" limit=10 ... >
at <App>Not sure how that got (re)introduced? It doesn't seem to break anything with or without the core patch though.
Change 936255 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Mentor dashboard: add Vue compiler options
@Urbanecm_WMF - I didn't encounter that one, there is another vue warning on Special"MentorDashboard page that is not on the list of Migration_warnings_that_can_be_ignored
[Vue warn]: (deprecation ATTR_FALSE_VALUE) (2) at <CdxSelect selected=15 onUpdate:selected= (2) [ƒ, ƒ] class="ext-growthExperiments-DataTableLimit__select" ... > at <Anonymous limit-options= (5) [5, 10, 15, 20, 25] limit=15 onUpdate=fn<bound onLimitChange> > at <Anonymous key=0 class="ext-growthExperiments-MenteeOverview__table" limit=15 ... >
Any concerns?
At the time of writing this comment the warning is gone. Maybe because the underlying component causing it (Codex's Select) has been refactored. In any case Migration_warnings_that_can_be_ignored mentions about this warning annoyingly sticking after the migration process is done so no concerns about it.