Text selection sometimes incorrectly highlights a sentence because of some punctuation marks such as "i. e." or "Mr." among others.
This is an improvement to T328906
Description
Description
Details
Details
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Add test spec and improve the split sentences util | mediawiki/extensions/Wikistories | master | +139 -10 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T318899 Text Enhancements on Wikistories | |||
| Resolved | SBisson | T328906 Improve story text selection | |||
| Resolved | BUG REPORT | hueitan | T341989 Incorrect text selection highlight by punctuation. | ||
| Resolved | BUG REPORT | hueitan | T344364 Text selection feature on bullet points and quote |
Event Timeline
Comment Actions
Change 939301 had a related patch set uploaded (by Huei Tan; author: Huei Tan):
[mediawiki/extensions/Wikistories@master] Add test spec and improve the split sentences util
Comment Actions
Change 939301 merged by jenkins-bot:
[mediawiki/extensions/Wikistories@master] Add test spec and improve the split sentences util
Comment Actions
@hueitan Is this an issue or as designed?
Status: ❓
Environment: Beta
OS: macOS Ventura
Browser: Chrome 116
Device: MBP
Emulated Device: via DevTool
Test Links:
Desktop: https://en.wikipedia.beta.wmflabs.org/wiki/Beech_marten
Mobile Story Edit: https://en.m.wikipedia.beta.wmflabs.org/wiki/Special:StoryBuilder/Story:Beech_MArtin?frameid=0#story
Editing my story is not pulling in the updated changes I did for the article.
Steps
- I edit the article so it can have Mr., i.e. and ex.
- Click on replace when I edit the article which brings me to the article to select the content.
- As you see my edits are updated when you go to the article but when I edit my story, it's still showing the original article w/o my changes.
Comment Actions
As you see my edits are updated when you go to the article but when I edit my story, it's still showing the original article w/o my changes.
The story builder fetches the article content through the rest v1 api mobile-html, that means the content you see is from wikipedia.org
I suggest you find different articles for testing.
Comment Actions
@hueitan Please see the issue below and let me know how I should proceed, thanks!
Status: ❓
Environment: Beta
OS: macOS Ventura
Browser: Chrome 116, Firefox 116, Safari 16.6
Device: MBP
Emulated Device:Iphone 12, Ipad Mini, Pixel 6, Samsung Galaxy 20 Ultra via DevTool
Test Links:
https://en.m.wikipedia.beta.wmflabs.org/wiki/Special:StoryBuilder/Story:Dog_Test?frameid=0#article
https://en.m.wikipedia.beta.wmflabs.org/wiki/Special:StoryBuilder/Mr._Bean#story
https://en.m.wikipedia.beta.wmflabs.org/wiki/Special:StoryBuilder/Harry_Potter#article
| i.e. | Mr. & : | - | ... |
 |  |  |  |
Issues:
Bullets
https://en.m.wikipedia.beta.wmflabs.org/wiki/Special:StoryBuilder/Mr._Bean#story
I see that T344364 is created for bullets, which you can't even select any of the bullets.
Quotes
https://en.m.wikipedia.beta.wmflabs.org/wiki/Special:StoryBuilder/Harry_Potter#article
Should quotes be included on T344364 or a separate ticket since you can select them separately unlike with the bullets, you can't choose them at all?
 |  |
Comment Actions
Thanks @GMikesell-WMF I have added the quote into T344364: Text selection feature on bullet points and quote, thanks for raising it.
Comment Actions
@hueitan Sounds good, I will move this to sign off. Thanks for your work!
Status: ✅ PASS
Environment: Beta
OS: macOS Ventura
Browser: Chrome 116, Firefox 116, Safari 16.6
Device: MBP
Emulated Device:Iphone 12, Ipad Mini, Pixel 6, Samsung Galaxy 20 Ultra via DevTool
Test Links:
https://en.m.wikipedia.beta.wmflabs.org/wiki/Special:StoryBuilder/Story:Dog_Test?frameid=0#article
https://en.m.wikipedia.beta.wmflabs.org/wiki/Special:StoryBuilder/Mr._Bean#story
https://en.m.wikipedia.beta.wmflabs.org/wiki/Special:StoryBuilder/Harry_Potter#article