Text selection feature on bullet points and quote
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	eamedina
	Aug 16 2023, 3:34 PM

Description

When selecting text in the Article view, text that's part of bullet points is not selected. Nothing happens when you click on such text:

Bullet Points

T341989-screenshot-test (1×640 px, 207 KB)

Quotes
https://en.m.wikipedia.beta.wmflabs.org/wiki/Special:StoryBuilder/Harry_Potter#article

Should quotes be included on T344364 or a separate ticket since you can select them separately unlike with the bullets, you can't choose them at all?

NOTE: consider whether sentencex would be a good replacement for our sentence split algorithm.

QA Results - Beta

AC	Status	Details
1	✅	https://phabricator.wikimedia.org/T344364 here

Details

	Subject	Repo	Branch	Lines +/-
	Text selection for bullet points and quote	mediawiki/extensions/Wikistories	master	+1 -1

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Open		None	T318899 Text Enhancements on Wikistories
Resolved		SBisson	T328906 Improve story text selection
Resolved	BUG REPORT	hueitan	T341989 Incorrect text selection highlight by punctuation.
Resolved	BUG REPORT	hueitan	T344364 Text selection feature on bullet points and quote

Event Timeline

eamedina created this task.Aug 16 2023, 3:34 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 16 2023, 3:34 PM

eamedina triaged this task as Low priority.Aug 16 2023, 3:34 PM

PWaigi-WMF added a parent task: T341989: Incorrect text selection highlight by punctuation..Aug 17 2023, 2:19 PM

GMikesell-WMF mentioned this in T341989: Incorrect text selection highlight by punctuation..Aug 17 2023, 10:42 PM

hueitan renamed this task from Text selection feature not working on bullet points to Text selection feature on bullet points and quote.Aug 18 2023, 8:02 AM

hueitan updated the task description. (Show Details)

vaughnwalters mentioned this in T328906: Improve story text selection.Aug 23 2023, 10:59 PM

SBisson edited projects, added Inuka-Team (Kanban); removed Inuka-Team.Oct 17 2023, 7:58 PM

PWaigi-WMF moved this task from Backlog to Ready for Dev on the Inuka-Team (Kanban) board.Oct 19 2023, 2:36 PM

SBisson updated the task description. (Show Details)Nov 6 2023, 8:00 PM

hueitan claimed this task.Nov 7 2023, 11:15 AM

hueitan moved this task from Ready for Dev to Dev on the Inuka-Team (Kanban) board.

Change 972377 had a related patch set uploaded (by Huei Tan; author: Huei Tan):

[mediawiki/extensions/Wikistories@master] Text selection for bullet points and quote

https://gerrit.wikimedia.org/r/972377

gerritbot added a project: Patch-For-Review.Nov 7 2023, 1:14 PM

NOTE: consider whether sentencex would be a good replacement for our sentence split algorithm.

Yes, during the another task, the changes was made using the version of https://github.com/wikimedia/mediawiki-services-cxserver/blob/master/lib/segmentation/CXSegmenter.js, which becomes the sentencex later on.

hueitan moved this task from Dev to Code Review on the Inuka-Team (Kanban) board.Nov 7 2023, 2:39 PM

SBisson moved this task from Code Review to QA on the Inuka-Team (Kanban) board.Nov 7 2023, 6:24 PM

Change 972377 merged by jenkins-bot:

[mediawiki/extensions/Wikistories@master] Text selection for bullet points and quote

https://gerrit.wikimedia.org/r/972377

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.5; 2023-11-14).Nov 7 2023, 7:00 PM

Maintenance_bot removed a project: Patch-For-Review.Nov 7 2023, 7:11 PM

@hueitan You are now enabled to select bullets just like quotes as seen in the screenshots below. I will move this to Design Sign-Off. Thanks for all your work!

Status: ✅PASS
Environment: Beta: 1.42.0-alpha (141d776)
OS: macOS Sonoma 14.0
Browser: Chrome 119, Firefox 119, Safari 17.0
Skins. Minerva (Variety of Mobiles)
Device: MBA M2
Emulated Device:: n/a
Test Links:
https://en.m.wikipedia.beta.wmflabs.org/wiki/Special:StoryBuilder/Mr._Bean#story
https://en.m.wikipedia.beta.wmflabs.org/wiki/Special:StoryBuilder/Harry_Potter#article

✅AC1: https://phabricator.wikimedia.org/T344364

Quotes vs Bullets

Text Selection	Edit Story	View Story
Quotes
Bullets

GMikesell-WMF updated the task description. (Show Details)Nov 17 2023, 11:37 PM

GMikesell-WMF moved this task from QA to Design sign off on the Inuka-Team (Kanban) board.

SGautam_WMF moved this task from Design sign off to Product sign off on the Inuka-Team (Kanban) board.Dec 6 2023, 10:08 AM

PWaigi-WMF closed this task as Resolved.Dec 6 2023, 1:20 PM

Text selection feature on bullet points and quoteClosed, ResolvedPublicBUG REPORTActions