Page MenuHomePhabricator
Create Task
Maniphest T343006

Internal error when viewing /view/en/Special:WhatLinksHere
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

https://www.wikifunctions.org/view/en/Special:WhatLinksHere/Z802

[4f3ff6c0-7baf-46a4-8c1b-777e70c6e23b] 2023-07-28 15:18:14: Fatal exception of type "InvalidArgumentException"

Details

SubjectRepoBranchLines +/-
SpecialViewObject: Catch errors from trying to create the languagemediawiki/extensions/WikiLambdawmf/1.41.0-wmf.19+8 -1
SpecialViewObject: Catch errors from trying to create the languagemediawiki/extensions/WikiLambdamaster+8 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

Bugreporter created this task.Jul 28 2023, 3:19 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 28 2023, 3:19 PM
gerritbot added a comment.Jul 28 2023, 3:26 PM

Change 942679 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/WikiLambda@master] SpecialViewObject: Catch errors from trying to create the language

https://gerrit.wikimedia.org/r/942679

gerritbot added a project: Patch-For-Review.Jul 28 2023, 3:26 PM
Jdforrester-WMF changed the task status from Open to In Progress.Jul 28 2023, 3:27 PM
Jdforrester-WMF claimed this task.
Jdforrester-WMF added a project: Abstract Wikipedia team.
Jdforrester-WMF moved this task from To triage to In Progress on the Abstract Wikipedia team board.
Jdforrester-WMF added a parent task: T342820: Migrate wikifunctions.org from locked-down to limited mode, letting users edit wikitext pages and some.Jul 28 2023, 3:48 PM
Jdforrester-WMF changed the subtype of this task from "Task" to "Production Error".Jul 28 2023, 3:50 PM
Jdforrester-WMF triaged this task as High priority.Jul 28 2023, 4:07 PM
gerritbot added a comment.Jul 31 2023, 11:29 AM

Change 942679 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] SpecialViewObject: Catch errors from trying to create the language

https://gerrit.wikimedia.org/r/942679

Maintenance_bot removed a project: Patch-For-Review.Jul 31 2023, 12:11 PM
gerritbot added a comment.Jul 31 2023, 12:11 PM

Change 942739 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/WikiLambda@wmf/1.41.0-wmf.19] SpecialViewObject: Catch errors from trying to create the language

https://gerrit.wikimedia.org/r/942739

gerritbot added a project: Patch-For-Review.Jul 31 2023, 12:11 PM
gerritbot added a comment.Jul 31 2023, 12:19 PM

Change 942739 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@wmf/1.41.0-wmf.19] SpecialViewObject: Catch errors from trying to create the language

https://gerrit.wikimedia.org/r/942739

Jdforrester-WMF moved this task from In Progress to To deploy on the Abstract Wikipedia team board.Jul 31 2023, 12:21 PM
Maintenance_bot removed a project: Patch-For-Review.Jul 31 2023, 12:30 PM
ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.20; 2023-08-01).Jul 31 2023, 1:00 PM
Jdforrester-WMF moved this task from To deploy to Verify in production on the Abstract Wikipedia team board.Jul 31 2023, 1:11 PM
Stashbot mentioned this in T342901: MediaWiki\Extension\WikiLambda\ZErrorException: Not wellformed.Jul 31 2023, 1:13 PM

Mentioned in SAL (#wikimedia-operations) [2023-07-31T13:13:02Z] <James_F> WikiLambda backport verified for T342891 T342687 T341500 T343006 T342901 and T343041

Stashbot mentioned this in T343041: Links from wikitext to Objects should go to the /view/[lang]/ path not /wiki/.Jul 31 2023, 1:13 PM
Stashbot mentioned this in T342687: Object editor: Altering the label (Z2K3) in edit mode activates "done" in the dialog but doesn't activate the page-level edit mode, but others (Z2K4/Z2K5) do.
Stashbot mentioned this in T342891: Under `view/lang/zid` routes, Edit pages are rendered with "viewmode=true" even if `?action=edit` is present.
Stashbot mentioned this in T341500: Implement UX to select natural language one reads and edits Wikifunctions.
DVrandecic subscribed.Aug 1 2023, 3:13 AM

It's OK to redirect to the Main Page, but I was wondering if we could redirect

https://www.wikifunctions.org/view/en/Special:WhatLinksHere/Z802

to

https://www.wikifunctions.org/wiki/Special:WhatLinksHere/Z802?uselang=en ?

(Shall I file an additional task for that?)

Jdforrester-WMF added a comment.Aug 1 2023, 12:21 PM
In T343006#9057650, @DVrandecic wrote:

It's OK to redirect to the Main Page, but I was wondering if we could redirect

https://www.wikifunctions.org/view/en/Special:WhatLinksHere/Z802

to

https://www.wikifunctions.org/wiki/Special:WhatLinksHere/Z802?uselang=en ?

(Shall I file an additional task for that?)

Please do, though I worry about "search for something that looks like a ZID and redirect the user to that view page" when we don't (yet) display a notice that the user was redirected and why.

Bugreporter added a comment.EditedAug 1 2023, 12:23 PM
In T343006#9058879, @Jdforrester-WMF wrote:
In T343006#9057650, @DVrandecic wrote:

It's OK to redirect to the Main Page, but I was wondering if we could redirect

https://www.wikifunctions.org/view/en/Special:WhatLinksHere/Z802

to

https://www.wikifunctions.org/wiki/Special:WhatLinksHere/Z802?uselang=en ?

(Shall I file an additional task for that?)

Please do, though I worry about "search for something that looks like a ZID and redirect the user to that view page" when we don't (yet) display a notice that the user was redirected and why.

If we try to fix it we should also fix https://www.wikifunctions.org/view/en/w:test

Jdforrester-WMF added a comment.Aug 1 2023, 12:27 PM
In T343006#9058881, @Bugreporter wrote:

If we try to fix it we should also fix https://www.wikifunctions.org/view/en/w:test

I don't think that's related. I also don't agree that we should fix bad URLs like that.

DVrandecic closed this task as Resolved.Aug 3 2023, 4:25 AM

Filed T343405 for the followup.

Mormegil subscribed.Aug 10 2023, 2:44 PM

Redirecting to the Main Page is better than an exception, but… the whole behavior of that URL is strange. First, when being logged in with a non-English UI language, it does not redirect to the project main page, but to the (nonexisting) localized default main page name in the language. (E.g. for me, https://www.wikifunctions.org/view/en/Special:WhatLinksHere/Z802 redirects to https://www.wikifunctions.org/wiki/Hlavn%C3%AD_strana) When I tried to reproduce that, I went to https://www.wikifunctions.org/view/en/Special:WhatLinksHere/Z802?uselang=cs which… just shows the contents of Z802 directly? (As does https://www.wikifunctions.org/view/en/Special:WhatLinksHere/Z802?uselang=en, only the language differs… I guess there is an unsolved confusion between view/xx/... and ?uselang=yy there generally.)

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL