Page MenuHomePhabricator
Create Task
Maniphest T341500

Implement UX to select natural language one reads and edits Wikifunctions
Closed, ResolvedPublic
Actions

Assigned To
gengh
Authored By
DVrandecic
Jul 10 2023, 5:06 PM
Tags
Referenced Files
F37136691: image.png
Jul 12 2023, 8:27 AM
F37136690: image.png
Jul 12 2023, 8:27 AM
F37136031: image.png
Jul 11 2023, 2:54 PM
F37136029: image.png
Jul 11 2023, 2:54 PM
F37136021: image.png
Jul 11 2023, 2:54 PM
Subscribers
AAlhazwani-WMF
Aklapper
DVrandecic
Jdforrester-WMF
Masumrezarock100

Description

The following design sketch is suggested to be implemented:

Such as on Wikidata, on the very top have the language icon with the current setting next to it (e.g. English). This is clickable / tappable.

When actioned on, we get a modal with a text ("Select a language"), a language selector (based on our ZObjectSelector but restricted to languages), and a cancel action (e.g. a X in the corner or a cancel button) and an action button (Switch? OK?) that activates once a language is selected.

Once the language is selected, it takes us to the version of the given page in the respective language (The respective patterns are currently being implemented in T268678 )

It is OK if that link for now only works in Vector22 and is not immediately supported in Minerva. We will set up the default mobile skin to be Vector22. It has to work in both Vector22 and Minerva.

Details

SubjectRepoBranchLines +/-
Create standalone JS module with language selector for page headermediawiki/extensions/WikiLambdawmf/1.41.0-wmf.19+735 -18
Create standalone JS module with language selector for page headermediawiki/extensions/WikiLambdamaster+735 -18
[WIP] Implement user control to change language for Special:ViewObjectmediawiki/extensions/WikiLambdamaster+321 -58
Implement Special:ViewObject to provide a Special page version of NS0mediawiki/extensions/WikiLambdamaster+487 -159
Do not hardcode uls keymediawiki/skins/Vectormaster+3 -4
Customize query in gerrit

Related Objects
Search...

View Standalone Graph
This task is connected to more than 200 other tasks. Only direct parents and subtasks are shown here. Use View Standalone Graph to show more of the graph.
StatusSubtypeAssignedTask
· · ·
ResolvedcmassaroT342820 Migrate wikifunctions.org from locked-down to limited mode, letting users edit wikitext pages and some
ResolvedJdforrester-WMFT268678 Make Wikifunctions a true multi-lingual wiki, exposing content in each language to readers and search engines with parity
ResolvedgenghT341500 Implement UX to select natural language one reads and edits Wikifunctions
· · ·

Event Timeline

DVrandecic created this task.Jul 10 2023, 5:06 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 10 2023, 5:06 PM
DVrandecic added a parent task: T268678: Make Wikifunctions a true multi-lingual wiki, exposing content in each language to readers and search engines with parity.Jul 10 2023, 9:49 PM
DVrandecic updated the task description. (Show Details)Jul 10 2023, 10:03 PM
Restricted Application added a subscriber: Masumrezarock100. · View Herald TranscriptJul 10 2023, 10:03 PM
AAlhazwani-WMF subscribed.EditedJul 11 2023, 2:54 PM

here's a minimal design proposal, that builds on top of the existing zobject selector, filtered down to objects of type language.

  1. in the top navigation we could display a codex quiet button (with icon) displaying the current language (and icon-only button on smaller viewports).

image.png (1×2 px, 290 KB)

  1. on tap/click we display a lookup component where users can pick a language via a search. in the expanded menu we also display the UN6 languages as suggested items. for recurring editors, it might be beneficial to display as suggested items the languages they contributed to most often.

image.png (1×2 px, 350 KB)

  1. on search, we display results ordered alphabetically. if users select a result, we switch the UI language, and the content language to the selected language. if they move the focus out of the lookup, we switch back to the previous state.

image.png (990×2 px, 189 KB)

link to the figma file https://www.figma.com/file/SXfLGEz8sRZYtwA5gX7zHr/T341500-Natural-language-selector?type=design&node-id=31%3A11797&mode=design&t=Kpd3SDzOeNC6j8Ta-1

DVrandecic updated the task description. (Show Details)Jul 11 2023, 3:42 PM
DVrandecic added a comment.Jul 12 2023, 12:24 AM

Approved the design. Ready for implementation.

AAlhazwani-WMF attached a referenced file: F37136691: image.png. (Show Details)Jul 12 2023, 8:27 AM
AAlhazwani-WMF attached a referenced file: F37136690: image.png. (Show Details)
Jdforrester-WMF triaged this task as High priority.Jul 20 2023, 4:30 PM
Jdforrester-WMF claimed this task.Jul 21 2023, 12:59 AM
Jdforrester-WMF moved this task from Engineering tasks to In progress on the Abstract Wikipedia team (Phase λ – Launch) board.
gerritbot added a comment.Jul 21 2023, 1:00 AM

Change 932025 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/WikiLambda@master] Implement Special:ViewZObject to provide a Special page version of NS0

https://gerrit.wikimedia.org/r/932025

gerritbot added a project: Patch-For-Review.Jul 21 2023, 1:00 AM
gerritbot added a comment.Jul 21 2023, 4:17 PM

Change 940373 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Vector@master] Do not hardcode uls key

https://gerrit.wikimedia.org/r/940373

gerritbot added a comment.Jul 21 2023, 6:14 PM

Change 940373 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Do not hardcode uls key

https://gerrit.wikimedia.org/r/940373

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.19; 2023-07-25).Jul 21 2023, 7:00 PM
gerritbot added a comment.Jul 24 2023, 3:33 PM

Change 932025 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Implement Special:ViewObject to provide a Special page version of NS0

https://gerrit.wikimedia.org/r/932025

Maintenance_bot removed a project: Patch-For-Review.Jul 24 2023, 4:11 PM
gerritbot added a comment.Jul 26 2023, 2:48 PM

Change 941950 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/WikiLambda@master] [WIP] Implement user control to change language for Special:ViewObject

https://gerrit.wikimedia.org/r/941950

gerritbot added a project: Patch-For-Review.Jul 26 2023, 2:48 PM
Jdforrester-WMF added a parent task: T342820: Migrate wikifunctions.org from locked-down to limited mode, letting users edit wikitext pages and some.Jul 27 2023, 4:35 PM
Jdforrester-WMF moved this task from Phase λ – Launch to In Progress on the Abstract Wikipedia team board.
Jdforrester-WMF edited projects, added Abstract Wikipedia team; removed Abstract Wikipedia team (Phase λ – Launch).
gengh claimed this task.Jul 28 2023, 8:27 AM
gengh added a subscriber: Jdforrester-WMF.
gerritbot added a comment.Jul 31 2023, 8:46 AM

Change 943508 had a related patch set uploaded (by Genoveva Galarza; author: Genoveva Galarza):

[mediawiki/extensions/WikiLambda@master] Create standalone JS module with language selector for page header

https://gerrit.wikimedia.org/r/943508

gerritbot added a comment.Jul 31 2023, 10:21 AM

Change 941950 abandoned by Jforrester:

[mediawiki/extensions/WikiLambda@master] [WIP] Implement user control to change language for Special:ViewObject

Reason:

Going with Ia69f75c9e358d451ee8232dc66e067a3ce174e73

https://gerrit.wikimedia.org/r/941950

gerritbot added a comment.Jul 31 2023, 10:55 AM

Change 943508 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Create standalone JS module with language selector for page header

https://gerrit.wikimedia.org/r/943508

gerritbot added a comment.Jul 31 2023, 10:55 AM

Change 942738 had a related patch set uploaded (by Jforrester; author: Genoveva Galarza):

[mediawiki/extensions/WikiLambda@wmf/1.41.0-wmf.19] Create standalone JS module with language selector for page header

https://gerrit.wikimedia.org/r/942738

ReleaseTaggerBot edited projects, added MW-1.41-notes (1.41.0-wmf.20; 2023-08-01); removed MW-1.41-notes (1.41.0-wmf.19; 2023-07-25).Jul 31 2023, 11:00 AM
gerritbot added a comment.Jul 31 2023, 12:19 PM

Change 942738 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@wmf/1.41.0-wmf.19] Create standalone JS module with language selector for page header

https://gerrit.wikimedia.org/r/942738

Jdforrester-WMF moved this task from In Progress to To deploy on the Abstract Wikipedia team board.Jul 31 2023, 12:21 PM
Maintenance_bot removed a project: Patch-For-Review.Jul 31 2023, 12:31 PM
ReleaseTaggerBot edited projects, added MW-1.41-notes (1.41.0-wmf.19; 2023-07-25); removed MW-1.41-notes (1.41.0-wmf.20; 2023-08-01).Jul 31 2023, 1:00 PM
Jdforrester-WMF moved this task from To deploy to Verify in production on the Abstract Wikipedia team board.Jul 31 2023, 1:11 PM
Stashbot mentioned this in T342901: MediaWiki\Extension\WikiLambda\ZErrorException: Not wellformed.Jul 31 2023, 1:13 PM
Stashbot mentioned this in T343006: Internal error when viewing /view/en/Special:WhatLinksHere.
Stashbot mentioned this in T343041: Links from wikitext to Objects should go to the /view/[lang]/ path not /wiki/.
Stashbot mentioned this in T342687: Object editor: Altering the label (Z2K3) in edit mode activates "done" in the dialog but doesn't activate the page-level edit mode, but others (Z2K4/Z2K5) do.
Stashbot mentioned this in T342891: Under `view/lang/zid` routes, Edit pages are rendered with "viewmode=true" even if `?action=edit` is present.

Mentioned in SAL (#wikimedia-operations) [2023-07-31T13:13:02Z] <James_F> WikiLambda backport verified for T342891 T342687 T341500 T343006 T342901 and T343041

DVrandecic closed this task as Resolved.Aug 1 2023, 3:56 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL