Page MenuHomePhabricator
Create Task
Maniphest T342891

Under `view/lang/zid` routes, Edit pages are rendered with "viewmode=true" even if `?action=edit` is present
Closed, ResolvedPublicBUG REPORT
Actions

Description

Description

Steps to reproduce:

  1. Go to the function edit page using wiki/zid and ?action=edit : https://wikifunctions.beta.wmflabs.org/wiki/Z10014?action=edit
    • This is the correct page, it's fully editable
  2. Go to the edit page using view/lang/zid and ?action=edit: https://wikifunctions.beta.wmflabs.org/view/en/Z10014?action=edit
    • Vue reads action=edit and sets up the edit page
    • However, PHP sets viewmode=true,
    • so the whole document around the vue app is set as a view page, and
    • the parts of the vue app that look at the viewmode variable, are rendered as view

Screenshot from 2023-07-27 16-03-34.png (1×964 px, 104 KB)

  • in yellow: parts in edit mode
  • in pink: parts in view mode

Screenshot from 2023-07-27 16-03-342.png (1×964 px, 137 KB)

Expected behavior (Acceptance criteria):

  • View page should be correctly and fully rendered if ?action=edit in any of the available uris

Devices and Design (URLs or screenshots, if applicable):

  • Desktop: ...
  • Small screens/mobile: ...

Completion checklist

Details

SubjectRepoBranchLines +/-
Use mw.config JS variables instead of directly URL for edit/view modemediawiki/extensions/WikiLambdamaster+111 -22
SpecialViewObject: Don't load if action=edit etc.mediawiki/extensions/WikiLambdawmf/1.41.0-wmf.19+5 -1
SpecialViewObject: Don't load if action=edit etc.mediawiki/extensions/WikiLambdamaster+5 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

gengh created this task.Jul 27 2023, 2:11 PM
gengh updated the task description. (Show Details)Jul 27 2023, 2:20 PM
gengh updated the task description. (Show Details)
gengh updated the task description. (Show Details)Jul 27 2023, 2:26 PM
Jdforrester-WMF subscribed.Jul 27 2023, 3:02 PM

The proper edit link of course is https://wikifunctions.beta.wmflabs.org/wiki/Z10014?action=edit&uselang=en which is what's linked in the tabs, and works. We should check in action is set and redirect the page in the PHP, I suppose.

gerritbot added a comment.Jul 27 2023, 3:29 PM

Change 942451 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/WikiLambda@master] SpecialViewObject: Don't load if action=edit etc.

https://gerrit.wikimedia.org/r/942451

gerritbot added a project: Patch-For-Review.Jul 27 2023, 3:29 PM
Jdforrester-WMF added a parent task: T268678: Make Wikifunctions a true multi-lingual wiki, exposing content in each language to readers and search engines with parity.Jul 27 2023, 4:48 PM
Jdforrester-WMF moved this task from To triage to In Progress on the Abstract Wikipedia team board.
Jdforrester-WMF claimed this task.Jul 27 2023, 8:49 PM
Jdforrester-WMF changed the task status from Open to In Progress.Jul 27 2023, 9:19 PM
Jdforrester-WMF triaged this task as High priority.
gerritbot added a comment.Jul 28 2023, 5:29 PM

Change 942451 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] SpecialViewObject: Don't load if action=edit etc.

https://gerrit.wikimedia.org/r/942451

Maintenance_bot removed a project: Patch-For-Review.Jul 28 2023, 5:30 PM
ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.20; 2023-08-01).Jul 28 2023, 6:00 PM
gerritbot added a comment.Jul 28 2023, 8:05 PM

Change 942485 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/WikiLambda@wmf/1.41.0-wmf.19] SpecialViewObject: Don't load if action=edit etc.

https://gerrit.wikimedia.org/r/942485

gerritbot added a project: Patch-For-Review.Jul 28 2023, 8:05 PM
gerritbot added a comment.Jul 31 2023, 10:00 AM

Change 943516 had a related patch set uploaded (by Genoveva Galarza; author: Genoveva Galarza):

[mediawiki/extensions/WikiLambda@master] Use mw.config JS variables instead of directly URL for edit/view mode

https://gerrit.wikimedia.org/r/943516

gerritbot added a comment.Jul 31 2023, 12:19 PM

Change 942485 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@wmf/1.41.0-wmf.19] SpecialViewObject: Don't load if action=edit etc.

https://gerrit.wikimedia.org/r/942485

Jdforrester-WMF moved this task from In Progress to To deploy on the Abstract Wikipedia team board.Jul 31 2023, 12:33 PM
gerritbot added a comment.Jul 31 2023, 12:42 PM

Change 943516 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Use mw.config JS variables instead of directly URL for edit/view mode

https://gerrit.wikimedia.org/r/943516

ReleaseTaggerBot edited projects, added MW-1.41-notes (1.41.0-wmf.19; 2023-07-25); removed MW-1.41-notes (1.41.0-wmf.20; 2023-08-01).Jul 31 2023, 1:00 PM
Maintenance_bot removed a project: Patch-For-Review.Jul 31 2023, 1:11 PM
Stashbot mentioned this in T342901: MediaWiki\Extension\WikiLambda\ZErrorException: Not wellformed.Jul 31 2023, 1:13 PM
Stashbot mentioned this in T343006: Internal error when viewing /view/en/Special:WhatLinksHere.
Stashbot mentioned this in T343041: Links from wikitext to Objects should go to the /view/[lang]/ path not /wiki/.
Stashbot mentioned this in T342687: Object editor: Altering the label (Z2K3) in edit mode activates "done" in the dialog but doesn't activate the page-level edit mode, but others (Z2K4/Z2K5) do.

Mentioned in SAL (#wikimedia-operations) [2023-07-31T13:13:02Z] <James_F> WikiLambda backport verified for T342891 T342687 T341500 T343006 T342901 and T343041

Stashbot mentioned this in T341500: Implement UX to select natural language one reads and edits Wikifunctions.Jul 31 2023, 1:13 PM
Jdforrester-WMF moved this task from To deploy to Verify in production on the Abstract Wikipedia team board.Jul 31 2023, 1:56 PM
DVrandecic subscribed.Aug 1 2023, 3:17 AM

Now https://www.wikifunctions.org/view/en/Z10000?action=edit redirects to the main page, and not to https://www.wikifunctions.org/wiki/Z10000?action=edit&uselang=en - is that intentional?

(Checked in prod)

Jdforrester-WMF added a comment.Aug 1 2023, 12:20 PM
In T342891#9057653, @DVrandecic wrote:

Now https://www.wikifunctions.org/view/en/Z10000?action=edit redirects to the main page, and not to https://www.wikifunctions.org/wiki/Z10000?action=edit&uselang=en - is that intentional?

(Checked in prod)

The second patch (from Geno) changes it to leave you at the read page; this will go out in the train today, and I think is good enough.

DVrandecic closed this task as Resolved.Aug 3 2023, 4:19 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL