Patroller Tasks: user information popup dialog
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Dbrant
	Aug 8 2023, 5:36 PM

Description

The designs call for a small popup dialog that contains certain bits of user information (Tenure, Edit Count).

When tapping on any user name in the "List of edits" screen, it should pop up a menu that includes an option to see "User information". When that option is selected, this popup is shown.

When the dialog is shown, it can make an API call to get the user's tenure and (global) contributions.

5. Tapping username opens menu	6. 'User information' from menu

Tapping username opens menu

Tapping on the username button will display a menu with the following options:
View user page
View talk page
User information
View user contributions
Thank

User information' from menu

User information
Taping this option from the menu opens a modal with the editors ‘Tenure’, and ‘Edit count’.

APK: https://github.com/wikimedia/apps-android-wikipedia/pull/4160/checks

Related Objects
Search...

Status	Assigned	Task
Resolved	Dbrant	T322083 [EPIC] Anti-Vandalism Microtasks on Android
Resolved	JTannerWMF	T343224 [Sub-Epic] Main implementation task for Anti-Vandalism microtask on Android V1
Resolved	cooltey	T343835 Patroller Tasks: user information popup dialog

Event Timeline

Dbrant created this task.Aug 8 2023, 5:36 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 8 2023, 5:36 PM

Dbrant triaged this task as Medium priority.Aug 8 2023, 5:36 PM

Dbrant added a parent task: T343224: [Sub-Epic] Main implementation task for Anti-Vandalism microtask on Android V1 .Aug 8 2023, 5:47 PM

cooltey claimed this task.Aug 29 2023, 11:51 PM

cooltey moved this task from Ready for dev to Doing on the Wikipedia-Android-App-Backlog (Android Release - FY2023-24) board.

cooltey updated the task description. (Show Details)

cooltey attached a referenced file: F37160430: User information modal.png. (Show Details)Aug 30 2023, 12:11 AM

cooltey attached a referenced file: F37543168: Menu.png. (Show Details)

Hi @OTichonova

The user information dialog implementation is completed, please download the APK from the ticket description, thanks!

Hi @cooltey, thank you! Just one question below.

User information modal

Hi @OTichonova

In T343835#9146081, @OTichonova wrote:

Hi @cooltey, thank you! Just one question below.

User information modal

Yes, will do.

Another question:
Feedback from @Dbrant about the wording on the user information dialog.
https://github.com/wikimedia/apps-android-wikipedia/pull/4168#discussion_r1317356160

Are we sure everyone knows what the word "Tenure" means? Would it be simpler if we just say "Joined Wikipedia nnn years ago"? Or even "Joined Wikipedia on [date]" (in the standard date format)? This way we wouldn't need to hand-craft unnecessary strings and logic for time spans.

It actually makes sense to me that in the translated zh-tw string, the text has been translated to a word that might confuse users.

Would it be possible to change Tenure to Joined Wikipedia on [date]?

cc @JTannerWMF

Hi @cooltey! The updated user information modal.

User information modal.png (720×360 px, 34 KB)

OTichonova updated the task description. (Show Details)Sep 7 2023, 4:16 PM

Hi @OTichonova

It looks like the wording is slightly long in this case if we choose to use MMM dd, YYYY here.

Maybe we need to:

Shorten the horizontal padding to 12dp to keep the word in a single line.
Shorten the wording: for example: Joined on.
Customize the short date format to MM/dd/YY
Adjust the layout to fit the text and also the date.


`12dp` horizontal padding	`24` horizontal padding

You can download the latest APK from the ticket description to see the changes.

cc @JTannerWMF

Hi @cooltey, thank you for writing this out!
I wouldn't touch the padding in this case and as you mentioned it would be good to have consistency of how the date is displayed throughout the app.

Maybe we can change the text to 'Account from:'
I was looking at 'Joined on:' and I think it might be a little unspecific.

User information.png (720×360 px, 34 KB)

In T343835#9152281, @OTichonova wrote:

Hi @cooltey, thank you for writing this out!
I wouldn't touch the padding in this case and as you mentioned it would be good to have consistency of how the date is displayed throughout the app.

Maybe we can change the text to 'Account from:'
I was looking at 'Joined on:' and I think it might be a little unspecific.