Page MenuHomePhabricator
Create Task
Maniphest T344382

[Edit Check] Publish changes button in VE does not react anymore after abandoning Edit Check by switching to read mode
Closed, ResolvedPublic
Actions

Description

  1. Go to this page: https://patchdemo.wmflabs.org/wikis/9a60b4369e/wiki/Douglas_Adams
  2. Add at-least 50 characters of new content to trigger Edit check.
  3. When the Edit Check reference dialog appears switch to read mode.
  4. Open the editor again and make another edit. (Note: it doesn't have to be the one that would trigger edit check)
  5. Click on the Publish changes button.

Observed Result: The Publish changes button doesn't do anything. Refreshing does make the button work again.

Details

SubjectRepoBranchLines +/-
Edit check: stop an error on save if no reference-needing content addedmediawiki/extensions/VisualEditormaster+3 -1
Edit check: Clean up when VE is deactivatedmediawiki/extensions/VisualEditormaster+9 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

Ryasmeen created this task.Aug 16 2023, 9:58 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 16 2023, 9:58 PM
ppelberg added projects: VisualEditor, Editing-team (Kanban Board).Sep 11 2023, 10:47 PM
ppelberg moved this task from Incoming to Ready to Be Worked On on the Editing-team (Kanban Board) board.
ppelberg added a parent task: T331947: [RELEASE TICKET] Make Edit Check MVP available to all newcomers at Partner Wikipedias.
ppelberg mentioned this in T331947: [RELEASE TICKET] Make Edit Check MVP available to all newcomers at Partner Wikipedias.
ppelberg added a project: Goal.
Esanders subscribed.Sep 12 2023, 10:12 AM

ArticleTarget.saveDialogIsOpening is set while edit check is running (as it interrupts the save process), and if we teardown the target it never gets reset to false.

On the next load it blocks the save dialog opening.

gerritbot added a comment.Sep 12 2023, 10:40 AM

Change 956829 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/VisualEditor@master] Edit check: Clean up when VE is deactivated

https://gerrit.wikimedia.org/r/956829

gerritbot added a project: Patch-For-Review.Sep 12 2023, 10:40 AM
Esanders claimed this task.Sep 12 2023, 10:41 AM
Esanders moved this task from Ready to Be Worked On to Code Review on the Editing-team (Kanban Board) board.
gerritbot added a comment.Sep 12 2023, 1:13 PM

Change 956829 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Edit check: Clean up when VE is deactivated

https://gerrit.wikimedia.org/r/956829

Maintenance_bot removed a project: Patch-For-Review.Sep 12 2023, 1:31 PM
ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.27; 2023-09-19).Sep 12 2023, 2:00 PM
DLynch moved this task from Code Review to QA on the Editing-team (Kanban Board) board.Sep 18 2023, 2:42 PM
DLynch added a project: Editing QA.
VPuffetMichel moved this task from To Triage to Triaged on the VisualEditor board.Sep 21 2023, 3:17 PM
Ryasmeen moved this task from QA to Ready for Sign Off on the Editing-team (Kanban Board) board.Sep 22 2023, 2:51 AM
Ryasmeen edited projects, added Verified; removed Editing QA.
ppelberg closed this task as Resolved.Sep 26 2023, 5:27 PM
gerritbot added a comment.Oct 7 2023, 5:47 PM

Change 964106 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: DLynch):

[mediawiki/extensions/VisualEditor@master] Edit check: stop an error on save if no reference-needing content added

https://gerrit.wikimedia.org/r/964106

gerritbot added a project: Patch-For-Review.Oct 7 2023, 5:47 PM
gerritbot added a comment.Oct 7 2023, 6:01 PM

Change 964106 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Edit check: stop an error on save if no reference-needing content added

https://gerrit.wikimedia.org/r/964106

Maintenance_bot removed a project: Patch-For-Review.Oct 7 2023, 6:10 PM
ReleaseTaggerBot edited projects, added MW-1.41-notes (1.41.0-wmf.30; 2023-10-10); removed MW-1.41-notes (1.41.0-wmf.27; 2023-09-19).Oct 7 2023, 7:00 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL