Page MenuHomePhabricator

GitLab email confirmation mail ends up in spam folder
Closed, ResolvedPublic

Description

GitLab's email confirmation mail ends up in the spam folder when using a WMF Gmail account. Full email headers can be seen at P52515 (restricted to WMF-NDA), main thing that jumps out to me that there is no DKIM signature.

Event Timeline

Jelto subscribed.

A bit more context: We had this issue some time ago and added SPF records in T328642.

@jhathaway do we have a standard process for adding DKIM? Do you have any other thoughts on this?

LSobanski moved this task from Incoming to Backlog on the collaboration-services board.

@jhathaway do we have a standard process for adding DKIM? Do you have any other thoughts on this?

Yes that should be doable, is there a way I can test this email flow?

I tried resending confirmation instructions via https://gitlab.wikimedia.org/users/confirmation/new but didn't receive anything (yes, I checked spam as well), this likely doesn't work for already verified accounts.

I tried resending confirmation instructions via https://gitlab.wikimedia.org/users/confirmation/new but didn't receive anything

Did the same thing, also received nothing.

Then I logged out and tried to behave like a new user.

Nowadays I am sent to https://idm.wikimedia.org/ and I created a new developer account using a "new" email address with the "username+foo@" syntax that Google lets you use as an alias for the same inbox.

I ended up at https://idm.wikimedia.org/signup/thanks/ and got a "Wikimedia Developer Account activation" email in my inbox.

This was NOT marked as spam.

So if this ticket was created before gitlab was using Bitu / idm.wikimedia.org it seems like it's just not valid anymore.

Independently I should add I was able to verify my new test account but then get "Your account is not recognized and cannot login at this time. " when trying to use it. But that's another story which is maybe T270233.

The subject of the mail this ticket is about originally is "Confirmation instructions". When searching my own inbox for that I can confirm it's what you get when the mail comes from gitlab itself. In my case from upstream gitlab (gitlab@mg.gitlab.com).

But if now this is all idm.wikimedia.org it would simply not apply anymore.

I confirmed @Dzahn's check of the current workflow. I do not think this is an issue any more, although I'm fuzzy on what has changed since the original report.

Looking at the most recent comments, this should be OK to resolve, please reopen if you think otherwise.