Regression: Nearby appears on unsupported browsers and some links are incorrectly aligned in Minerva sidebar
Open, LowPublic1 Estimated Story PointsBUG REPORT
Actions

Assigned To

None

Authored By

	Pcoombe
	Mon, Sep 18, 5:35 PM

Description

Regression caused by Codex migration.

Issue 1: alignment

Steps to replicate the issue (include links if applicable):

Visit any page on a Wikimedia mobile site e.g. https://en.m.wikipedia.org
Open the sidebar using the hamburger menu in the top left

What happens?:
"Nearby" and "Settings" text are not aligned the same as the other items

Screenshot 2023-09-18 at 18.27.04.png (798×658 px, 76 KB)

What should have happened instead?:
All items should be nicely aligned

Other information (browser name/version, screenshots, etc.):

Appears to be caused by the CSS rule

.client-js .jsonly {
    display: inherit;
}

which is overriding display: flex.

Issue 2: visibility

Steps to replicate the issue (include links if applicable):

Disable JS
Visit any page on a Wikimedia mobile site e.g. https://en.m.wikipedia.org
Open the sidebar using the hamburger menu in the top left

What happens?:
"Nearby" is visible.

What should have happened instead?:
Nearby should not be visible.

Event Timeline

Pcoombe created this task.Mon, Sep 18, 5:35 PM

Restricted Application added subscribers: Masumrezarock100, Aklapper. · View Herald TranscriptMon, Sep 18, 5:35 PM

Jdlrobson renamed this task from Some links are incorrectly aligned in Minerva sidebar to Regression: Nearby appears on unsupported browsers and some links are incorrectly aligned in Minerva sidebar.Mon, Sep 18, 10:43 PM

Jdlrobson added projects: Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 6.5 (Quarter wrap up)), Regression.

Jdlrobson updated the task description. (Show Details)

Jdlrobson added a subscriber: ovasileva.

ovasileva triaged this task as Medium priority.Thu, Sep 21, 5:06 PM

The alignment also seems to be caused by whitespace next to the nearby and settings text. The new styles dont rely on whitespace to handle spacing.

The display: inherit impacts this more, but still seems good to get rid of the whitespace

ovasileva set the point value for this task to 1.Thu, Sep 21, 5:08 PM

.jsonly { display: none; } is not applying (overriden, specificity)
.client-js .jsonly { display: inherit; } should be changed to flex.

Jdlrobson lowered the priority of this task from Medium to Low.Mon, Sep 25, 5:28 PM

Jdlrobson edited projects, added Web-Team-Backlog (Web Team FY2023-24 Q2 Sprint 1); removed Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 6.5 (Quarter wrap up)).Mon, Sep 25, 5:39 PM

	F37730653: Screenshot 2023-09-18 at 18.27.04.png
	Mon, Sep 18, 5:35 PM

Regression: Nearby appears on unsupported browsers and some links are incorrectly aligned in Minerva sidebarOpen, LowPublic1 Estimated Story PointsBUG REPORTActions

Description

Issue 1: alignment

Issue 2: visibility

Event Timeline

Regression: Nearby appears on unsupported browsers and some links are incorrectly aligned in Minerva sidebar
Open, LowPublic1 Estimated Story PointsBUG REPORT
Actions