Regression: Nearby appears on unsupported browsers and some links are incorrectly aligned in Minerva sidebar
Closed, ResolvedPublic1 Estimated Story PointsBUG REPORT
Actions

Assigned To

Authored By

	Pcoombe
	Sep 18 2023, 5:35 PM

Description

Regression caused by Codex migration.

Issue 1: alignment

Steps to replicate the issue (include links if applicable):

Make sure you are logged out
Visit any page on a Wikimedia mobile site e.g. https://en.m.wikipedia.org
Open the sidebar using the hamburger menu in the top left

What happens?:
"Nearby" and "Settings" is not aligned the same as the other items

Screenshot 2023-09-18 at 18.27.04.png (798×658 px, 76 KB)

What should have happened instead?:
All items should be nicely aligned

Other information (browser name/version, screenshots, etc.):

Appears to be caused by the CSS rule

.client-js .jsonly {
    display: inherit;
}

which is overriding display: flex.

Issue 2: visibility

Steps to replicate the issue (include links if applicable):

Disable JS
Visit any page on a Wikimedia mobile site e.g. https://en.m.wikipedia.org
Open the sidebar using the hamburger menu in the top left

What happens?:
"Nearby" is visible.

What should have happened instead?:
Nearby should not be visible.

QA Results - Beta

AC	Status	Details
1	✅	T346670#9422723
2	✅	T346670#9422723

QA Results - Beta

AC	Status	Details
1	✅	T346670#9448531
2	✅	T346670#9448531

Details

Other Assignee: SToyofuku-WMF

	Subject	Repo	Branch	Lines +/-
	Fix alignment for nearby and settings items in menu, and correctly hide when JS is disabled	mediawiki/skins/MinervaNeue	master	+7 -9

Customize query in gerrit

Related Objects

Mentioned In: T353675: Verify 1.42.0-wmf.10 deployment
T346162: Icons rendered via JavaScript in Minerva should use Codex mixin

Event Timeline

Pcoombe created this task.Sep 18 2023, 5:35 PM

Restricted Application added subscribers: Masumrezarock100, Aklapper. · View Herald TranscriptSep 18 2023, 5:35 PM

Jdlrobson renamed this task from Some links are incorrectly aligned in Minerva sidebar to Regression: Nearby appears on unsupported browsers and some links are incorrectly aligned in Minerva sidebar.Sep 18 2023, 10:43 PM

Jdlrobson added projects: Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 6.5 (Quarter wrap up)), Regression.

Jdlrobson updated the task description. (Show Details)

Jdlrobson added a subscriber: ovasileva.

ovasileva triaged this task as Medium priority.Sep 21 2023, 5:06 PM

The alignment also seems to be caused by whitespace next to the nearby and settings text. The new styles dont rely on whitespace to handle spacing.

The display: inherit impacts this more, but still seems good to get rid of the whitespace

ovasileva set the point value for this task to 1.Sep 21 2023, 5:08 PM

.jsonly { display: none; } is not applying (overriden, specificity)
.client-js .jsonly { display: inherit; } should be changed to flex.

Jdlrobson lowered the priority of this task from Medium to Low.Sep 25 2023, 5:28 PM

Jdlrobson edited projects, added Web-Team-Backlog (Web Team FY2023-24 Q2 Sprint 1); removed Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 6.5 (Quarter wrap up)).Sep 25 2023, 5:39 PM

ovasileva edited projects, added Web-Team-Backlog (Web Team FY2023-24 Q2 Sprint 2); removed Web-Team-Backlog (Web Team FY2023-24 Q2 Sprint 1).Oct 9 2023, 12:13 PM

ovasileva edited projects, added Web-Team-Backlog; removed Web-Team-Backlog (Web Team FY2023-24 Q2 Sprint 2).Oct 23 2023, 9:26 AM

ovasileva moved this task from Incoming to Current Fiscal Year on the Web-Team-Backlog board.

Jdlrobson raised the priority of this task from Low to Medium.Dec 12 2023, 7:27 AM

Jdlrobson edited projects, added Web-Team-Backlog (FY2023-24 Q3 Sprint 1), patch-welcome, good first task; removed Web-Team-Backlog.

Jdlrobson merged a task: T353162: "Nearby" has extra spacing between icon and text in mobile menu.

Jdlrobson added a subscriber: Esanders.

SToyofuku-WMF subscribed.Dec 12 2023, 5:02 PM

Jdlrobson assigned this task to SToyofuku-WMF.Dec 12 2023, 5:19 PM

Jdlrobson updated the task description. (Show Details)Dec 12 2023, 6:49 PM

Jdlrobson updated the task description. (Show Details)

Change 983255 had a related patch set uploaded (by Stoyofuku-wmf; author: Stoyofuku-wmf):

[mediawiki/skins/MinervaNeue@master] Fix alignment for nearby and settings items in menu, and correctly hide when JS is disabled

https://gerrit.wikimedia.org/r/983255

gerritbot added a project: Patch-For-Review.Dec 14 2023, 7:24 PM

Over to Edward for QA.

Jdlrobson updated Other Assignee, added: SToyofuku-WMF.Dec 14 2023, 9:09 PM

Change 983255 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] Fix alignment for nearby and settings items in menu, and correctly hide when JS is disabled

https://gerrit.wikimedia.org/r/983255

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.10; 2023-12-19).Dec 14 2023, 11:00 PM

Maintenance_bot removed a project: Patch-For-Review.Dec 14 2023, 11:10 PM

Jdlrobson mentioned this in T346162: Icons rendered via JavaScript in Minerva should use Codex mixin.Dec 19 2023, 5:40 AM

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Sonoma
Browser: Chrome
Device: MBA
Emulated Device:NA

Test Artifact(s):

QA Steps

Issue 1: alignment
Make sure you are logged out
Visit any page on a Wikimedia mobile site e.g. https://en.m.wikipedia.org
Open the sidebar using the hamburger menu in the top left
✅ AC1: All items should be nicely aligned

Issue 2: visibility
Disable JS
Visit any page on a Wikimedia mobile site e.g. https://en.m.wikipedia.org
Open the sidebar using the hamburger menu in the top left
✅ AC2: Nearby should not be visible.

Edtadros updated the task description. (Show Details)Dec 22 2023, 12:11 AM

Jdlrobson closed this task as Resolved.Jan 2 2024, 4:59 PM

Jdlrobson claimed this task.

Jdlrobson mentioned this in T353675: Verify 1.42.0-wmf.10 deployment.Jan 4 2024, 9:52 PM

Test Result - Prod

Status: ✅ PASS
Environment: enwiki
OS: macOS Sonoma
Browser: Chrome
Device: MBA
Emulated Device:NA

Test Artifact(s):

QA Steps

Edtadros updated the task description. (Show Details)Jan 9 2024, 11:50 PM

	F37730653: Screenshot 2023-09-18 at 18.27.04.png
	Sep 18 2023, 5:35 PM

	F41662128: screenshot 393.png
	Jan 9 2024, 11:49 PM

	F41662126: screenshot 392.png
	Jan 9 2024, 11:49 PM

	F41617695: screenshot 383.png
	Dec 22 2023, 12:10 AM

	F41617693: screenshot 382.png
	Dec 22 2023, 12:10 AM

Regression: Nearby appears on unsupported browsers and some links are incorrectly aligned in Minerva sidebarClosed, ResolvedPublic1 Estimated Story PointsBUG REPORTActions

Description

Issue 1: alignment

Issue 2: visibility

QA Results - Beta

QA Results - Beta

Details

Related Objects

Event Timeline

Test Result - Beta

QA Steps

Test Result - Prod

QA Steps

Regression: Nearby appears on unsupported browsers and some links are incorrectly aligned in Minerva sidebar
Closed, ResolvedPublic1 Estimated Story PointsBUG REPORT
Actions