Page MenuHomePhabricator

CI test error: already defined testUnderbrace function
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

17:46:01 Parse error: ./tests/phpunit/unit/TexVC/MMLRenderTest.php:36
17:46:01     34| 	}
17:46:01     35| 
17:46:01   > 36| 	public function testUnderbrace() {
17:46:01     37| 		$input = "\underbrace{ a+b+\cdots+z }_{26}";
17:46:01     38| 		$mathMLtexVC = $this->generateMML( $input );Cannot redeclare MediaWiki\Extension\Math\Tests\TexVC\MMLRenderTest::testUnderbrace() in ./tests/phpunit/unit/TexVC/MMLRenderTest.php on line 36

What happens?:

CI checks do not pass

What should have happened instead?:

CI checks should pass without error

Event Timeline

taavi added a subscriber: releng-list.
taavi removed a subscriber: releng-list.

@taavi How can I flag this task or add a suitable assignee, it seems to be an issue with CI ?

hashar subscribed.

@taavi How can I flag this task or add a suitable assignee, it seems to be an issue with CI ?

The task has ci-test-error which is how we tag errors encountered in CI. Something in the proposed change https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Math/+/959303 triggers the test error.

@hashar no, any change, even empty ones, triggers the problem. Something must have changed in the past few days.

Change 961071 had a related patch set uploaded (by Physikerwelt; author: Physikerwelt):

[mediawiki/extensions/Math@master] Do not merge, CI test

https://gerrit.wikimedia.org/r/961071

This is fixed by renaming testUnderbrace function to testUnder.

Physikerwelt assigned this task to Stegmujo.

Change 960000 had a related patch set uploaded (by Stegmujo; author: Stegmujo):

[mediawiki/extensions/Math@master] Fix MMLGenerationParserTest creating HTML file

https://gerrit.wikimedia.org/r/960000

Change 960000 merged by jenkins-bot:

[mediawiki/extensions/Math@master] Fix MMLGenerationParserTest creating HTML file

https://gerrit.wikimedia.org/r/960000

Change 961071 abandoned by Physikerwelt:

[mediawiki/extensions/Math@master] Do not merge, CI test

Reason:

https://gerrit.wikimedia.org/r/961071