Page MenuHomePhabricator

Reminder Final Checks in Implementation
Closed, ResolvedPublic

Assigned To
Authored By
Stegmujo
Aug 23 2022, 9:56 AM
Referenced Files
F37830860: Screenshot 2023-09-28 at 15-35-36 Screenshot.png
Sep 28 2023, 2:44 PM
F37816682: Screenshot 2023-09-27 at 13-42-59 Screenshot.png
Sep 27 2023, 11:47 AM
F37766014: screenshot_not_operatorname.png
Sep 25 2023, 3:11 PM
F37746218: image.png
Sep 21 2023, 11:51 AM
F37746109: screenshot_underbrace.png
Sep 21 2023, 11:23 AM
F37143549: xml_escapingissue.jpg
Jul 19 2023, 11:09 AM
F37143551: integral_issue.jpg
Jul 19 2023, 11:09 AM

Description

Findings in TexVC php

  • public test methods which are only used for testing should be private, example Texnode tests
  • Add Texnode arg type doc which goes through phan
  • use 4 backslashes instead of 3
  • Use test provider for looped tests which go through array, example can be found in math extension.
  • reference MathML of TexUtilTest: Configure LaTeXML to not generate ids and to not generate CMML for the baseline.
  • update inputPreparation method or the tables so that less calls for inputPreparation are necessary
  • fix issue with DQ::getArg not defined in multiple cases discovered in wmflabs check

(some bigger issues have been moved to linked subtasks )

*done*

  • fix escaping not correct for "<" or ">" in LaTeX formula in rendered MathML
  • Integral is often displayed too big on wikipages with texvc mathml
    integral_issue.jpg (464×1 px, 66 KB)
  • issue in xml escaping &gt etc (see
    xml_escapingissue.jpg (162×504 px, 7 KB)
    , T346731)
  • "\underbrace{ a+b+\cdots+z }_{26}": underbraces appear right sided (see
    screenshot_underbrace.png (46×733 px, 3 KB)
    )
  • fix "\sum_{k=1}^N k^2": (!) k=1 should appear under sum sign
    image.png (47×512 px, 2 KB)
  • fix negation (not) for operatorname ("R" in depiction)
    screenshot_not_operatorname.png (71×239 px, 4 KB)
  • fix escaping for some spacing
    Screenshot 2023-09-27 at 13-46-00 Help MathTestNative - Wikipedia the free encyclopedia.png (22×443 px, 5 KB)
  • fix bigcup and bigcap scripts
    Screenshot 2023-09-27 at 13-42-59 Screenshot.png (117×652 px, 6 KB)
  • fix alignments
    Screenshot 2023-09-28 at 15-35-36 Screenshot.png (27×832 px, 4 KB)

Findings in texvcjs:

    • UQ: this.down = up; -> use consistent naming for parameters
    • Dollar (test): Remove non-used module references.
    • Dollar (test): Should extract identifiers has sophisticated setup, although extract identifiers currently just returns empty array. Is this intended ?
    • Big (test): Should extract identifiers has sophisticated setup, although extract identifiers currently just returns empty array. Is this intended ?
    • Curly(test): Should not create a curly with more than one argument, seems to be initialized with wrong argument types, TexNode and Node redundant declarations
  • Infix(test): remove TexNode redundant declaration
  • api(test): remove redundant testcase "\\reals", remove output field from "\\ce{[Zn(OH)4]^2-}" testcase since it is not checked.

Related Objects

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes

Change 826816 had a related patch set uploaded (by Physikerwelt; author: Physikerwelt):

[mediawiki/extensions/Math@master] Change type hints for TexNode

https://gerrit.wikimedia.org/r/826816

Change 826816 merged by jenkins-bot:

[mediawiki/extensions/Math@master] Change type hints for TexNode

https://gerrit.wikimedia.org/r/826816

Change 903563 had a related patch set uploaded (by Stegmujo; author: Stegmujo):

[mediawiki/extensions/Math@master] Fix issue in EnWikiFormulaeTest

https://gerrit.wikimedia.org/r/903563

Change 905742 had a related patch set uploaded (by Stegmujo; author: Stegmujo):

[mediawiki/extensions/Math@master] Fix style tag imbalance

https://gerrit.wikimedia.org/r/905742

Change 905743 had a related patch set uploaded (by Stegmujo; author: Stegmujo):

[mediawiki/extensions/Math@master] Fix for carriage return

https://gerrit.wikimedia.org/r/905743

Change 905744 had a related patch set uploaded (by Stegmujo; author: Stegmujo):

[mediawiki/extensions/Math@master] Fix for genFrac parsing

https://gerrit.wikimedia.org/r/905744

Change 905970 had a related patch set uploaded (by Stegmujo; author: Stegmujo):

[mediawiki/extensions/Math@master] Fix issues with DQ

https://gerrit.wikimedia.org/r/905970

Change 905742 merged by jenkins-bot:

[mediawiki/extensions/Math@master] Fix style tag imbalance

https://gerrit.wikimedia.org/r/905742

Change 905743 merged by jenkins-bot:

[mediawiki/extensions/Math@master] Fix for carriage return

https://gerrit.wikimedia.org/r/905743

Change 905744 merged by jenkins-bot:

[mediawiki/extensions/Math@master] Fix for attributes in named Operator

https://gerrit.wikimedia.org/r/905744

Change 906118 had a related patch set uploaded (by Stegmujo; author: Stegmujo):

[mediawiki/extensions/Math@master] Fix rendering of over

https://gerrit.wikimedia.org/r/906118

Change 903563 abandoned by Stegmujo:

[mediawiki/extensions/Math@master] Fix several issues appearing in EnWikiFormulaTest

Reason:

done, uploaded with severeal other granular patchsets

https://gerrit.wikimedia.org/r/903563

Change 905970 merged by jenkins-bot:

[mediawiki/extensions/Math@master] Fix issues with DQ

https://gerrit.wikimedia.org/r/905970

Change 906118 abandoned by Stegmujo:

[mediawiki/extensions/Math@master] Fix rendering of over

Reason:

not used

https://gerrit.wikimedia.org/r/906118

Change 959302 had a related patch set uploaded (by Stegmujo; author: Stegmujo):

[mediawiki/extensions/Math@master] Fix underbrace

https://gerrit.wikimedia.org/r/959302

Stegmujo updated the task description. (Show Details)

Change 959303 had a related patch set uploaded (by Stegmujo; author: Stegmujo):

[mediawiki/extensions/Math@master] Fix k=1 should appear under sum

https://gerrit.wikimedia.org/r/959303

Change 959305 had a related patch set uploaded (by Stegmujo; author: Stegmujo):

[mediawiki/extensions/Math@master] Fix product

https://gerrit.wikimedia.org/r/959305

Change 959302 merged by jenkins-bot:

[mediawiki/extensions/Math@master] Fix underbrace

https://gerrit.wikimedia.org/r/959302

Change 959996 had a related patch set uploaded (by Stegmujo; author: Stegmujo):

[mediawiki/extensions/Math@master] Fix negation

https://gerrit.wikimedia.org/r/959996

Stegmujo updated the task description. (Show Details)

Change 959303 merged by jenkins-bot:

[mediawiki/extensions/Math@master] Fix k=1 should appear under sum in displaystyle

https://gerrit.wikimedia.org/r/959303

Change 959996 merged by jenkins-bot:

[mediawiki/extensions/Math@master] Fix negation (not) for operatorname

https://gerrit.wikimedia.org/r/959996

Change 961209 had a related patch set uploaded (by Stegmujo; author: Stegmujo):

[mediawiki/extensions/Math@master] Move error to merror tags

https://gerrit.wikimedia.org/r/961209

Change 959305 merged by jenkins-bot:

[mediawiki/extensions/Math@master] Fix oint size

https://gerrit.wikimedia.org/r/959305

Change 961209 merged by jenkins-bot:

[mediawiki/extensions/Math@master] Move error to merror tags

https://gerrit.wikimedia.org/r/961209

Change 961212 had a related patch set uploaded (by Stegmujo; author: Stegmujo):

[mediawiki/extensions/Math@master] Fix bigcap scripts not placed correctly

https://gerrit.wikimedia.org/r/961212

Change 961213 had a related patch set uploaded (by Stegmujo; author: Stegmujo):

[mediawiki/extensions/Math@master] Fix escape spacing

https://gerrit.wikimedia.org/r/961213

Change 961212 merged by jenkins-bot:

[mediawiki/extensions/Math@master] Fix bigcap and bigcup scripts not placed correctly

https://gerrit.wikimedia.org/r/961212

Change 961711 had a related patch set uploaded (by Stegmujo; author: Stegmujo):

[mediawiki/extensions/Math@master] Fix alignments

https://gerrit.wikimedia.org/r/961711

Change 961712 had a related patch set uploaded (by Stegmujo; author: Stegmujo):

[mediawiki/extensions/Math@master] Correct the size of rendering some symbols

https://gerrit.wikimedia.org/r/961712

Change 961711 abandoned by Stegmujo:

[mediawiki/extensions/Math@master] Fix alignments

Reason:

changeset split https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Math/+/961821

https://gerrit.wikimedia.org/r/961711

Change 961821 had a related patch set uploaded (by Stegmujo; author: Stegmujo):

[mediawiki/extensions/Math@master] Fix alignments

https://gerrit.wikimedia.org/r/961821

Change 961712 abandoned by Stegmujo:

[mediawiki/extensions/Math@master] Correct the size of rendering some symbols

Reason:

doesnt seem the case that this is an issue after recheck

https://gerrit.wikimedia.org/r/961712

Change 961213 merged by jenkins-bot:

[mediawiki/extensions/Math@master] Fix escape spacing

https://gerrit.wikimedia.org/r/961213

Change 961821 merged by jenkins-bot:

[mediawiki/extensions/Math@master] Fix alignments

https://gerrit.wikimedia.org/r/961821

Change 961924 had a related patch set uploaded (by Stegmujo; author: Stegmujo):

[mediawiki/extensions/Math@master] Fix tilde spacing

https://gerrit.wikimedia.org/r/961924

Change 961924 merged by jenkins-bot:

[mediawiki/extensions/Math@master] Fix tilde spacing

https://gerrit.wikimedia.org/r/961924