Page MenuHomePhabricator

[spike] Places: logic and algorithms for Searching
Closed, DuplicatePublicSpike

Description

The big thing that we'll be introducing into our updated version of Places is Search, but how exactly should searching work?

  • Ask the iOS team about how their search in Places works.
  • If I'm looking at a map of Boston, and I search for the term "paris", what kind of results should be shown? Should it be places in proximity to Boston that have the term "paris" in them, or should the results include Paris, France? Or both? And in which order?

Should searching be internationalized somehow?

  • If I'm looking at a map of Boston, and I search for a location in another language, can we somehow produce a meaningful result?

Event Timeline

Frostly changed the subtype of this task from "Task" to "Spike".Oct 2 2023, 9:24 PM
Sharvaniharan renamed this task from [spike] Places: logic and algorithms for Searching to [spike] Nearby: logic and algorithms for Searching.Nov 20 2023, 6:55 PM

Plan for search on Nearby:

Use the existent global article search as is. When it is activated from the Nearby screen, filter the search results for pages containing geo location.
When user chooses a search result we bring them back to Nearby with that location set as the current camera position, and display articles around that, as is the default behavior on Nearby.

The flow from Nearby to search and back:

Every time the user clicks on a marker, we populate the article name in the Nearby screen search bar.
If user clicks on the search bar, we take the search term to the search screen, and activate full term search with it.
filter results for pages with geolocation.
User clicks on a search result, bring them back with the location to Nearby screen as explained above.
If the user exits, it just goes back to the previous state of having the marker name in search bar, and the marker in activated state

@scblr @JTannerWMF
Moving this straight to Code review as this is just an engineering spike. Pinging you here in case you have input.

Hi @Sharvaniharan

Would you be able to also address the logic of showing multilingual results? Will they have the same behavior as the one we have in the article search?

Sharvaniharan renamed this task from [spike] Nearby: logic and algorithms for Searching to [spike] Places: logic and algorithms for Searching.Dec 7 2023, 2:30 AM

@cooltey

Sorry missed seeing this.
Leveraging the current multilingual behavior, the search experience will take the user from the Places screen to the app search with or without a starting query string.
The multilingual search then takes place as usual but the search results are filtered for ones with a location attached to them. When the user picks a result, we bring them back to the Places screen with a location, language and page title. Based on this we will now update the Places screen to only show results in the new language. Moving this to Merged and waiting since the feature is already built. Please feel free to add more comments here.