I think changing the sender address to something like "no-reply.wikipedialibrary@wmcloud.org" would make Google's SPF check happy. Alternately an address matching some subdomain delegated to the twl Cloud VPS project could be used and an appropriate SPF record added for that subdomain via Horizon.

T47828: Implement mail aliases for Cloud-VPS projects (<novaproject>@wmcloud.org) is a semi-related feature request for Cloud VPS projects generally. If a <addr>@<project>.wmcloud.org variant of that were to be implemented it would be reasonable to also assume that SPF records would be made for each <project>.wmcloud.org subdomain. A lack of delegation of SPF record lookups to higher-level domains is a "feature" of the SPF protocol.

Thank you for looking into this! I think making the sender address change is the way to go: the less special config we need, the better. @Samwalton9-WMF do we need to make an announcement ahead of making such a change?

In T347512#9373668, @bd808 wrote:

I think changing the sender address to something like "no-reply.wikipedialibrary@wmcloud.org" would make Google's SPF check happy. Alternately an address matching some subdomain delegated to the twl Cloud VPS project could be used and an appropriate SPF record added for that subdomain via Horizon.

A valid sender address would be a better idea so that if there are other issues in the future the would get reported to mailbox somewhere. The logs on mx-out03 are also full of retry failure messages for attempts to tell noreply@wikipedialibrary.wmflabs.org that there were problems delivering messages. Unfortunately I think using a valid email would actually require the twl project to run its own email service instead of using mx-out03 as we do not currently have T47828: Implement mail aliases for Cloud-VPS projects (<novaproject>@wmcloud.org) or similar mail deliver for Cloud VPS projects.

That seems like something we're likely to do a poor job of maintaining. How are other vps projects handling outbound mail?

I should have looked more closely at the links you provided. I didn't realize that we could manage our own DNS zone. I've setup dmarc/dkim/spf for small orgs before, though I'm quite rusty. Since we're not using twl.wmflabs.org for mail right now, I should be able to iterate as needed without making things worse.

In T347512#9373725, @jsn.sherman wrote:

That seems like something we're likely to do a poor job of maintaining. How are other vps projects handling outbound mail?

Good question. It is all ad hoc today. Toolforge has it's own domain, mail exchanges, and SPF record that are managed as part of the project. I would actually guess that the vast majority of Cloud VPS projects do not send outbound mail at all other than Puppet failure cronspam.

In T347512#9373709, @jsn.sherman wrote:

Thank you for looking into this! I think making the sender address change is the way to go: the less special config we need, the better. @Samwalton9-WMF do we need to make an announcement ahead of making such a change?

I can't think of any reason we'd need to - it should be fine to just make the switch.

I'll need to generate a dkim key to follow the suggested fix, but for whatever reason I'm not currently able shell into any of our horizon instances; the web interface is also throwing errors, so after much fussing, I'll set this aside for now.

Apologies, we had a Cloud VPS network outage today. Things should be working again now!

In T347512#9375580, @fnegri wrote:

Apologies, we had a Cloud VPS network outage today. Things should be working again now!

The web interfaces for our cloud vps hosts are accessible, but I still can't shell in:

ssh -v prod.wikilink.eqiad1.wikimedia.cloud
OpenSSH_8.9p1 Ubuntu-3ubuntu0.4, OpenSSL 3.0.2 15 Mar 2022
[...]
debug1: Connecting to prod.wikilink.eqiad1.wikimedia.cloud [172.16.5.37] port 22.
debug1: connect to address 172.16.5.37 port 22: Connection timed out
ssh: connect to host prod.wikilink.eqiad1.wikimedia.cloud port 22: Connection timed out

in every case, the ip address shown in the ssh debug matches what is shown in horizon.

I'm able to reach the bastion with no problem. I tried restarting one of the hosts, but there was no change. I'm happy to move this over to T352539: 2023-12-01 Cloud VPS network outage if needed.

I can SSH to that VM (prod.wikilink.eqiad1.wikimedia.cloud), but there are some ongoing issues with Cloud VPS, please leave a comment in T352539: 2023-12-01 Cloud VPS network outage if this keeps on failing.

It just started working for me after quite a bit of fiddling and retrying.

hotfix in the pipeline:
https://github.com/WikipediaLibrary/TWLight/commit/66600192ae2be2a6b9c6d2545727e272b5162c77

That change is now live; we'll need to see if delivery improves.

In T347512#9376677, @jsn.sherman wrote:

That change is now live; we'll need to see if delivery improves.

I tried sending an email from the Contact Us page but it never arrived, at either wikipedialibrary@ or my personal email. Djmail claims the email was sent.

Rolling back to the old address.

https://github.com/WikipediaLibrary/TWLight/commit/ca7c85b8f5496543207312c1c084beaf1f69503f

@Samwalton9 can you send yourself another contact email to see if we're back to the state we were before?

In T347512#9379508, @jsn.sherman wrote:

@Samwalton9 can you send yourself another contact email to see if we're back to the state we were before?

That arrived to the @wikimedia.org address as expected, though not to my personal email.

In T347512#9379530, @Samwalton9-WMF wrote:

In T347512#9379508, @jsn.sherman wrote:

@Samwalton9 can you send yourself another contact email to see if we're back to the state we were before?

That arrived to the @wikimedia.org address as expected, though not to my personal email.

Is this a different outcome than when I sent you a test message last week?

In T347512#9379537, @jsn.sherman wrote:

In T347512#9379530, @Samwalton9-WMF wrote:

In T347512#9379508, @jsn.sherman wrote:

@Samwalton9 can you send yourself another contact email to see if we're back to the state we were before?

That arrived to the @wikimedia.org address as expected, though not to my personal email.

Is this a different outcome than when I sent you a test message last week?

Same result - the wikipedialibrary@wikimedia.org address receives it, but the individual does not.

If I understand @bd808's suggestions correctly, our current option for correcting email delivery would involve:

• requesting and obtaining a floating ip for the project
• attaching that to one of our servers
• setting up an outbound mail on that server
• adding the appropriate dns records to allow those messages to pass dmarc checks

Do I have that right @bd808?

In T347512#9379916, @jsn.sherman wrote:

Do I have that right @bd808?

That seems like the basic steps to move outbound SMTP 100% into the control of your project, yes. If it is only outbound, I'm not sure actually that you would need a floating IP instead of letting the traffic be seen by the Internet as coming from the Cloud VPS NAT gateway.

In T347512#9378663, @Samwalton9-WMF wrote:

In T347512#9376677, @jsn.sherman wrote:

That change is now live; we'll need to see if delivery improves.

I tried sending an email from the Contact Us page but it never arrived, at either wikipedialibrary@ or my personal email. Djmail claims the email was sent.

This was possibly one of the logged events similar to:

mainlog.3.gz:2023-12-01 23:40:24 1r9D7P-0007fL-J7 ** wikipedialibrary@wikimedia.org R=dnslookup_wmcloud_org_wmcs T=remote_smtp_wmcloud_org_wmcs H=mx2001.wikimedia.org [208.80.153.45] I=[172.16.6.237] X=TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256 CV=yes DN="CN=mx1001.wikimedia.org": SMTP error from remote mail server after RCPT TO:<wikipedialibrary@wikimedia.org>:
550-Verification failed for <no-reply.wikipedialibrary@wmcloud.org>
550-Address no-reply.wikipedialibrary@wmcloud.org does not exist
550 Sender verify failed

That is a MX for wikimedia.org rejecting an inbound message to wikipedialibrary@wikimedia.org because the envelope From of no-reply.wikipedialibrary@wmcloud.org was not acknowledged as a deliverable address by ... some host. We do not publish any MX records for the wmcloud.org domain, so I'm not completely sure what host mx{1001,2001} would have connected to when attempting to verify the envelope From address. I guess it would have ended up finding 185.15.56.49, which is the external interface of the wmcloud.org & wmflabs.org HTTP reverse proxy service. That really should be the same host that found when attempting a deliverability check for "noreply@wikipedialibrary.wmflabs.org" as well. I feel like I'm getting to a "wait, how does any of this work" moment.

We talked about it in a planning meeting today, and we're going to try running our own deliveries for now while working out a plan to move most of our notifications away from email, as it's always been a complicated beast.

In T347512#9379948, @bd808 wrote:

In T347512#9379916, @jsn.sherman wrote:

Do I have that right @bd808?

That seems like the basic steps to move outbound SMTP 100% into the control of your project, yes. If it is only outbound, I'm not sure actually that you would need a floating IP instead of letting the traffic be seen by the Internet as coming from the Cloud VPS NAT gateway.

@bd808 I don't actually be able to create an spf record with anything useful in it; I can create:

twl.wmflabs.org.	60	IN	TXT	"v=spf1"

but if I try to actually set any ip addresses or set a policy in the record, I get a 400 response back from openstack.

In T347512#9380349, @jsn.sherman wrote:

@bd808 I don't actually be able to create an spf record with anything useful in it; I can create:

twl.wmflabs.org.	60	IN	TXT	"v=spf1"

but if I try to actually set any ip addresses or set a policy in the record, I get a 400 response back from openstack.

Horizon let me change that record to "v=spf1 +all" but then errored when I tried "v=spf1 mx +all". I then tried deleting that recordset and creating another using the "SPF" type, but it failed hard. I guess this needs a separate bug and some investigation of what if anything we can do to appease the strange and mysterious Designate service.

In T347512#9380480, @bd808 wrote:

[...]
I guess this needs a separate bug and some investigation of what if anything we can do to appease the strange and mysterious Designate service.

Created T352713: Horizon: cannot create/update an SPF DNS record

I'm thinking about other possible options: how is wikipedialibrary@wikimedia.org configured: is it a shared mailbox, a group, or something similar? Could we authenticate and send mail from that address or setup a noreply-library wikimedia.org account for this purpose?

Okay, we now have an spf record, but no dkim. We did some manual mail tests via shell on prod, and we found that the updated email sender noreply@twl.wmflabs.org is passing spf and getting delivered to wmf and gmail accounts. Since that's an improvement, I put a
hotfix in the pipeline:
https://github.com/WikipediaLibrary/TWLight/compare/b0ffec8f51835885c5515dda00f587749ad9b373..c445d9a63792041337d8bad583f538486519e855

I generated a dkim key pair, added the private key to our docker swarm secrets and added an dns record for the public key.
PR to enable signing here:
https://github.com/WikipediaLibrary/TWLight/pull/1231

Moving back to in progress: I decided I can make this more testable by implementing the console dkim email provider with "public secret" dev key. I also setup a dkim keypair and dns entry for staging. I've added the config for staging into the pr, though I've left the default mail provider as console. I'll shell in and make some local changes to trigger an email to myself via the django app. It won't be a perfect test, but it's as close as we'll get.

This has been really useful; I've fixed a number of bugs in my pr and also discovered that I needed to add mx records as well.

I had do fiddle to get the right key formats :

ssh-keygen -t rsa -b 1024 -m PEM -P "" -f dkim
ssh-keygen -f dkim.pub -m PKCS8 -e > dkim.pub.pkcs8

This gives us the right format private key (dkim) for our app to use and the right format public key (dkim.pub.pkcs8) for the dns records

Okay, I was able to successfully send from staging. The DNS records have been made and the docker secret for the signing key has been added.
https://github.com/WikipediaLibrary/TWLight/pull/1231 is ready for review.

Here's the dns records we ended up with for the twl.wmflabs.org zone:

twl.wmflabs.org.			60	IN	TXT	"v=spf1 a:mx-out03.wmcloud.org a:nat.cloudgw.eqiad1.wikimediacloud.org ip4:185.15.56.0/22 ~all"
twl.wmflabs.org.			60	IN	MX	10 mx1001.wikimedia.org.
twl.wmflabs.org.			60	IN	MX	50 mx2001.wikimedia.org.
staging._domainkey.twl.wmflabs.org. 	60	IN	TXT	"v=DKIM1;t=s;p=MIGfMA0GCSqGSIb3DQEBAQUAA4GNADCBiQKBgQC5PZBVrRGiXETcgPehD2Ih6voYfbMhSZMANXN5o7p6SrT4h5JHnMFu6mR4+bna7RQh2swwuPU4ZyPoRp4XmQ2P1E9DCMZAfHkYzESO259O/O5OOG9d7ypgQYWLfGayB65ZHG8gQPLmuvf0JAFqua5zx9Yc43L92qFFFTsh8rGHpQIDAQAB"
prod._domainkey.twl.wmflabs.org.	60	IN	TXT	"v=DKIM1;t=s;p=MIGfMA0GCSqGSIb3DQEBAQUAA4GNADCBiQKBgQCpcQDsm6Pf/aeXPjl2jg+CQwEvfIzExUe7esNSftIqwKR5mlGa5a94cewcauhD8m3z8/sDAvF8ddQqOyKQytnU2/eWPLF9EbUbW3T84FNYTCLEEjC/OnU4E/lv1ajG4Teqp7mg8dUkxzt10GaJj/w+9a8AINiGH0KRKwgwD4rxvwIDAQAB"

I'll shorten the ttl once we get the change deployed and are confident that every thing is working as intended

It occurs to me that we should test this with personal email accounts too.

In T347512#9385546, @jsn.sherman wrote:

Okay, I was able to successfully send from staging. The DNS records have been made and the docker secret for the signing key has been added.
https://github.com/WikipediaLibrary/TWLight/pull/1231 is ready for review.

How do you feel about this solution in terms of longevity? It seems simpler than some of the solutions we were talking about before, but I don't want to make any assumptions.

In T347512#9386156, @Samwalton9-WMF wrote:

In T347512#9385546, @jsn.sherman wrote:

Okay, I was able to successfully send from staging. The DNS records have been made and the docker secret for the signing key has been added.
https://github.com/WikipediaLibrary/TWLight/pull/1231 is ready for review.

How do you feel about this solution in terms of longevity? It seems simpler than some of the solutions we were talking about before, but I don't want to make any assumptions.

Unfortunately, it still leaves us blind to delivery problems. This was the minimal solution to get mail flowing, but it doesn't do all of the things email should really do to be robust. @bd808 proposed 3 different solutions:

I think changing the sender address to something like "no-reply.wikipedialibrary@wmcloud.org" would make Google's SPF check happy.

didn't work

Alternately an address matching some subdomain delegated to the twl Cloud VPS project could be used and an appropriate SPF record added for that subdomain via Horizon.

This is what I'm doing for now, plus dkim signing

A valid sender address would be a better idea so that if there are other issues in the future the would get reported to mailbox somewhere. The logs on mx-out03 are also full of retry failure messages for attempts to tell noreply@wikipedialibrary.wmflabs.org that there were problems delivering messages. Unfortunately I think using a valid email would actually require the twl project to run its own email service instead of using mx-out03

This would be the full email solution, since it would give us a return path for email. It's what we should do if email is going to stay our main channel of sending notifications. We should change the way we're notifying people instead of doing this.

In T347512#9385565, @jsn.sherman wrote:

It occurs to me that we should test this with personal email accounts too.

I successfully received a signed email sent to a gmail account. note that the contact form option to send the submitter a copy is broken, but that's an app bug, not an email infrastructure problem. I'll find or file a ticket for it.

I do think I can clean up this spf record a bit, which I should do before we're using this in production

twl.wmflabs.org.			60	IN	TXT	"v=spf1 a:mx-out03.wmcloud.org a:nat.cloudgw.eqiad1.wikimediacloud.org ip4:185.15.56.0/22 ~all"

In T347512#9386736, @jsn.sherman wrote:

Unfortunately, it still leaves us blind to delivery problems.

@bd808
I'd like to setup DMARC reports, which would catch some of these. Because of the way we're delegating email sending, we'd need to setup external destination verification. We have an address at lists.wikimedia.org, which is where an edv record would need to go if we wanted to receive reports there. Is that I thing we can request? Because that's on the wikimedia.org domain, I'm not sure who to go to about it. I think it would make a lot of sense for wikimedia.org to have an edv record in place for wmflabs.org. I think it would be something like

*.wmflabs.org._report._dmarc.wikimedia.org.			60	IN	TXT	"v=DMARC1"

or maybe

*.wmflabs.org._report._dmarc.lists.wikimedia.org.		60	IN	TXT	"v=DMARC1"

would do the trick

Okay, I cleaned up our spf record and verified that it's happy:

twl.wmflabs.org.	60	IN	TXT	"v=spf1 a:mx-out03.wmcloud.org a:mx-out04.wmcloud.org ~all"

@Scardenasmolinar the patch is ready for review, dmarc reports can come later

PR has been merged. Sticking in QA for further tests

I was able to verify delivery to a wikimedia address. The headers all look good, though we'll need to wait to hear about other domains from users.

In T347512#9387412, @jsn.sherman wrote:

In T347512#9386736, @jsn.sherman wrote:

Unfortunately, it still leaves us blind to delivery problems.

@bd808
I'd like to setup DMARC reports, which would catch some of these. ... Is that I thing we can request?

I'd say broadly, yes it can be requested. I think you will need help from an SRE and ideally one who understands something about DMARC, SPF, etc. Step 1 is probably splitting out a specific child task about the goal. @herron has helped with some similar things in the past under the T249237: Fix Cloud VPS and Toolforge mail servers to work with the modern internet umbrella, so maybe he can at least suggest someone to bother?

In T347512#9387775, @bd808 wrote:

[...] Step 1 is probably splitting out a specific child task about the goal. [...]

created T352902: enable lists.wikimedia.org or wikimedia.org email addresses to receive dmarc reports for *.wmflabs.org

In T347512#9387231, @jsn.sherman wrote:

[...] note that the contact form option to send the submitter a copy is broken, but that's an app bug, not an email infrastructure problem. I'll find or file a ticket for it. [...]

Actually, this seems to be working just fine now.

In T347512#9388015, @jsn.sherman wrote:

In T347512#9387231, @jsn.sherman wrote:

[...] note that the contact form option to send the submitter a copy is broken, but that's an app bug, not an email infrastructure problem. I'll find or file a ticket for it. [...]

Actually, this seems to be working just fine now.

Rather, it worked for me on staging, when I directly set my email address as the recipient instead of wikipedialibrary@wikimedia.org. It does not seem to be working in production. @Samwalton9-WMF what can you tell me about that wikipedialibrary@wikimedia.org email address: is it an email account, a google group, or something else?

In T347512#9380125, @bd808 wrote:

That is a MX for wikimedia.org rejecting an inbound message to wikipedialibrary@wikimedia.org because the envelope From of no-reply.wikipedialibrary@wmcloud.org was not acknowledged as a deliverable address by ... some host. We do not publish any MX records for the wmcloud.org domain, so I'm not completely sure what host mx{1001,2001} would have connected to when attempting to verify the envelope From address. I guess it would have ended up finding 185.15.56.49, which is the external interface of the wmcloud.org & wmflabs.org HTTP reverse proxy service. That really should be the same host that found when attempting a deliverability check for "noreply@wikipedialibrary.wmflabs.org" as well. I feel like I'm getting to a "wait, how does any of this work" moment.

This turned out to be a misconfiguration on the wikimedia.org mail servers which I've now fixed, so it's now possible to send mail from wmcloud.org to wikimedia.org addresses.

So, I've verifed that wikipedialibrary@wikimedia.org is a google group, and that we basically can't cc users when the group is the recipient.
I could hotfix out the cc option on the form, or I could do a slightly PR. We talked about replacing the form with just a link to our email info, @Samwalton9-WMF what if I just made the contact info card the main content for this page? That will be a pretty straightforward PR, and we could skip an intermediate step.

Fine by me.

PR for removing the contact form:
https://github.com/WikipediaLibrary/TWLight/pull/1232

As an outcome of this work we have decided to move away from emails as our method of sharing information and notifying users about library events. Further details in T353476.

In T347512#9388984, @taavi wrote:

In T347512#9380125, @bd808 wrote:

That is a MX for wikimedia.org rejecting an inbound message to wikipedialibrary@wikimedia.org because the envelope From of no-reply.wikipedialibrary@wmcloud.org was not acknowledged as a deliverable address by ... some host. We do not publish any MX records for the wmcloud.org domain, so I'm not completely sure what host mx{1001,2001} would have connected to when attempting to verify the envelope From address. I guess it would have ended up finding 185.15.56.49, which is the external interface of the wmcloud.org & wmflabs.org HTTP reverse proxy service. That really should be the same host that found when attempting a deliverability check for "noreply@wikipedialibrary.wmflabs.org" as well. I feel like I'm getting to a "wait, how does any of this work" moment.

This turned out to be a misconfiguration on the wikimedia.org mail servers which I've now fixed, so it's now possible to send mail from wmcloud.org to wikimedia.org addresses.

@taavi any idea if a misconfiguration issue might have cropped up again?