Page MenuHomePhabricator

Deploy the WikimediaCampaignEvents extension to the Beta Cluster
Closed, ResolvedPublic

Description

Checklist from https://www.mediawiki.org/wiki/Writing_an_extension_for_deployment#Process (read this on-wiki for links and examples):

Prerequisites: T347896: Prepare the WikimediaCampaignEvents extension for deployment

  • 1. Add the new extension submodule to the git mediawiki/extensions repo.
  • 2. Move your extension's CI config to the "Wikimedia production" section, add the "in-wikimedia-production" job template, and make sure it has and passes all the expected jobs for production code.
  • 3. Add your extension to the json make-wmf-branch release tool at least two weeks prior to your target date for enabling on the Beta Cluster.
  • 4. Add your extension to extension-list.
  • 5. Create database schema in beta wikishared
  • 6. Prepare a patch for each of the following items:
    • Configure the Fluxx client ID and client secret (P53297) in beta's PrivateSettings.php.
    • Configure the Fluxx endpoint URL (r994866)
    • Add private config stubs to the readme (r994867).
    • Load the extension in CommonSettings-labs.php if $wmgUseCampaignEvents is true. (r994179)
  • 7. Add the patches above to a deployment window.
  • 8. Add to the "Extensions used by Wikimedia - Upcoming" group in translatewiki (r994960)
  • 9. Post update on the performance review task (T350947) that the review can now begin

Then: T347909: Deploy the WikimediaCampaignEvents extension to production

Event Timeline

Daimona changed the task status from Open to Stalled.Nov 3 2023, 3:57 PM
Daimona added a subscriber: cmelo.

This is currently blocked because we would need a testing instance of Fluxx to use in beta. If such instance does not exist, we should either not deploy this to meta, or disable (completely or in part) the grant ID feature.

@cmelo I think you were looking into the existence of a testing instance?

Change 989190 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[integration/config@master] zuul: [mediawiki/extensions/WikimediaCampaignEvents] Promote to Wikimedia prod section

https://gerrit.wikimedia.org/r/989190

daimona opened https://gitlab.wikimedia.org/repos/releng/release/-/merge_requests/57

Start branching WikimediaCampaignEvents for Wikimedia production

Daimona changed the task status from Stalled to Open.Jan 9 2024, 2:57 PM
Daimona changed the status of subtask T347896: Prepare the WikimediaCampaignEvents extension for deployment from Stalled to Open.

jforrester merged https://gitlab.wikimedia.org/repos/releng/release/-/merge_requests/57

Start branching WikimediaCampaignEvents for Wikimedia production

Change 989190 merged by jenkins-bot:

[integration/config@master] zuul: [mediawiki/extensions/WikimediaCampaignEvents] Promote to Wikimedia prod section

https://gerrit.wikimedia.org/r/989190

Mentioned in SAL (#wikimedia-releng) [2024-01-09T15:04:03Z] <James_F> zuul: [mediawiki/extensions/WikimediaCampaignEvents] Promote to Wikimedia prod section for T347894

Daimona changed the task status from Open to Stalled.Jan 9 2024, 3:33 PM
Daimona updated the task description. (Show Details)

Now entering the 2-week wait period for all the needed branches to be cut.

Daimona changed the task status from Stalled to Open.Jan 29 2024, 5:39 PM

No longer stalled: the wmf.14 and wmf.15 branches have been cut for the WikimediaCampaignEvents extension, and production is running wmf.15, with wmf.16 to be rolled out this week.

Change 994176 had a related patch set uploaded (by Cmelo; author: Cmelo):

[operations/mediawiki-config@master] Add WikimediaCampaignEvents to extension list

https://gerrit.wikimedia.org/r/994176

Change 994179 had a related patch set uploaded (by Mhorsey; author: Mhorsey):

[operations/mediawiki-config@master] Update commonsettings-labs to enable WikimediaCampaignEvents extension on beta

https://gerrit.wikimedia.org/r/994179

Daimona updated the task description. (Show Details)

Change 994176 merged by jenkins-bot:

[operations/mediawiki-config@master] Add WikimediaCampaignEvents to extension list

https://gerrit.wikimedia.org/r/994176

Mentioned in SAL (#wikimedia-operations) [2024-01-31T14:36:01Z] <urbanecm@deploy2002> Started scap: Backport for [[gerrit:994176|Add WikimediaCampaignEvents to extension list (T347894)]]

Mentioned in SAL (#wikimedia-operations) [2024-01-31T14:37:31Z] <urbanecm@deploy2002> cmelo and urbanecm: Backport for [[gerrit:994176|Add WikimediaCampaignEvents to extension list (T347894)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Mentioned in SAL (#wikimedia-operations) [2024-01-31T14:46:43Z] <urbanecm@deploy2002> Finished scap: Backport for [[gerrit:994176|Add WikimediaCampaignEvents to extension list (T347894)]] (duration: 10m 41s)

Change 994866 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[operations/mediawiki-config@master] beta: Configure Fluxx endpoint for WikimediaCampaignEvents

https://gerrit.wikimedia.org/r/994866

Change 994867 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[operations/mediawiki-config@master] private/readme.php: Add stubs for WikimediaCampaignEvents

https://gerrit.wikimedia.org/r/994867

Change 994866 merged by jenkins-bot:

[operations/mediawiki-config@master] beta: Configure Fluxx endpoint for WikimediaCampaignEvents

https://gerrit.wikimedia.org/r/994866

Change 994867 merged by jenkins-bot:

[operations/mediawiki-config@master] private/readme.php: Add stubs for WikimediaCampaignEvents

https://gerrit.wikimedia.org/r/994867

Change 994179 merged by jenkins-bot:

[operations/mediawiki-config@master] Update commonsettings-labs to enable WikimediaCampaignEvents extension on beta

https://gerrit.wikimedia.org/r/994179

Daimona removed a project: Patch-For-Review.

This is now ready to be tested in beta!

✅ This is working correctly in betacluster. It is accepting only the appropriate test values, and displaying an error for anything besides that.


A couple of questions:

Grant ID is shown only to the organizer of the event. I assume this is correct, but just checking here.

Screen Recording 2024-02-01 at 5.52.58 PM.gif (1×2 px, 789 KB)

If there is any trailing (or leading) whitespace, it will not accept the value. Do you think trimming whitespace upon form submission here is a good idea or unnecessary?

Screen Recording 2024-02-01 at 5.43.25 PM.gif (1×1 px, 3 MB)

Grant ID is shown only to the organizer of the event. I assume this is correct, but just checking here.

Yup, from T321814:

The grant ID should only be viewable in Special:EventDetails for event organizers.

If there is any trailing (or leading) whitespace, it will not accept the value. Do you think trimming whitespace upon form submission here is a good idea or unnecessary?

That's doable and it might be a good idea, curious to hear what others think. At any rate, it should probably be a separate task.

Yes, I generally feel like trimming whitespace on inputs is a good idea across the board.

Yes, I also think that it is a good idea to remove whitespace.

Okay great - I created T356520 to trim whitespace for Grant ID on form submission and am moving this ticket to design sign off

ifried subscribed.

The extension has been released and Grant ID is now showing as a field when configuring & editing Event Registration, so I am marking this work as Done.