[COG] [TECH] Migrate Cognate to use a virtual database domain
Closed, ResolvedPublic
Actions

Description

See T330590: External LBs should not be exposed to developers for context, and this UrlShortener change for an example of the change to implement.

Should be a fairly small change, I expect – the DB setup is already well centralized in this extension, only two places call getExternalLB: the service wiring, and the database updater (where the service wiring isn’t available yet).

Details

Subject	Repo	Branch	Lines +/-
Remove Cognate virtual domain mapping b/c code	operations/mediawiki-config	master	+0 -3
Introduce a constant for the virtual domain name	mediawiki/extensions/Cognate	master	+15 -13
Migrate to virtual domain mapping	mediawiki/extensions/Cognate	master	+37 -91
Migrate to virtual domain mapping	mediawiki/extensions/Cognate	wmf/1.42.0-wmf.19	+37 -91
Migrate to virtual domain mapping	mediawiki/extensions/Cognate	wmf/1.42.0-wmf.18	+37 -91
Add wgVirtualDomainsMapping for Cognate	operations/mediawiki-config	master	+3 -1

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Open		None	T348573 All Wikimedia extensions that store their data outside the main database should use a virtual database domain
		Resolved		hoo	T348526 [COG] [TECH] Migrate Cognate to use a virtual database domain

Event Timeline

Lucas_Werkmeister_WMDE created this task.Oct 10 2023, 11:53 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 10 2023, 11:53 AM

Maintenance_bot added a project: Wikidata.Oct 10 2023, 12:29 PM

Lucas_Werkmeister_WMDE edited projects, added wmde-wikidata-tech; removed [DEPRECATED] wdwb-tech.Oct 10 2023, 1:35 PM

Task Review Notes:

The scope is relatively limited, and it might help improve readability.

Prio Notes:

Does not affect end users / production
Does not affect monitoring
Affects development efforts
Does not affect onboarding
Might affect additional stakeholders (DBA intend to eventualy deprecate the old style)

ItamarWMDE renamed this task from Migrate Cognate to use a virtual database domain to [SW] [COGNATE] [TECH] Migrate Cognate to use a virtual database domain.Oct 10 2023, 1:44 PM

ItamarWMDE moved this task from Incoming to [DOT] Prioritized on the wmde-wikidata-tech board.

ItamarWMDE renamed this task from [SW] [COGNATE] [TECH] Migrate Cognate to use a virtual database domain to [SW] [COG] [TECH] Migrate Cognate to use a virtual database domain.Oct 10 2023, 5:00 PM

Tgr added a parent task: T348573: All Wikimedia extensions that store their data outside the main database should use a virtual database domain.Oct 10 2023, 7:11 PM

Ladsgroup subscribed.Oct 10 2023, 7:20 PM

Lucas_Werkmeister_WMDE updated the task description. (Show Details)Oct 25 2023, 9:06 AM

ItamarWMDE renamed this task from [SW] [COG] [TECH] Migrate Cognate to use a virtual database domain to [COG] [TECH] Migrate Cognate to use a virtual database domain.Oct 25 2023, 9:07 AM

ItamarWMDE added a project: Wikidata Dev Team.Oct 25 2023, 1:48 PM

Arian_Bozorg moved this task from Incoming to [DOT] Tech Backlog on the Wikidata Dev Team board.Oct 25 2023, 1:49 PM

Arian_Bozorg moved this task from [DOT] Tech Backlog to Unified DOT Backlog on the Wikidata Dev Team board.

hoo claimed this task.Jan 31 2024, 9:11 AM

hoo edited projects, added Wikidata Dev Team (Wikidata.org Slice); removed Wikidata Dev Team.

hoo moved this task from In Task Breakdown to In Development on the Wikidata Dev Team (Wikidata.org Slice) board.

Change 994922 had a related patch set uploaded (by Hoo man; author: Hoo man):

[operations/mediawiki-config@master] Add wgVirtualDomainsMapping for Cognate

https://gerrit.wikimedia.org/r/994922

gerritbot added a project: Patch-For-Review.Feb 1 2024, 8:02 AM

Change 994922 merged by jenkins-bot:

[operations/mediawiki-config@master] Add wgVirtualDomainsMapping for Cognate

https://gerrit.wikimedia.org/r/994922

Mentioned in SAL (#wikimedia-operations) [2024-02-06T08:08:46Z] <hoo@deploy2002> Started scap: Backport for [[gerrit:994922|Add wgVirtualDomainsMapping for Cognate (T348526)]]

Mentioned in SAL (#wikimedia-operations) [2024-02-06T08:10:35Z] <hoo@deploy2002> hoo: Backport for [[gerrit:994922|Add wgVirtualDomainsMapping for Cognate (T348526)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Mentioned in SAL (#wikimedia-operations) [2024-02-06T08:17:38Z] <hoo@deploy2002> Finished scap: Backport for [[gerrit:994922|Add wgVirtualDomainsMapping for Cognate (T348526)]] (duration: 08m 51s)

Lucas_Werkmeister_WMDE removed a project: Patch-For-Review.Feb 12 2024, 4:56 PM

Maintenance_bot moved this task from [DOT] Prioritized to Ongoing on the wmde-wikidata-tech board.Feb 12 2024, 5:29 PM

Change 1003510 had a related patch set uploaded (by Hoo man; author: Hoo man):

[mediawiki/extensions/Cognate@master] Migrate to virtual domain mapping

https://gerrit.wikimedia.org/r/1003510

gerritbot added a project: Patch-For-Review.Feb 14 2024, 7:23 PM

hoo moved this task from In Development to Ready for Peer Review on the Wikidata Dev Team (Wikidata.org Slice) board.Feb 20 2024, 1:03 PM

Lucas_Werkmeister_WMDE moved this task from Ready for Peer Review to In Peer Review on the Wikidata Dev Team (Wikidata.org Slice) board.Feb 20 2024, 2:26 PM

Change 1003510 merged by jenkins-bot:

[mediawiki/extensions/Cognate@master] Migrate to virtual domain mapping

https://gerrit.wikimedia.org/r/1003510

Maintenance_bot removed a project: Patch-For-Review.Feb 21 2024, 11:30 AM

Change 1005467 had a related patch set uploaded (by Hoo man; author: Hoo man):

[mediawiki/extensions/Cognate@wmf/1.42.0-wmf.18] Migrate to virtual domain mapping

https://gerrit.wikimedia.org/r/1005467

gerritbot added a project: Patch-For-Review.Feb 21 2024, 12:02 PM

Lucas_Werkmeister_WMDE moved this task from In Peer Review to Waiting for Deployment Window on the Wikidata Dev Team (Wikidata.org Slice) board.Feb 21 2024, 4:39 PM

Change 1005485 had a related patch set uploaded (by Hoo man; author: Hoo man):

[mediawiki/extensions/Cognate@wmf/1.42.0-wmf.19] Migrate to virtual domain mapping

https://gerrit.wikimedia.org/r/1005485

Change 1005467 merged by jenkins-bot:

[mediawiki/extensions/Cognate@wmf/1.42.0-wmf.18] Migrate to virtual domain mapping

https://gerrit.wikimedia.org/r/1005467

Change 1005485 merged by jenkins-bot:

[mediawiki/extensions/Cognate@wmf/1.42.0-wmf.19] Migrate to virtual domain mapping

https://gerrit.wikimedia.org/r/1005485

Mentioned in SAL (#wikimedia-operations) [2024-02-22T08:06:30Z] <hoo@deploy2002> Started scap: Backport for [[gerrit:1005467|Migrate to virtual domain mapping (T348526)]], [[gerrit:1005485|Migrate to virtual domain mapping (T348526)]]

Mentioned in SAL (#wikimedia-operations) [2024-02-22T08:08:04Z] <hoo@deploy2002> hoo: Backport for [[gerrit:1005467|Migrate to virtual domain mapping (T348526)]], [[gerrit:1005485|Migrate to virtual domain mapping (T348526)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Mentioned in SAL (#wikimedia-operations) [2024-02-22T08:21:15Z] <hoo@deploy2002> Finished scap: Backport for [[gerrit:1005467|Migrate to virtual domain mapping (T348526)]], [[gerrit:1005485|Migrate to virtual domain mapping (T348526)]] (duration: 14m 44s)

Maintenance_bot removed a project: Patch-For-Review.Feb 22 2024, 8:30 AM

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.20; 2024-02-27).Feb 22 2024, 11:02 AM

Change 1005725 had a related patch set uploaded (by Hoo man; author: Hoo man):

[mediawiki/extensions/Cognate@master] Introduce a constant for the virtual domain name

https://gerrit.wikimedia.org/r/1005725

gerritbot added a project: Patch-For-Review.Feb 22 2024, 11:16 AM

ReleaseTaggerBot edited projects, added MW-1.42-notes (1.42.0-wmf.19; 2024-02-20); removed MW-1.42-notes (1.42.0-wmf.20; 2024-02-27).Feb 22 2024, 12:01 PM

Change 1005725 merged by jenkins-bot:

[mediawiki/extensions/Cognate@master] Introduce a constant for the virtual domain name

https://gerrit.wikimedia.org/r/1005725

Lucas_Werkmeister_WMDE closed this task as Resolved.Feb 22 2024, 12:20 PM

Lucas_Werkmeister_WMDE moved this task from Waiting for Deployment Window to Done on the Wikidata Dev Team (Wikidata.org Slice) board.

Maintenance_bot removed a project: Patch-For-Review.Feb 22 2024, 12:31 PM

ReleaseTaggerBot edited projects, added MW-1.42-notes (1.42.0-wmf.20; 2024-02-27); removed MW-1.42-notes (1.42.0-wmf.19; 2024-02-20).Feb 22 2024, 1:00 PM

Hi hi. You still need to change the db updater hook

That’s too terse for me to understand, sorry – can you clarify what’s still missing? (Move CognateUpdater logic into CognateSchemaHooks was merged, but I also thought that was just an optional refactoring.)

Oh then it's done. I missed it because it wasn't connected to this ticket. My bad!

Could you explain what still needs to be done here, maybe some cleanup? The current config has a "temp"-comment linking to this task:

wmf-config/InitialiseSettings.php

if ( $wmgUseCognate ) {
	wfLoadExtension( 'Cognate' );
	$wgVirtualDomainsMapping['virtual-cognate'] = [ 'cluster' => 'extension1', 'db' => 'cognate_wiktionary' ];
	$wgCognateNamespaces = [ 0 ];
	// Temp b/c for T348526
	$wgCognateDb = 'cognate_' . $wmgUseCognate;
	$wgCognateCluster = 'extension1';
}

I noticed this because we have two tasks about Cognate not fully working for new Wiktionaries (T326432 and T360194). They are probably not directly related, but this config is not helping with figuring out the root cause.