Page MenuHomePhabricator

Special:LinkSearch does not display results for protocol relative URLs
Closed, DeclinedPublic

Description

Special:LinkSearch does not display results for protocol relative URLs

compare

the last one actually displays protocol relative URLs instead of https, which might be another bug to open, I guess.


Version: 1.18.x
Severity: major
Whiteboard: aklapper-moreinfo

Details

Reference
bz33030

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 12:05 AM
bzimport set Reference to bz33030.
bzimport added a subscriber: Unknown Object (MLST).

(In reply to comment #0)

Special:LinkSearch does not display results for protocol relative URLs

compare

https://cs.wikipedia.org/wiki/Special:LinkSearch/https://commons.wikimedia.org

the last one actually displays protocol relative URLs instead of https, which
might be another bug to open, I guess.

The fact that the https search finds protocol-relative URLs is not a bug. The fact that the protocol-relative search doesn't work, however, is a bug.

(In reply to comment #1)

The fact that the https search finds protocol-relative URLs is not a bug. The
fact that the protocol-relative search doesn't work, however, is a bug.

Then I would assume that

https://cs.wikipedia.org/wiki/Speci%C3%A1ln%C3%AD:Hled%C3%A1n%C3%AD_odkaz%C5%AF/http://commons.wikimedia.org

or at least

http://cs.wikipedia.org/wiki/Speci%C3%A1ln%C3%AD:Hled%C3%A1n%C3%AD_odkaz%C5%AF/http://commons.wikimedia.org

will find the protocol relative URLs as well which it doesn't.

The externallinks table contains to rows for a protocol relative link, so you can find it with https and http in your search request. Maybe they need three rows?

See bug 29854

With gerrit change 28908 merged some time ago, some bugs were fixed. Does the current situation solve this bug?

Danny B: Please answer comment 4.

Danny B: Please answer comment 4.

Aklapper changed the task status from Open to Stalled.Nov 25 2014, 7:47 PM

With gerrit change 28908 merged some time ago, some bugs were fixed. Does the current situation solve this bug?

No.

Danny_B changed the task status from Stalled to Open.Jan 22 2016, 7:58 PM
Krinkle subscribed.

the last one actually displays protocol relative URLs instead of https, which might be another bug to open, I guess.

This is by design since protocol-relative URLs support HTTPS and in todays' world generally do link to HTTPS. I believe this feature exists mainly for discovery, not for analysing wikitext source, so I'd expect it to include things that are reachable and known to be linked via HTTPS regardless of how it was expressed in wikitext.

The fact that // doesn't yield results could be a feature request if we want to specifically allow wikitext analysis as a use case, but I don't know why someone would want that.

The remaining issue is that a plain search by domain is only returning HTTP results. That seems like a bug indeed, and is reported separately at T14810. I'll close this in favour of that. That but is not specific to protocol-relative addresses though, it affects explicit HTTPS results as well which are also not returned for domain searches.