Page MenuHomePhabricator
Create Task
Maniphest T352065

Stop showing IP warning on Item and Property pages for Wikibase instances that have temporary accounts enabled
Closed, ResolvedPublic
Actions

Description

Problem:
We are showing warnings when edits are made via SpecialPages to Items and Properties and the user isn't logged in. This warning informs them that their IP will be shown. With IP Masking this will no longer be the case so we should remove the warning.
This applies to all edits to Item and Properties that are done via SpecialPages.

Affected SpecialPages:

  • Create Item
  • Create Property
  • Merge Item
  • Redirect an entity
  • Set Item sitelink
  • Set Item label, description and aliases
  • Set Property label, description and aliases

Acceptance criteria:

  • IP leak warning isn't shown when editing Items and Properties via SpecialPages when IP Masking is enabled

Details

SubjectRepoBranchLines +/-
Update AnonymousEditWarningBuilderTest (2x)mediawiki/extensions/Wikibasemaster+7 -1
Improve anonymous edit warning message documentationmediawiki/extensions/Wikibasemaster+2 -2
Remove IP warning for anonymous edits on wikis with TempUsermediawiki/extensions/Wikibasemaster+50 -5
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 In ProgressNiharikaT324492 Temporary accounts - MVP
 OpenNoneT326816 Update features for temporary accounts
 OpenNoneT326908 Update WMDE Engineering-owned products that may be affected by IP Masking
 ResolvedArian_BozorgT351968 Update Wikidata-related extensions for IP Masking
 ResolvedArian_BozorgT351970 [EPIC] Stop showing IP warning on SpecialPages for Wikibase instances that have temporary accounts enabled
 ResolvedArian_BozorgT352065 Stop showing IP warning on Item and Property pages for Wikibase instances that have temporary accounts enabled
 ResolvedArian_BozorgT352066 Stop showing IP warning on Create Item for Wikibase instances that have temporary accounts enabled
 ResolvedArian_BozorgT352067 Stop showing IP warning on Create Property for Wikibase instances that have temporary accounts enabled
 ResolvedArian_BozorgT352068 Stop showing IP warning on Merge Item for Wikibase instances that have temporary accounts enabled
 DeclinedNoneT352069 Stop showing IP warning when setting a Property label, description or alias for Wikibase instances that have temporary accounts enabled
 ResolvedArian_BozorgT352070 Stop showing IP warning when setting an Item/Property label, description or alias for Wikibase instances that have temporary accounts enabled
 ResolvedArian_BozorgT352071 Stop showing IP warning when setting an Item sitelink for Wikibase instances that have temporary accounts enabled
 ResolvedArian_BozorgT352072 Stop showing IP warning on Redirect an Entity for Wikibase instances that have temporary accounts enabled

Event Timeline

Arian_Bozorg created this task.Nov 27 2023, 5:27 PM
Arian_Bozorg mentioned this in T351970: [EPIC] Stop showing IP warning on SpecialPages for Wikibase instances that have temporary accounts enabled.Nov 27 2023, 5:53 PM
Arian_Bozorg moved this task from Incoming to Product Backlog on the Wikidata Dev Team board.Dec 5 2023, 3:12 PM
Arian_Bozorg closed subtask T352069: Stop showing IP warning when setting a Property label, description or alias for Wikibase instances that have temporary accounts enabled as Declined.Dec 15 2023, 11:16 AM
ArthurTaylor moved this task from Product Backlog to Wikidata.org Slice on the Wikidata Dev Team board.Dec 20 2023, 10:16 AM
ArthurTaylor edited projects, added Wikidata Dev Team (Wikidata.org Slice); removed Wikidata Dev Team.
ArthurTaylor moved this task from In Task Breakdown to In Development on the Wikidata Dev Team (Wikidata.org Slice) board.Dec 20 2023, 10:24 AM
Maintenance_bot moved this task from Incoming to Ongoing on the wmde-wikidata-tech board.Dec 20 2023, 10:29 AM
ArthurTaylor moved this task from In Development to Parent Task on the Wikidata Dev Team (Wikidata.org Slice) board.Dec 20 2023, 10:31 AM
ArthurTaylor claimed this task.Dec 20 2023, 10:44 AM
ArthurTaylor moved this task from Parent Task to Ready for Peer Review on the Wikidata Dev Team (Wikidata.org Slice) board.
gerritbot added a comment.Dec 20 2023, 11:26 AM

Change 984210 had a related patch set uploaded (by Arthur taylor; author: Arthur taylor):

[mediawiki/extensions/Wikibase@master] Remove IP warning for anonymous edits on wikis with TempUser

https://gerrit.wikimedia.org/r/984210

gerritbot added a project: Patch-For-Review.Dec 20 2023, 11:26 AM
ArthurTaylor moved this task from Ready for Peer Review to In Peer Review on the Wikidata Dev Team (Wikidata.org Slice) board.Dec 22 2023, 11:14 AM
gerritbot added a comment.Dec 22 2023, 5:17 PM

Change 985321 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Update AnonymousEditWarningBuilderTest (2x)

https://gerrit.wikimedia.org/r/985321

gerritbot added a comment.Dec 22 2023, 5:17 PM

Change 985322 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Improve anonymous edit warning message documentation

https://gerrit.wikimedia.org/r/985322

gerritbot added a comment.Dec 29 2023, 11:54 AM

Change 984210 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Remove IP warning for anonymous edits on wikis with TempUser

https://gerrit.wikimedia.org/r/984210

ArthurTaylor moved this task from In Peer Review to Waiting for Deployment Window on the Wikidata Dev Team (Wikidata.org Slice) board.Dec 29 2023, 1:12 PM
ArthurTaylor removed ArthurTaylor as the assignee of this task.Jan 2 2024, 10:03 AM
ArthurTaylor moved this task from Waiting for Deployment Window to Product Verification on the Wikidata Dev Team (Wikidata.org Slice) board.
ArthurTaylor subscribed.
gerritbot added a comment.Jan 10 2024, 2:19 PM

Change 985322 abandoned by Lucas Werkmeister (WMDE):

[mediawiki/extensions/Wikibase@master] Improve anonymous edit warning message documentation

Reason:

squashed into parent change

https://gerrit.wikimedia.org/r/985322

gerritbot added a comment.Jan 10 2024, 2:19 PM

Change 985321 abandoned by Lucas Werkmeister (WMDE):

[mediawiki/extensions/Wikibase@master] Update AnonymousEditWarningBuilderTest (2x)

Reason:

squashed into parent change

https://gerrit.wikimedia.org/r/985321

Maintenance_bot removed a project: Patch-For-Review.Jan 10 2024, 2:31 PM
Arian_Bozorg closed subtask T352072: Stop showing IP warning on Redirect an Entity for Wikibase instances that have temporary accounts enabled as Resolved.Jan 10 2024, 2:49 PM
Arian_Bozorg closed subtask T352068: Stop showing IP warning on Merge Item for Wikibase instances that have temporary accounts enabled as Resolved.Jan 10 2024, 2:53 PM
Arian_Bozorg closed subtask T352070: Stop showing IP warning when setting an Item/Property label, description or alias for Wikibase instances that have temporary accounts enabled as Resolved.Jan 10 2024, 3:19 PM
Arian_Bozorg closed subtask T352071: Stop showing IP warning when setting an Item sitelink for Wikibase instances that have temporary accounts enabled as Resolved.
Arian_Bozorg closed subtask T352067: Stop showing IP warning on Create Property for Wikibase instances that have temporary accounts enabled as Resolved.
Arian_Bozorg closed subtask T352066: Stop showing IP warning on Create Item for Wikibase instances that have temporary accounts enabled as Resolved.
Arian_Bozorg closed this task as Resolved.Jan 10 2024, 3:25 PM
Arian_Bozorg claimed this task.
Arian_Bozorg moved this task from Product Verification to Done on the Wikidata Dev Team (Wikidata.org Slice) board.

All the subtasks are closed!

Thanks so much :)

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits