Page MenuHomePhabricator

[EPIC] Stop showing IP warning on SpecialPages for Wikibase instances that have temporary accounts enabled
Closed, ResolvedPublic

Description

Problem:
We are showing warnings when edits are made via SpecialPages to Entities and the user isn't logged in. This warning informs them that their IP will be shown. With IP Masking this will no longer be the case so we should remove the warning.
This applies for all edits to Entities that are done via SpecialPages.

Example

image.png (542×1 px, 128 KB)

In the example above only the IP warning should be removed.
i.e. "Warning: You are not logged in. Your IP address will be publicly visible if you make any edits."

This should only be removed only when IP masking is enabled.
When IP masking is enabled the message should read:

By clicking "Create", you agree to the terms of use, and you irrevocably agree to release your contribution under the Creative Commons CC0 License.
If you log in or create an account, your edits will be attributed to a username, among other benefits.

But the warning should remain as is on wikis that don't have IP masking enabled e.g. 3rd party Wikibases
When IP masking is not enabled it should continue to read:

By clicking "Create", you agree to the terms of use, and you irrevocably agree to release your contribution under the Creative Commons CC0 License.
Warning: You are not logged in. Your IP address will be publicly visible if you make any edits. If you log in or create an account, your edits will be attributed to a username, among other benefits.

Affected SpecialPages:

EntitySchema pages T352002:

  • Create EntitySchema T352004
  • Edit EntitySchema text T352005
  • Set label, description and aliases for EntitySchema T352006

Lexeme pages T352016:

Item and Property pages T352065:

BDD
GIVEN an Entity
WHEN making an edit to them via a Special Page
AND IP Masking is enabled
THEN do not show the IP leak warning

Acceptance criteria:

  • IP leak warning isn't shown when editing Entities via SpecialPages when IP Masking is enabled

Notes
[[ Ramifications of IP masking on Wikidata related extensions | Report: Ramifications of IP masking on Wikidata related extensions ]]

Related Objects

StatusSubtypeAssignedTask
In ProgressNiharika
OpenNone
OpenNone
ResolvedArian_Bozorg
ResolvedArian_Bozorg
ResolvedArian_Bozorg
ResolvedArian_Bozorg
ResolvedArian_Bozorg
ResolvedArthurTaylor
ResolvedArian_Bozorg
ResolvedArian_Bozorg
ResolvedArian_Bozorg
ResolvedArian_Bozorg
ResolvedArian_Bozorg
ResolvedArian_Bozorg
ResolvedArian_Bozorg
DeclinedNone
ResolvedArian_Bozorg
ResolvedArian_Bozorg
ResolvedArian_Bozorg

Event Timeline

Lydia_Pintscher added a subscriber: Arian_Bozorg.

@Arian_Bozorg Can you create subtickets for this to split them into 3:

  • Lexeme-related
  • EntitySchema-related
  • the rest (mainly Item/Property-specific)
Arian_Bozorg renamed this task from Stop showing IP warning on SpecialPages for Wikibase instances that have temporary accounts enabled to [EPIC] Stop showing IP warning on SpecialPages for Wikibase instances that have temporary accounts enabled.Nov 27 2023, 11:52 AM

Change 984206 had a related patch set uploaded (by Arthur taylor; author: Arthur taylor):

[mediawiki/extensions/Wikibase@master] Extend AnonymousEditWarningBuilder API

https://gerrit.wikimedia.org/r/984206

This is how the change to the Javascript version of Special:NewLexeme looks:

2023-12-28-105919_1213x201_scrot.png (201×1 px, 24 KB)

Per ticket, the text has been changed to remove the words "Warning: You are not logged in. Your IP address will be publicly visible if you make any edits.". That said, the message still shows up in a warning box with a warning triangle.

Especially for this change, but also for other changes, I feel like we either need to change the presentation (like a blue (!) or (💡)), or we need to keep the 'You are not logged in.' sentence. When I see just the words "If you log in or create an account, your edits will be attributed to a username, among other benefits.", it's not immediately clear to me that I'm not logged in, or that that's a call to action.

What do you think, @Lydia_Pintscher , @Arian_Bozorg ?

@ArthurTaylor I think for that one, could we take that copy out of the box and have it as a separate paragraph so that it will look similar to the Create Item page:

image.png (216×1 px, 49 KB)

@Arian_Bozorg That ship kinda sailed wth T352018 - do you want to re-open that and add the comment there?

Change #984206 abandoned by Arthur taylor:

[mediawiki/extensions/Wikibase@master] Extend AnonymousEditWarningBuilder API

Reason:

superceded by other changes

https://gerrit.wikimedia.org/r/984206