Page MenuHomePhabricator
Create Task
Maniphest T352423

Inconsistent spacing for translatable page indicators in the <languages> tag
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

The space between red languages links and blue links is inconsistent:

image.png (96×1 px, 19 KB)

This seems to be caused by the margin-inline-end for the indicator element that has no equivalent for the red languages.

Details

SubjectRepoBranchLines +/-
Language links: Add margin-right to progress indicators in ULSmediawiki/extensions/Translatemaster+4 -0
Language links: Add margin for redlinksmediawiki/extensions/Translatemaster+2 -3
Customize query in gerrit

Related Objects
Search...

Event Timeline

Nikerabbit created this task.Nov 30 2023, 2:17 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 30 2023, 2:17 PM
Nikerabbit added a parent task: T329046: Improve page translation progress indicators.Nov 30 2023, 2:17 PM
Tacsipacsi attached a referenced file: F41548359: image.png. (Show Details)Nov 30 2023, 3:42 PM
gerritbot added a comment.Dec 1 2023, 3:07 PM

Change 979374 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/Translate@master] Language links: Add margin for redlinks

https://gerrit.wikimedia.org/r/979374

gerritbot added a project: Patch-For-Review.Dec 1 2023, 3:07 PM
abi_ claimed this task.Dec 1 2023, 3:10 PM
abi_ triaged this task as Low priority.
abi_ added a project: Language-Team (Language-2023-October-December).
abi_ set the point value for this task to 2.
abi_ moved this task from Quarter Backlog to In Review on the Language-Team (Language-2023-October-December) board.
abi_ added a project: Localization Infrastructure FY2023-24.
abi_ changed the task status from Open to In Progress.Dec 4 2023, 1:44 PM
abi_ moved this task from Backlog to page translation on the MediaWiki-extensions-Translate board.Dec 6 2023, 6:56 AM
gerritbot added a comment.Dec 6 2023, 10:15 AM

Change 979374 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] Language links: Add margin for redlinks

https://gerrit.wikimedia.org/r/979374

Maintenance_bot removed a project: Patch-For-Review.Dec 6 2023, 10:30 AM
ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.9; 2023-12-12).Dec 6 2023, 11:00 AM
gerritbot added a comment.Dec 6 2023, 2:44 PM

Change 980875 had a related patch set uploaded (by Wangombe; author: Wangombe):

[mediawiki/extensions/Translate@master] Rename TranslateYaml::class to Yaml::class.

https://gerrit.wikimedia.org/r/980875

gerritbot added a project: Patch-For-Review.Dec 6 2023, 2:44 PM
gerritbot added a comment.Dec 6 2023, 6:04 PM

Change 980916 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/Translate@master] Language links: Add margin-right to progress indiciators in ULS

https://gerrit.wikimedia.org/r/980916

abi_ added a comment.Dec 6 2023, 6:07 PM

The changes caused a bit of an issue with progress indicators inside ULS:

image.png (540×564 px, 37 KB)

There is a lack of margin when the language items are hovered on.

Nikerabbit added a comment.Dec 11 2023, 11:20 AM

With fix

image.png (1×1 px, 61 KB)

gerritbot added a comment.Dec 11 2023, 11:39 AM

Change 980916 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] Language links: Add margin-right to progress indicators in ULS

https://gerrit.wikimedia.org/r/980916

abi_ moved this task from In Review to Check after deployment on the Language-Team (Language-2023-October-December) board.Dec 11 2023, 12:35 PM
Nikerabbit moved this task from Backlog to Translatable pages (LH1) on the Localization Infrastructure FY2023-24 board.Dec 12 2023, 11:39 AM
abi_ closed this task as Resolved.Dec 13 2023, 8:27 AM
abi_ moved this task from Check after deployment to Done on the Language-Team (Language-2023-October-December) board.

Checked on: https://www.mediawiki.org/wiki/Extension:Translate for both rtl and ltr languages.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL