Description

It seems the following test can fail under php8.2+, but also passed the most time, it seems the chance to get flaky is higher in modern php

https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-php82-noselenium-docker/146/console

1) WANObjectCacheTest::testPreemptiveRefresh
Value cached
Failed asserting that 2 is identical to 1.

/workspace/src/tests/phpunit/unit/includes/libs/objectcache/WANObjectCacheTest.php:658
/workspace/src/tests/phpunit/MediaWikiUnitTestCase.php:127

Passed under https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-php82-noselenium-docker/126/console

	Subject	Repo	Branch	Lines +/-
	WANObjectCacheTest::testPreemptiveRefresh: Skip flaky test for PHP 8.2+	mediawiki/core	REL1_41	+3 -0
	WANObjectCacheTest::testPreemptiveRefresh: Skip flaky test for PHP 8.2+	mediawiki/core	master	+3 -0

Event Timeline

Umherirrender created this task.Dec 11 2023, 6:03 PM

Restricted Application added a project: MediaWiki-Platform-Team. · View Herald TranscriptDec 11 2023, 6:03 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

php8.3 build was https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-php83-docker/6/console

Umherirrender moved this task from Backlog to MediaWiki core on the PHP 8.2 support board.Dec 12 2023, 12:13 PM

Umherirrender mentioned this in T352085: Make PHP 8.2 voting on development (master) branch of MW ecosystem (core, vendor, extensions, skins, libraries).Dec 12 2023, 12:17 PM

pmiazga moved this task from Inbox, needs triage to Within 2 Qs on the MediaWiki-Platform-Team board.Dec 12 2023, 3:52 PM

Jdforrester-WMF mentioned this in T353362: Make PHP 8.3 voting on development (master) branch of MW ecosystem (core, vendor, extensions, skins, libraries).Dec 13 2023, 6:45 PM

There is a mt_rand in WANObjectCache::worthRefreshExpiring and with php8.2 there is a new/refactored random extension.
I have seen this flaky test only on php8.2+, so this could be an issue that something change and now the random makes problems on CI.

php8.2 is now voting on core, if there are to many fails the test can be skipped by until the issue is investigated.

WANObjectCacheTest.php

	public function testPreemptiveRefresh() {
		$this->markTestSkippedIfPhp( '>=', '8.2' );

MusikAnimal subscribed.Dec 14 2023, 3:08 PM

Change 983258 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/core@master] WANObjectCacheTest::testPreemptiveRefresh: Skip flaky test for PHP 8.2+

https://gerrit.wikimedia.org/r/983258

gerritbot added a project: Patch-For-Review.Dec 14 2023, 7:57 PM

Change 983258 merged by jenkins-bot:

[mediawiki/core@master] WANObjectCacheTest::testPreemptiveRefresh: Skip flaky test for PHP 8.2+

https://gerrit.wikimedia.org/r/983258

Maintenance_bot removed a project: Patch-For-Review.Dec 15 2023, 6:10 AM

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.10; 2023-12-19).Dec 15 2023, 7:00 AM

Reedy moved this task from Backlog to MediaWiki core on the PHP 8.3 support board.Dec 18 2023, 10:40 PM

Paladox subscribed.Dec 19 2023, 2:59 PM

Umherirrender unsubscribed.Feb 11 2024, 12:07 AM

Krinkle moved this task from General to Confirmed problem on the MediaWiki-libs-BagOStuff board.Mar 26 2024, 7:08 PM

Change #1017397 had a related patch set uploaded (by Reedy; author: Jforrester):

[mediawiki/core@REL1_41] WANObjectCacheTest::testPreemptiveRefresh: Skip flaky test for PHP 8.2+

https://gerrit.wikimedia.org/r/1017397

gerritbot added a project: Patch-For-Review.Fri, Apr 5, 10:03 PM

Change #1017397 merged by jenkins-bot:

[mediawiki/core@REL1_41] WANObjectCacheTest::testPreemptiveRefresh: Skip flaky test for PHP 8.2+

https://gerrit.wikimedia.org/r/1017397

ReleaseTaggerBot added a project: MW-1.41-notes.Fri, Apr 5, 11:00 PM

Flaky test WANObjectCacheTest::testPreemptiveRefresh (at least under php8.2 and php8.3)
Open, Needs TriagePublic
Actions

Description

Details

Related Objects

Event Timeline

Flaky test WANObjectCacheTest::testPreemptiveRefresh (at least under php8.2 and php8.3)Open, Needs TriagePublicActions

Description

Details

Related Objects

Event Timeline

Flaky test WANObjectCacheTest::testPreemptiveRefresh (at least under php8.2 and php8.3)
Open, Needs TriagePublic
Actions