Page MenuHomePhabricator

Adjust EntitySchema Special Pages to not leak IPs when editing and IP masking is enabled
Closed, ResolvedPublic

Description

Problem:
We are currently leaking the IPs of users who are not logged in when making edits on EntitySchema Special Pages.

With temporary accounts are enabled on the repo, we must not leak the IPs of users who are not logged in and add entry with their temporary account name instead to the edit histories etc.

Affected EntitySchema SpecialPages

BDD
GIVEN a user who isn't logged in
AND Temporary Accounts are enabled
WHEN an edit is made on an EntitySchema Special Page
THEN an entry with their temporary account name is added to the edit history of the Item

Acceptance criteria:

  • IP is not leaked for users editing on the Create EntitySchema SpecialPage and IP masking is enabled on the repo
  • IP is not leaked for users editing on the Set label, description and aliases for EntitySchema SpecialPage and IP masking is enabled on the repo
  • IP is not leaked for users editing on the Edit EntitySchema text SpecialPage and IP masking is enabled on the repo