Page MenuHomePhabricator

PHP Deprecated: Use of MediaWiki\Content\Renderer\ContentRenderer::getParserOutput with integer revision id was deprecated in MediaWiki 1.42. [Called from MediaWiki\Extension\TemplateSandbox\Hooks::onAlternateEditPreview]
Closed, ResolvedPublicPRODUCTION ERROR

Description

Error
labels.normalized_message
[{reqId}] {exception_url}   PHP Deprecated: Use of MediaWiki\Content\Renderer\ContentRenderer::getParserOutput with integer revision id was deprecated in MediaWiki 1.42. [Called from MediaWiki\Extension\TemplateSandbox\Hooks::onAlternateEditPreview]
error.stack_trace
from /srv/mediawiki/php-1.42.0-wmf.18/extensions/TemplateSandbox/includes/Hooks.php(205)
#0 [internal function]: MWExceptionHandler::handleError(integer, string, string, string, array)
#1 /srv/mediawiki/php-1.42.0-wmf.18/includes/debug/MWDebug.php(379): trigger_error(string, integer)
#2 /srv/mediawiki/php-1.42.0-wmf.18/includes/debug/MWDebug.php(350): MWDebug::sendRawDeprecated(string, boolean, string)
#3 /srv/mediawiki/php-1.42.0-wmf.18/includes/debug/MWDebug.php(231): MWDebug::deprecatedMsg(string, string, string, integer)
#4 /srv/mediawiki/php-1.42.0-wmf.18/includes/GlobalFunctions.php(773): MWDebug::deprecated(string, string, string, integer)
#5 /srv/mediawiki/php-1.42.0-wmf.18/includes/content/Renderer/ContentRenderer.php(57): wfDeprecated(string, string)
#6 /srv/mediawiki/php-1.42.0-wmf.18/extensions/TemplateSandbox/includes/Hooks.php(205): MediaWiki\Content\Renderer\ContentRenderer->getParserOutput(WikitextContent, MediaWiki\Title\Title, integer, ParserOptions)
#7 /srv/mediawiki/php-1.42.0-wmf.18/includes/HookContainer/HookContainer.php(159): MediaWiki\Extension\TemplateSandbox\Hooks->onAlternateEditPreview(MediaWiki\EditPage\EditPage, WikitextContent, string, NULL)
#8 /srv/mediawiki/php-1.42.0-wmf.18/includes/HookContainer/HookRunner.php(668): MediaWiki\HookContainer\HookContainer->run(string, array)
#9 /srv/mediawiki/php-1.42.0-wmf.18/includes/editpage/EditPage.php(4002): MediaWiki\HookContainer\HookRunner->onAlternateEditPreview(MediaWiki\EditPage\EditPage, WikitextContent, string, NULL)
#10 /srv/mediawiki/php-1.42.0-wmf.18/includes/editpage/EditPage.php(2948): MediaWiki\EditPage\EditPage->getPreviewText()
#11 /srv/mediawiki/php-1.42.0-wmf.18/includes/editpage/EditPage.php(769): MediaWiki\EditPage\EditPage->showEditForm()
#12 /srv/mediawiki/php-1.42.0-wmf.18/includes/actions/EditAction.php(66): MediaWiki\EditPage\EditPage->edit()
#13 /srv/mediawiki/php-1.42.0-wmf.18/includes/actions/SubmitAction.php(38): EditAction->show()
#14 /srv/mediawiki/php-1.42.0-wmf.18/includes/actions/ActionEntryPoint.php(733): SubmitAction->show()
#15 /srv/mediawiki/php-1.42.0-wmf.18/includes/actions/ActionEntryPoint.php(510): MediaWiki\Actions\ActionEntryPoint->performAction(Article, MediaWiki\Title\Title)
#16 /srv/mediawiki/php-1.42.0-wmf.18/includes/actions/ActionEntryPoint.php(145): MediaWiki\Actions\ActionEntryPoint->performRequest()
#17 /srv/mediawiki/php-1.42.0-wmf.18/includes/MediaWikiEntryPoint.php(199): MediaWiki\Actions\ActionEntryPoint->execute()
#18 /srv/mediawiki/php-1.42.0-wmf.18/index.php(58): MediaWiki\MediaWikiEntryPoint->run()
#19 /srv/mediawiki/w/index.php(3): require(string)
#20 {main}
Impact

Deprecation warning, theoretically should block next train.

Notes

A few hundred of these in 1.42.0-wmf.18 (T354436).

Details

Request URL
https://ka.wiktionary.org/w/index.php?action=submit&title=*

Event Timeline

Marking as a blocker for next week's train, per policy.

Change 1003823 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/TemplateSandbox@master] Pass RevisionRecord to ContentRenderer::getParserOutput

https://gerrit.wikimedia.org/r/1003823

Change 1003823 merged by jenkins-bot:

[mediawiki/extensions/TemplateSandbox@master] Pass RevisionRecord to ContentRenderer::getParserOutput

https://gerrit.wikimedia.org/r/1003823