PHP Deprecated: Use of MediaWiki\Content\Renderer\ContentRenderer::getParserOutput with integer revision id
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Error

service.version: 1.42.0-wmf.18
trace.id: 3a53d5c1-2d58-4b21-9b03-f8fc0e80c4c9
Find trace.id in Logstash

labels.normalized_message

[{reqId}] {exception_url}   PHP Deprecated: Use of MediaWiki\Content\Renderer\ContentRenderer::getParserOutput with integer revision id was deprecated in MediaWiki 1.42. [Called from MediaWiki\Extension\TemplateSandbox\SpecialTemplateSandbox::onSubmit]

error.stack_trace

from /srv/mediawiki/php-1.42.0-wmf.18/extensions/TemplateSandbox/includes/SpecialTemplateSandbox.php(274)
#0 [internal function]: MWExceptionHandler::handleError(integer, string, string, string, array)
#1 /srv/mediawiki/php-1.42.0-wmf.18/includes/debug/MWDebug.php(379): trigger_error(string, integer)
#2 /srv/mediawiki/php-1.42.0-wmf.18/includes/debug/MWDebug.php(350): MWDebug::sendRawDeprecated(string, boolean, string)
#3 /srv/mediawiki/php-1.42.0-wmf.18/includes/debug/MWDebug.php(231): MWDebug::deprecatedMsg(string, string, string, integer)
#4 /srv/mediawiki/php-1.42.0-wmf.18/includes/GlobalFunctions.php(773): MWDebug::deprecated(string, string, string, integer)
#5 /srv/mediawiki/php-1.42.0-wmf.18/includes/content/Renderer/ContentRenderer.php(57): wfDeprecated(string, string)
#6 /srv/mediawiki/php-1.42.0-wmf.18/extensions/TemplateSandbox/includes/SpecialTemplateSandbox.php(274): MediaWiki\Content\Renderer\ContentRenderer->getParserOutput(WikitextContent, MediaWiki\Title\Title, integer, ParserOptions)
#7 /srv/mediawiki/php-1.42.0-wmf.18/includes/htmlform/HTMLForm.php(748): MediaWiki\Extension\TemplateSandbox\SpecialTemplateSandbox->onSubmit(array, OOUIHTMLForm)
#8 /srv/mediawiki/php-1.42.0-wmf.18/includes/htmlform/HTMLForm.php(629): HTMLForm->trySubmit()
#9 /srv/mediawiki/php-1.42.0-wmf.18/extensions/TemplateSandbox/includes/SpecialTemplateSandbox.php(116): HTMLForm->tryAuthorizedSubmit()
#10 /srv/mediawiki/php-1.42.0-wmf.18/includes/specialpage/SpecialPage.php(720): MediaWiki\Extension\TemplateSandbox\SpecialTemplateSandbox->execute(NULL)
#11 /srv/mediawiki/php-1.42.0-wmf.18/includes/specialpage/SpecialPageFactory.php(1653): MediaWiki\SpecialPage\SpecialPage->run(NULL)
#12 /srv/mediawiki/php-1.42.0-wmf.18/includes/actions/ActionEntryPoint.php(504): MediaWiki\SpecialPage\SpecialPageFactory->executePath(string, MediaWiki\Context\RequestContext)
#13 /srv/mediawiki/php-1.42.0-wmf.18/includes/actions/ActionEntryPoint.php(145): MediaWiki\Actions\ActionEntryPoint->performRequest()
#14 /srv/mediawiki/php-1.42.0-wmf.18/includes/MediaWikiEntryPoint.php(199): MediaWiki\Actions\ActionEntryPoint->execute()
#15 /srv/mediawiki/php-1.42.0-wmf.18/index.php(58): MediaWiki\MediaWikiEntryPoint->run()
#16 /srv/mediawiki/w/index.php(3): require(string)
#17 {main}

Impact

Hard deprecation in production is against the deprecation policy. Fixing callers or reverting hard-deprecation blocks the next train.

Notes

There are calls from more than one caller so I've not filed seperate tasks. At least these were found. If the decision is to fix callers, and if doing so is non-trivial, you'll probably want to file separate tasks for each.

PHP Deprecated: Use of MediaWiki\Content\Renderer\ContentRenderer::getParserOutput with integer revision id was deprecated in MediaWiki 1.42. [Called from MediaWiki\Extension\TemplateSandbox\Hooks::onAlternateEditPreview]`

PHP Deprecated: Use of MediaWiki\Content\Renderer\ContentRenderer::getParserOutput with integer revision id was deprecated in MediaWiki 1.42. [Called from FRInclusionCache::{closure}]

PHP Deprecated: Use of MediaWiki\Content\Renderer\ContentRenderer::getParserOutput with integer revision id was deprecated in MediaWiki 1.42. [Called from MediaWiki\Extension\TemplateSandbox\SpecialTemplateSandbox::onSubmit]

Details

	Subject	Repo	Branch	Lines +/-
	Tighten up phan type for ContentRenderer::getParserOutput()	mediawiki/core	master	+1 -1

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Resolved		None	T357006 FlaggedRevs uses deprecated ContentRenderer::getParserOutput with revision id, breaks CI
Resolved	Release	dduvall	T354438 1.42.0-wmf.20 deployment blockers
Resolved	PRODUCTION ERROR	Umherirrender	T358243 PHP Deprecated: Use of MediaWiki\Content\Renderer\ContentRenderer::getParserOutput with integer revision id

Event Timeline

Krinkle created this task.Feb 22 2024, 4:26 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 22 2024, 4:26 PM

Example fix from FlaggedRevs https://gerrit.wikimedia.org/r/c/mediawiki/extensions/FlaggedRevs/+/998942

That comes from 7fa728d6eca6fb4504ef6b46ba7cded1d5d71f81 Do not hard deprecate passing an int to ContentRenderer::getParserOutput for T357006

hashar added a parent task: T357006: FlaggedRevs uses deprecated ContentRenderer::getParserOutput with revision id, breaks CI.Feb 22 2024, 4:32 PM

Krinkle moved this task from Untriaged to Feb 2024 on the Wikimedia-production-error board.Feb 22 2024, 4:37 PM

From https://gerrit.wikimedia.org/r/c/mediawiki/core/+/998968:

Revert "Do not hard deprecate passing an int to ContentRenderer::getParserOutput"

Reason for revert: The remaining use in FlaggedRevs has been fixed.

@cscott Looks like FR as well as TemplateStyles are both still using this. Please take a look :)

Krinkle triaged this task as High priority.Feb 22 2024, 4:40 PM

Krinkle added a parent task: T354438: 1.42.0-wmf.20 deployment blockers.

Looks like the fixed tasks for wmf.19
T357700: PHP Deprecated: Use of MediaWiki\Content\Renderer\ContentRenderer::getParserOutput with integer revision id was deprecated in MediaWiki 1.42. [Called from FRInclusionCache::{closure}]
T357687: PHP Deprecated: Use of MediaWiki\Content\Renderer\ContentRenderer::getParserOutput with integer revision id was deprecated in MediaWiki 1.42. [Called from MediaWiki\Extension\TemplateSandbox\Hooks::onAlternateEditPreview]

Setting to UBN! since it's a subtask of this week's train so we treat it as a blocker.

In T358243#9569690, @Umherirrender wrote:

Looks like the fixed tasks for wmf.19
T357700: PHP Deprecated: Use of MediaWiki\Content\Renderer\ContentRenderer::getParserOutput with integer revision id was deprecated in MediaWiki 1.42. [Called from FRInclusionCache::{closure}]
T357687: PHP Deprecated: Use of MediaWiki\Content\Renderer\ContentRenderer::getParserOutput with integer revision id was deprecated in MediaWiki 1.42. [Called from MediaWiki\Extension\TemplateSandbox\Hooks::onAlternateEditPreview]

So is this fixed this week?

As far as I can tell it ought to be. FlaggedRevs and TemplateSandbox were the two extensions affected.

TemplateSandbox is T357687 and was fixed by https://gerrit.wikimedia.org/r/c/mediawiki/extensions/TemplateSandbox/+/1003823 (thanks!) merged on Feb 15 and included in 1.42.0-wmf.19.
FlaggedRevisions is T357700 and was fixed by https://gerrit.wikimedia.org/r/c/mediawiki/extensions/FlaggedRevs/+/1003822 (thanks again!) merged on Feb 15 and included in 1.42.0-wmf.19

These notices should be gone as of the deployment of 1.42.0-wmf.19 last week and this task should probably be closed. I just checked the original logstash URL and couldn't find any instances after wmf.18 on Feb 22.

cscott closed this task as Resolved.Feb 28 2024, 6:23 PM

cscott assigned this task to Umherirrender.

Change 1007418 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/core@master] Tighten up phan type for ContentRenderer::getParserOutput()

https://gerrit.wikimedia.org/r/1007418

gerritbot added a project: Patch-For-Review.Feb 28 2024, 6:31 PM

Thanks @cscott for the quick unblocking!

Change 1007418 merged by jenkins-bot: