Page MenuHomePhabricator
Create Task
Maniphest T358054

Move Parsoid's Poem implementation to the Poem repository
Closed, ResolvedPublic
Actions

Description

Similar to T354215 for Cite

In addition to the bullet points there, a final step is to remove the Parsoid dependency on the Poem extension in CI.

Details

SubjectRepoBranchLines +/-
Remove Parsoid dependency on Poemintegration/configmaster+1 -1
Bump wikimedia/(parsoid|shellbox|wikipeg)mediawiki/vendormaster+656 -748
Remove Poem implementation from Parsoid repositorymediawiki/services/parsoidmaster+2 -518
Hook up Parsoid implementation of Poemmediawiki/extensions/Poemmaster+24 -29
Add DOM stubs; Change namespace of imported Parsoid code to Poem/Parsoidmediawiki/extensions/Poemmaster+53 -6
Customize query in gerrit

Related Objects

Event Timeline

Arlolra created this task.Feb 20 2024, 9:05 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 20 2024, 9:05 PM
Arlolra updated the task description. (Show Details)Feb 20 2024, 9:09 PM
Jdforrester-WMF subscribed.Feb 20 2024, 9:53 PM
ihurbain moved this task from Needs Triage to Tech Debt / Big changes on the Parsoid board.Feb 22 2024, 3:08 PM
ihurbain added a project: Content-Transform-Team-WIP.
Arlolra claimed this task.Feb 24 2024, 12:50 AM
Arlolra triaged this task as Medium priority.
Arlolra added a comment.Feb 26 2024, 7:49 PM

See if we can preserve git history of Cite development in Parsoid

Pushed the merge commit,
https://github.com/wikimedia/mediawiki-extensions-Poem/commit/5ce5108c9fa52957b16959f9d930adc48f4fff30
https://github.com/wikimedia/mediawiki-extensions-Poem/blame/master/src/Parsoid/Poem.php

gerritbot added a comment.Feb 26 2024, 9:52 PM

Change 1006591 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/extensions/Poem@master] Add DOM stubs; Change namespace of imported Parsoid code to Poem/Parsoid

https://gerrit.wikimedia.org/r/1006591

gerritbot added a project: Patch-For-Review.Feb 26 2024, 9:52 PM
gerritbot added a comment.Feb 26 2024, 10:34 PM

Change 1006591 merged by jenkins-bot:

[mediawiki/extensions/Poem@master] Add DOM stubs; Change namespace of imported Parsoid code to Poem/Parsoid

https://gerrit.wikimedia.org/r/1006591

Arlolra moved this task from Backlog to In Progress on the Content-Transform-Team-WIP board.Feb 26 2024, 11:01 PM
Maintenance_bot removed a project: Patch-For-Review.Feb 26 2024, 11:36 PM
gerritbot added a comment.Feb 26 2024, 11:55 PM

Change 1006603 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/extensions/Poem@master] Hook up Parsoid implementation of Poem

https://gerrit.wikimedia.org/r/1006603

gerritbot added a project: Patch-For-Review.Feb 26 2024, 11:55 PM
gerritbot added a comment.Feb 26 2024, 11:58 PM

Change 1006604 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/services/parsoid@master] Remove Poem implementation from Parsoid repository

https://gerrit.wikimedia.org/r/1006604

gerritbot added a comment.Feb 27 2024, 12:26 AM

Change 1006605 had a related patch set uploaded (by Arlolra; author: Arlolra):

[integration/config@master] Remove Parsoid dependency on Poem

https://gerrit.wikimedia.org/r/1006605

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.20; 2024-02-27).Feb 27 2024, 1:01 AM
gerritbot added a comment.Feb 28 2024, 3:56 AM

Change 1006603 merged by jenkins-bot:

[mediawiki/extensions/Poem@master] Hook up Parsoid implementation of Poem

https://gerrit.wikimedia.org/r/1006603

ReleaseTaggerBot edited projects, added MW-1.42-notes (1.42.0-wmf.21; 2024-03-05); removed MW-1.42-notes (1.42.0-wmf.20; 2024-02-27).Feb 28 2024, 5:01 AM
MSantos added a project: Essential-Work.Mar 4 2024, 3:51 PM
MSantos moved this task from In Progress to Code Review on the Content-Transform-Team-WIP board.
gerritbot added a comment.Mar 5 2024, 3:49 PM

Change 1006604 merged by jenkins-bot:

[mediawiki/services/parsoid@master] Remove Poem implementation from Parsoid repository

https://gerrit.wikimedia.org/r/1006604

gerritbot added a comment.Mar 5 2024, 6:40 PM

Change 1008938 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/vendor@master] Bump wikimedia/(parsoid|shellbox|wikipeg)

https://gerrit.wikimedia.org/r/1008938

gerritbot added a comment.Mar 5 2024, 7:37 PM

Change 1008938 merged by jenkins-bot:

[mediawiki/vendor@master] Bump wikimedia/(parsoid|shellbox|wikipeg)

https://gerrit.wikimedia.org/r/1008938

ssastry moved this task from Code Review to To Verify on the Content-Transform-Team-WIP board.Mar 5 2024, 9:58 PM
gerritbot added a comment.Fri, Apr 5, 1:05 PM

Change #1006605 merged by jenkins-bot:

[integration/config@master] Remove Parsoid dependency on Poem

https://gerrit.wikimedia.org/r/1006605

Stashbot added a comment.Fri, Apr 5, 1:07 PM

Mentioned in SAL (#wikimedia-releng) [2024-04-05T13:07:35Z] <James_F> Zuul: Remove Parsoid dependency on Poem for T358054

Maintenance_bot removed a project: Patch-For-Review.Fri, Apr 5, 1:30 PM
Arlolra closed this task as Resolved.Fri, Apr 5, 6:19 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL