Page MenuHomePhabricator

Move Parsoid's Cite implementation to the Cite repository
Closed, ResolvedPublic

Description

We should have Parsoid-specific implementations of extensions live in the extension repositories.

Things to keep in mind when we do this:

  • See if we can preserve git history of Cite development in Parsoid
  • Ensure we turn on / enable integrated-mode testing of parser tests (if necessary, by adding html/parsoid+integrated sections to newer files that don't already have them)
  • Figure out if we can preserve standalone testing mode for this extension since we often rely on this for debugging / bug fixes. Filed as T359111
  • If the above is not possible, we should at least move tests in parser test file that us <ref>/<references> to integrated mode only
  • By default, we will no longer be able to run rt-testing on not-yet-deployed code in the Cite repository (as we have been so far) since extension code are deployed to scandium as part of the train. @cscott has a proposal to deploy Cite separately just like Parsoid code is deployed on scandium and use class loading hacks to have Cite come from there. Filed as T359109

Event Timeline

MSantos triaged this task as Medium priority.Jan 11 2024, 3:13 PM
MSantos moved this task from Needs Triage to Tech Debt / Big changes on the Parsoid board.

Change 991415 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/extensions/Cite@master] Change namespace of imported Parsoid code to Cite\Parsoid

https://gerrit.wikimedia.org/r/991415

Change 991415 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] Add DOM stubs; change namespace of imported Parsoid code to Cite\Parsoid

https://gerrit.wikimedia.org/r/991415

Change 991628 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/extensions/Cite@master] Hook up Parsoid implementation of Cite

https://gerrit.wikimedia.org/r/991628

Change 991663 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/core@master] ParserTests: add <pwraptest> and <transtag> tags for use in parser tests

https://gerrit.wikimedia.org/r/991663

Change 991664 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/services/parsoid@master] Remove Cite implementation from Parsoid repository

https://gerrit.wikimedia.org/r/991664

Change 991430 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/services/parsoid@master] Ensure that the Cite extension can provide its own implementation

https://gerrit.wikimedia.org/r/991430

Change 991430 merged by jenkins-bot:

[mediawiki/services/parsoid@master] Ensure that the Cite extension can provide its own implementation

https://gerrit.wikimedia.org/r/991430

Change 991804 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/extensions/Cite@master] Re-enable Parsoid integrated-mode tests

https://gerrit.wikimedia.org/r/991804

Change 991628 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] Hook up Parsoid implementation of Cite

https://gerrit.wikimedia.org/r/991628

Change 991840 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/extensions/Cite@master] Ensure CiteParsoidTest is using local Cite implementation, not Parsoid's

https://gerrit.wikimedia.org/r/991840

Change 991870 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/extensions/Cite@master] citeParserTests.txt: Enable all Parsoid test modes

https://gerrit.wikimedia.org/r/991870

Change 991663 merged by jenkins-bot:

[mediawiki/core@master] ParserTests: add <pwraptest> and <spantag> tags for use in parser tests

https://gerrit.wikimedia.org/r/991663

Change 992095 had a related patch set uploaded (by Isabelle Hurbain-Palatin; author: Isabelle Hurbain-Palatin):

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.19.0-a14

https://gerrit.wikimedia.org/r/992095

Change 992095 merged by jenkins-bot:

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.19.0-a14

https://gerrit.wikimedia.org/r/992095

Change 991840 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] Ensure CiteParsoidTest registers our Cite implementation

https://gerrit.wikimedia.org/r/991840

Change 991664 merged by jenkins-bot:

[mediawiki/services/parsoid@master] Remove Cite implementation from Parsoid repository

https://gerrit.wikimedia.org/r/991664

Change 1002606 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/core@master] Disable Parsoid test which requires the Cite extension be installed

https://gerrit.wikimedia.org/r/1002606

Change 1005143 had a related patch set uploaded (by Arlolra; author: Arlolra):

[integration/config@master] Remove Parsoid dependency on Cite and Imagemap

https://gerrit.wikimedia.org/r/1005143

Change 1005143 merged by jenkins-bot:

[integration/config@master] Remove Parsoid dependency on Cite, Disambiguator, and ImageMap

https://gerrit.wikimedia.org/r/1005143

Mentioned in SAL (#wikimedia-releng) [2024-02-20T21:07:17Z] <James_F> Zuul: Remove Parsoid dependency on Cite, Disambiguator, and ImageMap, for T354215

Change 1006605 had a related patch set uploaded (by Arlolra; author: Arlolra):

[integration/config@master] Remove Parsoid dependency on Poem

https://gerrit.wikimedia.org/r/1006605

Change 1008454 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Cite@master] Add basic PHPUnit tests for Parsoid implementation

https://gerrit.wikimedia.org/r/1008454

@thiemowmde it seems that the work for the move is done and this task can be resolved, but I see you still have a patch. Anything that it might be missing?

Arlolra claimed this task.
Arlolra reassigned this task from Arlolra to cscott.
Arlolra updated the task description. (Show Details)
Arlolra subscribed.

@MSantos, just some code clean ups I couldn't find a better task for. 😇️ Totally optional.

Change 1008454 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] Add basic PHPUnit tests for Parsoid implementation

https://gerrit.wikimedia.org/r/1008454