Page MenuHomePhabricator
Create Task
Maniphest T358586

Improve redirection logic when system expects a named user
Closed, ResolvedPublic2 Estimated Story Points
Actions

Assigned To
Dreamy_Jazz
Authored By
pmiazga
Feb 27 2024, 1:55 PM
Tags
Referenced Files
F57560403: image.png
Sep 28 2024, 4:11 AM
F57560332: image.png
Sep 28 2024, 4:11 AM
F57560374: image.png
Sep 28 2024, 4:11 AM
F57560370: image.png
Sep 28 2024, 4:11 AM
Subscribers
Aklapper
Djackson-ctr
KColeman-WMF
kostajh
Niharika
pmiazga
Tchanders
Tgr

Description

We have two helpers in MediaWiki Core SpecialPage handlers:

SpecialPage::requireLogin()
SpecialPage::requireNamedUser()

Those methods are used to trigger user type check, and when current user do not match expectations we redirect them to the Special:Userlogin page.

This redirection logic is correct for anonymous users, but temporary users are already logged in. Instead of redirect them to the Login page we should redirect them to Special:CreateAccount page and let them create an account.

This ticket as a result of a phab comment thread. For more info please refer to: https://phabricator.wikimedia.org/T326816#9554849

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Update error message for temp users trying to use special pagesmediawiki/extensions/ReadingListsmaster+3 -0
Send temporary accounts to Special:CreateAccount on ::requireNamedmediawiki/coremaster+218 -16
Update error message for temp users trying to use special pagesmediawiki/extensions/OAuthmaster+7 -2
Remove unused 'resetpass-no-info' message keymediawiki/coremaster+1 -4
Update error message for temp users trying to use special pagesmediawiki/extensions/GlobalWatchlistmaster+4 -1
Update error message for temp users trying to use special pagesmediawiki/extensions/ContactPagemaster+3 -0
Remove unused exception-nologin-text-manual messagemediawiki/coremaster+1 -3
Customize query in gerrit

Related Objects
Search...

Event Timeline

pmiazga created this task.Feb 27 2024, 1:55 PM
TAdeleye_WMF edited projects, added Trust and Safety Product Team; removed Anti-Harassment-Team.May 14 2024, 4:15 PM
Tchanders edited projects, added Temporary accounts (Update MediaWiki Core to introduce temp accounts); removed Temporary accounts.Jun 11 2024, 4:49 PM
kostajh added a subscriber: KColeman-WMF.Jul 12 2024, 6:40 PM

@Niharika @KColeman-WMF the idea in the task description sounds good to me. What do you think?

We probably also need to do T328718: [IP Masking] Do not show logged-in version of Special:CreateAccount page to temp accounts, so that the temporary account user has some additional information to guide them on Special:CreateAccount.

KColeman-WMF added a comment.Jul 12 2024, 9:00 PM
In T358586#9977707, @kostajh wrote:

@Niharika @KColeman-WMF the idea in the task description sounds good to me. What do you think?

We probably also need to do T328718: [IP Masking] Do not show logged-in version of Special:CreateAccount page to temp accounts, so that the temporary account user has some additional information to guide them on Special:CreateAccount.

Yes, I agree we should do both of these tasks so it's clear to temp users what creating an account will entail.

Niharika edited projects, added Temporary accounts (Blockers to minor pilot wiki deployment); removed Temporary accounts (Update MediaWiki Core to introduce temp accounts).Sep 4 2024, 5:12 PM
kostajh added a project: Trust and Safety Product Sprint (Sprint Beatboxing (Sept 16-27)).Sep 8 2024, 7:42 AM
kostajh moved this task from Priority Backlog to Ready on the Trust and Safety Product Sprint (Sprint Beatboxing (Sept 16-27)) board.Sep 16 2024, 10:27 AM
kostajh set the point value for this task to 2.
kostajh mentioned this in T344276: Should SpecialPages that return true for ::requireLogin allow access to temporary users?.Sep 16 2024, 10:32 AM
Dreamy_Jazz claimed this task.Sep 23 2024, 11:52 PM
Dreamy_Jazz moved this task from Ready to In Progress on the Trust and Safety Product Sprint (Sprint Beatboxing (Sept 16-27)) board.
gerritbot added a comment.Sep 24 2024, 12:26 AM

Change #1075090 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/core@master] [WIP] Send temporary accounts to Special:CreateAccount on ::requireNamed

https://gerrit.wikimedia.org/r/1075090

gerritbot added a project: Patch-For-Review.Sep 24 2024, 12:26 AM
kostajh moved this task from Backlog to In progress on the Temporary accounts (Blockers to minor pilot wiki deployment) board.Sep 24 2024, 8:34 AM
gerritbot added a comment.Sep 24 2024, 9:51 AM

Change #1075154 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/core@master] Remove unused exception-nologin-text-manual message

https://gerrit.wikimedia.org/r/1075154

gerritbot added a comment.Sep 24 2024, 11:07 AM

Change #1075154 merged by jenkins-bot:

[mediawiki/core@master] Remove unused exception-nologin-text-manual message

https://gerrit.wikimedia.org/r/1075154

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.25; 2024-10-01).Sep 24 2024, 12:00 PM
gerritbot added a comment.Sep 24 2024, 12:08 PM

Change #1075209 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/core@master] Remove unused 'resetpass-no-info' message key

https://gerrit.wikimedia.org/r/1075209

gerritbot added a comment.Sep 24 2024, 3:08 PM

Change #1075252 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/GlobalWatchlist@master] Update error message for temp users trying to use special pages

https://gerrit.wikimedia.org/r/1075252

gerritbot added a comment.Sep 24 2024, 4:10 PM

Change #1075268 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/OAuth@master] Update error message for temp users trying to use special pages

https://gerrit.wikimedia.org/r/1075268

gerritbot added a comment.Sep 24 2024, 4:47 PM

Change #1075271 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/ContactPage@master] Update error message for temp users trying to use special pages

https://gerrit.wikimedia.org/r/1075271

gerritbot added a comment.Sep 24 2024, 4:51 PM

Change #1075272 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/ReadingLists@master] Update error message for temp users trying to use special pages

https://gerrit.wikimedia.org/r/1075272

Dreamy_Jazz moved this task from In Progress to Needs review on the Trust and Safety Product Sprint (Sprint Beatboxing (Sept 16-27)) board.Sep 24 2024, 6:38 PM
gerritbot added a comment.Sep 24 2024, 10:51 PM

Change #1075209 merged by jenkins-bot:

[mediawiki/core@master] Remove unused 'resetpass-no-info' message key

https://gerrit.wikimedia.org/r/1075209

gerritbot added a comment.Sep 24 2024, 10:57 PM

Change #1075090 merged by jenkins-bot:

[mediawiki/core@master] Send temporary accounts to Special:CreateAccount on ::requireNamed

https://gerrit.wikimedia.org/r/1075090

gerritbot added a comment.Sep 24 2024, 10:57 PM

Change #1075271 merged by jenkins-bot:

[mediawiki/extensions/ContactPage@master] Update error message for temp users trying to use special pages

https://gerrit.wikimedia.org/r/1075271

gerritbot added a comment.Sep 24 2024, 10:57 PM

Change #1075268 merged by jenkins-bot:

[mediawiki/extensions/OAuth@master] Update error message for temp users trying to use special pages

https://gerrit.wikimedia.org/r/1075268

gerritbot added a comment.Sep 24 2024, 10:57 PM

Change #1075252 merged by jenkins-bot:

[mediawiki/extensions/GlobalWatchlist@master] Update error message for temp users trying to use special pages

https://gerrit.wikimedia.org/r/1075252

Dreamy_Jazz mentioned this in rECPA5c9294fad3fd: Update error message for temp users trying to use special pages.Sep 24 2024, 11:00 PM
kostajh moved this task from Needs review to Needs QA on the Trust and Safety Product Sprint (Sprint Beatboxing (Sept 16-27)) board.Sep 25 2024, 6:03 AM
gerritbot added a comment.Sep 25 2024, 1:29 PM

Change #1075272 merged by jenkins-bot:

[mediawiki/extensions/ReadingLists@master] Update error message for temp users trying to use special pages

https://gerrit.wikimedia.org/r/1075272

Maintenance_bot removed a project: Patch-For-Review.Sep 25 2024, 1:32 PM
Dreamy_Jazz added a comment.Sep 26 2024, 2:12 PM

Suggested QA steps:

part 1

  1. Create a temporary account
  2. Open Special:Preferences
  3. Check that you are taken to Special:CreateAccount and that a warning box indicates you should create an account to change preferences.
  4. Log out of your temporary account
  5. Open Special:Preferences
  6. Check that you are taken to Special:UserLogin and that a warning box indicates you should login to change your preferences

You may also wish to repeat the above suggested steps using a variety of other special pages that require the user to be logged in to a named account. For example, Special:ReadingLists and Special:Mute.

part 2

  1. Create a temporary account
  2. Open Special:ChangeEmail
  3. Check that you are taken to Special:UserLogin and that a warning box indicates you should log in to change your email.
  4. Log out of your temporary account
  5. Open Special:ChangeEmail
  6. Check the same things as in step 3
Djackson-ctr moved this task from Needs QA to Done on the Trust and Safety Product Sprint (Sprint Beatboxing (Sept 16-27)) board.Sep 28 2024, 4:11 AM
Djackson-ctr subscribed.

QA has been completed, and the new code changes are functioning as expected (temporary account users trying to access Special Pages will be redirected to the Special:CreateAccount page with a warning box, and when temporary account users log out and try to access Special Pages will be redirected to the Special:UserLogin page with a warning box)... Thank you for the QA Steps @Dreamy_Jazz, greatly appreciated!!!

image.png (510×1 px, 416 KB)

image.png (563×1 px, 251 KB)

image.png (430×1 px, 48 KB)

image.png (444×1 px, 231 KB)

kostajh closed this task as Resolved.Sep 29 2024, 2:57 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits