Page MenuHomePhabricator

Document mediawiki-router, move oojs-router into core
Closed, ResolvedPublic

Description

oojs-router is a foreign resource, but in practice never used outside our codebase. The npm module hasn't seen any updates in 2 years.

I think we should remove the foreign dependency and move this into core. The benefit of this is we will also be able to document it better.

Event Timeline

Change 1007735 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/core@master] Document mediawiki.router

https://gerrit.wikimedia.org/r/1007735

I'm not sure we should move it in, but either way, we should certainly update MW's version to latest, yes.

Change 1007920 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/core@master] Upgrade OOjs Router from 0.3.0 to 0.4.0

https://gerrit.wikimedia.org/r/1007920

Change 1007920 merged by jenkins-bot:

[mediawiki/core@master] Upgrade OOjs Router from 0.3.0 to 0.4.0

https://gerrit.wikimedia.org/r/1007920

I'm not sure we should move it in, but either way, we should certainly update MW's version to latest, yes.

The repo is now updated.

Speaking for myself as the person who originally created the npm module, I don't see much value in having this exist now outside the MediaWiki ecosystem - there are much better alternatives out there.

There are also no active maintainers there who also have publish rights. I've been told by at least one person they didn't want to fix a trivial bug there because making a bug fix involved the fix, a npm release and then to update core. I think this code would evolve better if it was inside MediaWiki core.

Change 1008543 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/core@master] Upgrade OOjs Router from 0.4.0 to 0.5.0

https://gerrit.wikimedia.org/r/1008543

Change 1008543 merged by jenkins-bot:

[mediawiki/core@master] Upgrade OOjs Router from 0.4.0 to 0.5.0

https://gerrit.wikimedia.org/r/1008543

Change 1007734 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/core@master] Move oojs-router into core, to allow archiving of npm module

https://gerrit.wikimedia.org/r/1007734

apaskulin triaged this task as Medium priority.Apr 16 2024, 8:59 PM

Change #1007734 merged by jenkins-bot:

[mediawiki/core@master] Move oojs-router into core, to allow archiving of npm module

https://gerrit.wikimedia.org/r/1007734

Change #1007735 merged by jenkins-bot:

[mediawiki/core@master] Document mediawiki.router

https://gerrit.wikimedia.org/r/1007735

Jdlrobson claimed this task.
Jdlrobson added a subscriber: apaskulin.

This is now done @apaskulin

Change #1031539 had a related patch set uploaded (by Krinkle; author: Krinkle):

[mediawiki/core@master] mediawiki.router: Document as module instead of public class

https://gerrit.wikimedia.org/r/1031539

Change #1031539 merged by jenkins-bot:

[mediawiki/core@master] mediawiki.router: Document as module instead of public class

https://gerrit.wikimedia.org/r/1031539