Page MenuHomePhabricator

Page issues not clickable in mobile view (new parser)
Closed, ResolvedPublic2 Estimated Story PointsBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

What happens?:
Nothing

What should have happened instead?:

Screenshot_20240303_111254_Chrome.jpg (2×1 px, 285 KB)

Software version (skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

QA Results - Beta

ACStatusDetails
1T359005#9951923

QA Results - PROD

ACStatusDetails
1T359005#9988667

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Jdlrobson renamed this task from Page issues not clickable in mobile view to Page issues not clickable in mobile view (new parser).Mar 4 2024, 4:05 PM
Jdlrobson added a project: MobileFrontend.

The issue here is likely with the PageHTMLParser in MobileFrontend

ovasileva moved this task from Incoming to Current Fiscal Year on the Web-Team-Backlog board.

The following questions structured around the 5W1H model can help gather more context and understand the requirements:

  1. What are the specific issues causing page issues to be non-clickable in mobile view?
  2. Why does the problem occur specifically in the new parser environment?
  3. Who is most affected by this issue, and who has identified it?
  4. Where in the codebase should changes be made to address this issue? answered by @Jdlrobson https://phabricator.wikimedia.org/T359005#9596720
  5. When was this problem first identified, and what is the timeline for resolving it?
  6. How can the problem be systematically diagnosed to ensure a comprehensive solution?
Jdlrobson lowered the priority of this task from High to Medium.Apr 3 2024, 6:27 AM
Jdlrobson updated the task description. (Show Details)

The issue here appears to be with the function PageHTMLParser::getLeadSectionElement - which does not return the lead section.

Change #1043313 had a related patch set uploaded (by Kimberly Sarabia; author: Kimberly Sarabia):

[mediawiki/skins/MinervaNeue@master] WIP: Add detailed console logs for debugging

https://gerrit.wikimedia.org/r/1043313

Change #1043832 had a related patch set uploaded (by Kimberly Sarabia; author: Kimberly Sarabia):

[mediawiki/skins/MinervaNeue@master] fix: Ensure proper initialization and execution

https://gerrit.wikimedia.org/r/1043832

Change #1043832 abandoned by Kimberly Sarabia:

[mediawiki/skins/MinervaNeue@master] fix: Ensure proper initialization and execution

Reason:

need to squash

https://gerrit.wikimedia.org/r/1043832

Change #1043850 had a related patch set uploaded (by Kimberly Sarabia; author: Kimberly Sarabia):

[mediawiki/skins/MinervaNeue@master] fix: Ensure proper init and execution timing

https://gerrit.wikimedia.org/r/1043850

Change #1043313 abandoned by Kimberly Sarabia:

[mediawiki/skins/MinervaNeue@master] WIP: Add detailed console logs for debugging

Reason:

redoing in another patch

https://gerrit.wikimedia.org/r/1043313

Test wiki created on Patch demo by KSarabia-WMF using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/8d10b8ca0a/w

Test wiki on Patch demo by KSarabia-WMF using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/8d10b8ca0a/w/

Hey Kim here's how I got setup locally!

I disabled the MobileFrontendContentProvider.

I created http://localhost:8888/wiki/Template:T359005 with the following text:

{| class="box-More_citations_needed plainlinks metadata ambox ambox-content ambox-Refimprove" style="background: red; color: white; width: 100%;"
|-
|Improve me!
|-
|<span class="mbox-text">improve me now!</span>
|}

I created a page T359005 with text:

{{T359005}}

With ParserMigration extension installed the banner is not clickable. Without it is.

Change #1044746 had a related patch set uploaded (by Kimberly Sarabia; author: Kimberly Sarabia):

[mediawiki/extensions/MobileFrontend@master] Fix banner issue with Parsoid parser opt-in

https://gerrit.wikimedia.org/r/1044746

Change #1043850 abandoned by Kimberly Sarabia:

[mediawiki/skins/MinervaNeue@master] fix: Ensure proper init and execution timing

Reason:

This fix just created a false positive. See new patch in same ticket.

https://gerrit.wikimedia.org/r/1043850

ovasileva raised the priority of this task from Medium to High.Jun 17 2024, 5:18 PM
ovasileva subscribed.

Marking as high so that we can note this is committed work. Will pick up in the following sprint.

Change #1044746 merged by jenkins-bot:

[mediawiki/extensions/MobileFrontend@master] Fix banner issue with Parsoid parser opt-in

https://gerrit.wikimedia.org/r/1044746

Jdlrobson lowered the priority of this task from High to Low.
Jdlrobson updated the task description. (Show Details)

Test Result - Beta

Status: ✅ PASS
Environment: Beta
OS: macOS Sonoma 14.5
Browser: Chrome 126
Device: MBA
Emulated Device: NA

Test Artifact(s):

Test Steps
  1. Opt into new parser on https://en.wikipedia.org/wiki/Special:Preferences
  2. visit https://en.m.wikipedia.org/wiki/Animation or https://en.m.wikipedia.beta.wmflabs.org/wiki/Cambridge_Five
  3. click banner
LightDark
2024-07-03_14-14-57.mp4.gif (680×314 px, 120 KB)
2024-07-03_14-15-55.mp4.gif (732×338 px, 158 KB)
GMikesell-WMF assigned this task to ovasileva.
GMikesell-WMF updated the task description. (Show Details)

Test Result - PROD

Status: ✅ PASS
Environment: PROD
OS: macOS Sonoma 14.5
Browser: Chrome 126
Device: MBA
Emulated Device: NA

Test Artifact(s):

Test Steps
  1. Opt into new parser on https://en.wikipedia.org/wiki/Special:Preferences
  2. visit https://en.m.wikipedia.org/wiki/Animation or https://en.m.wikipedia.beta.wmflabs.org/wiki/Cambridge_Five
  3. click banner
LightDark
2024-07-16_16-26-01.mp4.gif (704×328 px, 107 KB)
2024-07-16_16-25-13.mp4.gif (704×328 px, 145 KB)