Page MenuHomePhabricator
Create Task
Maniphest T359038

Script to migrate current GrowthExperiments config schemas into new structure
Closed, ResolvedPublic5 Estimated Story Points
Actions

Description

Since Growth team has decided to split the current configuration in Special:EditGrowthConfig into (4) themed editor pages we will need to create valid json configuration pages for these based on the existing values on each wiki. This task is to create an script that facilitates that work.

Acceptance criteria
The script should:

  • Copy all the existing configuration options located in MediaWiki:NewcomerTasks.json into MediaWiki:GrowthExperimentsSuggestedEdits.json
  • Copy the existing GEInfoboxTemplates located in MediaWiki:GrowthExperimentsConfig.json to MediaWiki:GrowthExperimentsSuggestedEdits.json
  • Copy the homepage related configurations from MediaWiki:GrowthExperimentsConfig.json to MediaWiki:GrowthExperimentsHomepage.json
  • Copy the help panel related configurations from MediaWiki:GrowthExperimentsConfig.json to MediaWiki:GrowthExperimentsHelpPanel.json
  • Copy the mentorship related configurations from MediaWiki:GrowthExperimentsConfig.json to MediaWiki:GrowthExperimentsMentorship.json

Open questions

  • Another wrinkle found while analyzing current EditGrowthConfig data schemas is that some information is captured with unconventional controls. An example of this are the radio buttons used for capturing Are mentorship features enabled? which are mapped to a boolean data type while the conventional control for boolean is a checkbox. Maybe this data migration and others can be considered while developing this script.
    • No data migration is required within this script. All data will be displayed with the conventional default control.
  • Do we need to preserve the history or relate the old and new pages in some way?

Details

SubjectRepoBranchLines +/-
Config: display a custom message on validation errorsmediawiki/extensions/GrowthExperimentsmaster+16 -0
Config: add maintenance script to migrate to CC2.0mediawiki/extensions/GrowthExperimentsmaster+306 -2
Customize query in gerrit

Related Objects
Search...

Event Timeline

Sgs created this task.Mar 4 2024, 10:31 AM
Restricted Application added a project: Growth-Team. · View Herald TranscriptMar 4 2024, 10:31 AM
Sgs moved this task from Backlog to Migrate Special:EditGrowthConfig on the MediaWiki-extensions-CommunityConfiguration board.Mar 4 2024, 10:31 AM
Sgs added a parent task: T355317: Community configuration 2.0: migrate Special:EditGrowthConfig.Mar 4 2024, 1:25 PM
Sgs moved this task from Inbox to Up Next on the Growth-Team board.Mar 14 2024, 6:23 PM
Sgs triaged this task as Medium priority.Mar 19 2024, 2:07 PM
KStoller-WMF set the point value for this task to 5.Mar 19 2024, 2:33 PM
Sgs updated the task description. (Show Details)Apr 24 2024, 5:02 PM
Sgs raised the priority of this task from Medium to High.Apr 29 2024, 7:52 AM
Sgs updated the task description. (Show Details)Apr 29 2024, 5:49 PM
Sgs updated the task description. (Show Details)
KStoller-WMF moved this task from Up Next to Sprint 13 (Growth Team) on the Growth-Team board.Apr 30 2024, 4:50 PM
KStoller-WMF edited projects, added Growth-Team (Sprint 13 (Growth Team)); removed Growth-Team.
Urbanecm_WMF mentioned this in T360472: Growth features: Migrate Help panel settings from Special:EditGrowthConfig to Community configuration 2.0.May 2 2024, 9:31 PM
Urbanecm_WMF mentioned this in T364053: Help panel does not process `GEHelpPanelPostOnTop` correctly when CommunityConfiguration extension is used.May 2 2024, 10:16 PM
Sgs mentioned this in T355317: Community configuration 2.0: migrate Special:EditGrowthConfig.May 3 2024, 9:27 AM
Sgs claimed this task.May 6 2024, 9:28 AM
Sgs moved this task from Incoming to Doing on the Growth-Team (Sprint 13 (Growth Team)) board.
gerritbot added a comment.May 8 2024, 11:39 AM

Change #1029167 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):

[mediawiki/extensions/GrowthExperiments@master] [WIP] Config: add maintenance script to migrate to CC2.0

https://gerrit.wikimedia.org/r/1029167

gerritbot added a project: Patch-For-Review.May 8 2024, 11:39 AM
Sgs added a subscriber: Urbanecm_WMF.May 9 2024, 3:08 PM
In T364053#9765565, @Urbanecm_WMF wrote:

We definitely should migrate the actually stored on-wiki config into the new format. This should be handled as part of T359038: Script to migrate current GrowthExperiments config schemas into new structure (or possibly, a follow-up task to that one, as the description states no data migration should happen). Then, when reading the configuration, we would need to convert the new configuration format into the old one, so that reads would work intact.

My initial thought was to check for config data validity against the provided schemas within the script, but according to your comment I understand you are suggesting to skip validity? I think the description note No data migration is required within this script. All data will be displayed with the conventional default control. was written without accounting for this particular problem. What do you think? Should we skip validity checks or solve first T364053 in a way it does not produce validation errors? cc @Urbanecm_WMF

Sgs edited projects, added Growth-Team (Sprint 14 (Growth Team)); removed Growth-Team (Sprint 13 (Growth Team)).May 14 2024, 3:47 PM
Sgs moved this task from Incoming to Doing on the Growth-Team (Sprint 14 (Growth Team)) board.
Urbanecm_WMF added a comment.May 14 2024, 4:38 PM

I was not suggesting to skip validation; I was just confused, as the description mentioned "no data migration". Transferring the data into the valid format makes sense to me.

Sgs moved this task from Doing to Code Review on the Growth-Team (Sprint 14 (Growth Team)) board.May 17 2024, 4:16 PM
Sgs updated the task description. (Show Details)May 21 2024, 5:13 PM
Sgs added a comment.May 21 2024, 5:16 PM
In T359038#9796107, @Urbanecm_WMF wrote:

I was not suggesting to skip validation; I was just confused, as the description mentioned "no data migration". Transferring the data into the valid format makes sense to me.

Indeed, I wrote that note update optimistically. The script takes in account the GrowthExperiments provider special casings, that includes computed properties, data transforms and override hyphened top level properties.

Any thoughts about the open question Do we need to preserve the history or relate the old and new pages in some way?

Sgs mentioned this in T365726: Decide how to handle an option that exists only in some wikis.May 23 2024, 3:23 PM
gerritbot added a comment.May 23 2024, 3:25 PM

Change #1035473 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):

[operations/mediawiki-config@master] [GrowthExperiments] Disable personalized praise in eswiki labs

https://gerrit.wikimedia.org/r/1035473

Michael mentioned this in T365612: Growth features: Add Levelling up related configuration.May 24 2024, 1:07 PM
Michael added a subtask: T365612: Growth features: Add Levelling up related configuration.
Sgs moved this task from Code Review to Blocked / Needs Work on the Growth-Team (Sprint 14 (Growth Team)) board.May 27 2024, 9:42 AM
Sgs moved this task from Blocked / Needs Work to Doing on the Growth-Team (Sprint 14 (Growth Team)) board.Tue, May 28, 12:58 PM
Sgs moved this task from Sprint 14 (Growth Team) to Sprint 15 (Growth Team) on the Growth-Team board.Tue, May 28, 4:40 PM
Sgs edited projects, added Growth-Team (Sprint 15 (Growth Team)); removed Growth-Team (Sprint 14 (Growth Team)).
Sgs moved this task from Incoming to Blocked / Needs Work on the Growth-Team (Sprint 15 (Growth Team)) board.Tue, May 28, 4:45 PM
KStoller-WMF mentioned this in Growth-Team (Sprint 15 (Growth Team)).Tue, May 28, 10:20 PM
Sgs moved this task from Blocked / Needs Work to Doing on the Growth-Team (Sprint 15 (Growth Team)) board.Wed, May 29, 10:28 AM
Sgs mentioned this in T366168: CommunityConfiguration\Store\WikiPage\Writer stores empty arrays and does not order config keys.Wed, May 29, 12:05 PM
Sgs moved this task from Doing to Code Review on the Growth-Team (Sprint 15 (Growth Team)) board.Wed, May 29, 12:53 PM
gerritbot added a comment.Fri, May 31, 2:00 PM

Change #1029167 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Config: add maintenance script to migrate to CC2.0

https://gerrit.wikimedia.org/r/1029167

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.8; 2024-06-04).Fri, May 31, 3:00 PM
Urbanecm_WMF moved this task from Code Review to Test in Production on the Growth-Team (Sprint 15 (Growth Team)) board.Tue, Jun 4, 11:28 AM

The script will be tested during deployment (T364892: Enable CommunityConfiguration on all beta wikis with GrowthExperiments, T360954: Deploy CommunityConfiguration to testwiki).

Urbanecm_WMF removed a project: Patch-For-Review.Tue, Jun 4, 11:28 AM
gerritbot added a comment.Tue, Jun 4, 2:20 PM

Change #1038817 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):

[mediawiki/extensions/GrowthExperiments@master] Config: display a custom message on validation errors

https://gerrit.wikimedia.org/r/1038817

gerritbot added a project: Patch-For-Review.Tue, Jun 4, 2:20 PM
JFernandez-WMF closed subtask T365612: Growth features: Add Levelling up related configuration as Resolved.Tue, Jun 4, 4:32 PM
Urbanecm_WMF added a parent task: T360571: CommunityConfiguration Extension Release Plan.Wed, Jun 5, 11:37 AM
gerritbot added a comment.Wed, Jun 5, 5:50 PM

Change #1038817 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Config: display a custom message on validation errors

https://gerrit.wikimedia.org/r/1038817

ReleaseTaggerBot edited projects, added MW-1.43-notes (1.43.0-wmf.9; 2024-06-11); removed MW-1.43-notes (1.43.0-wmf.8; 2024-06-04).Wed, Jun 5, 6:00 PM
Urbanecm_WMF closed this task as Resolved.Wed, Jun 12, 3:37 PM

Script was tested during the beta/testwiki rollout, it works fine.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL