Page MenuHomePhabricator
Create Task
Maniphest T359221

Parsoid's TOC handling needs to deal with HTML-returning components (exts, SPTs, parser funcs returning HTML) consistently
Open, MediumPublic
Actions

Description

From T355092#9483046, Parsoid needs to handle sections defined in HTML-returning components (ex: special page transclusions, parser functions returning html) just like it deals with extensions. T355092 only dealt with extensions.

This is an edge case, but needs to be handled.

Related Objects
Search...

StatusSubtypeAssignedTask
 OpenReleaseNoneT84936 Release VisualEditor-MediaWiki as "1.0"
 OpenNoneT50429 [Epic] Support editing parts of a page in VisualEditor-MediaWiki
 OpenNoneT54365 Explore performance gains from progressive (JIT?) de-alienation in VisualEditor
 OpenNoneT396539 Introduce a way to edit a span of text from within read mode
 OpenNoneT385558 Improve copy and paste from read mode to VE
 OpenNoneT174303 Copy-pasting linked ISBN numbers from view mode HTML into VisualEditor inserts wikitext links to Special:BookSources (it should turn them into magic links?)
 OpenFeatureNoneT54091 The read HTML should have hinting to allow full DOM copying (as opposed to just rich copying) from read mode into VE surfaces
 OpenNoneT55784 [EPIC] Use Parsoid HTML for all page views
 OpenNoneT272987 [EPIC] Parsoid read views for DiscussionTools
 ResolvedcscottT269630 Parsoid should support section editing links
 ResolvedcscottT297840 Populate ParserCache with Parsoid output as a post-edit hook
 OpenNoneT419048 Use Parsoid as default wikitext parser in MW 1.47
 StalledNoneT403531 add remaining SLIs to Pyrra dashboard
 OpenNoneT409815 SLI: MediaWiki system load
 OpenNoneT393717 Put lints in ParserOutput/RefreshLinksJob
 OpenBUG REPORTNoneT393682 Wikifunctions fragments that trigger errors and try to put the page in a tracking category show it at the bottom of the view page, but the pages using the fragment do not appear on the category page
 OpenNoneT393716 [EPIC] RefreshLinksJob should use Parsoid-generated metadata
 OpenNoneT310511 Metadata comparison testing between Parsoid and the legacy parser
 OpenNoneT331483 Resolve differences between Parsoid & legacy parser TOC metadata output for template, extension, and parser-function generated content
 OpencscottT359221 Parsoid's TOC handling needs to deal with HTML-returning components (exts, SPTs, parser funcs returning HTML) consistently

Event Timeline

ssastry created this task.Mar 5 2024, 10:03 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 5 2024, 10:03 PM
ssastry mentioned this in T355092: Parsoid / legacy parser disagree whether to include extension content in TOC.Mar 5 2024, 10:04 PM
ssastry added a parent task: T331483: Resolve differences between Parsoid & legacy parser TOC metadata output for template, extension, and parser-function generated content.Mar 6 2024, 5:49 PM
ssastry moved this task from Needs Triage to Bugs & Crashers on the Parsoid board.Mar 8 2024, 9:40 PM
cscott subscribed.Apr 29 2024, 3:36 PM
ABreault-WMF merged a task: T372616: Section edit links added to H4s in transcluded Special:RecentChangesLinked.Aug 16 2024, 2:39 PM
ABreault-WMF added subscribers: Samwilson, matmarex.
ABreault-WMF merged a task: T387169: Omit sections from special page transclusions from TOC.Feb 25 2025, 3:54 PM
ABreault-WMF subscribed.
ABreault-WMF merged a task: T387582: Visual diff for TOC in special page transclusions.Feb 28 2025, 5:59 PM
ABreault-WMF added a subscriber: ihurbain.
ABreault-WMF added a comment.Feb 28 2025, 6:02 PM

In T387582, @ihurbain raises that maybe we can have a broader discussion about what belongs in the TOC from transcluded content, rather than just mimicking the limitations of the legacy parser

MSantos added a project: Content-Platform-Team (Work In Progress).Aug 28 2025, 2:46 PM
cscott added a comment.Sep 29 2025, 3:33 PM

Usually we do "strip kill markers" in the legacy parser, which just removes non-wikitext content entirely.

MSantos assigned this task to cscott.Oct 16 2025, 2:18 PM
MSantos edited projects, added: Parsoid-Read-Views (Small Size Wikipedias); removed: Parsoid-Read-Views (Phase 3 - Main namespace of officewiki / mediawiki.org renders with Parsoid).
MSantos moved this task from Backlog to Q1 FY26-27 on the Content-Platform-Team (Work In Progress) board.
MSantos added a project: OKR-Work.Oct 20 2025, 2:07 PM
MSantos triaged this task as Low priority.Jan 8 2026, 3:08 PM
MSantos raised the priority of this task from Low to Medium.
HakanIST mentioned this in T426746: TOC not rendered when heading tags are generated in module/template.May 19 2026, 2:39 PM
cscott added a comment.May 28 2026, 3:34 PM

A quick test seems to indicate that both Parsoid and the legacy parser use the .textContent of the HTML included in the heading to generate the TOC text (and presumably ID): https://en.wikipedia.org/w/index.php?title=User_talk:Cscott/Toc&oldid=1356567473

cscott added a comment.Jun 1 2026, 3:34 PM

Special page transclusions can generate headings which the legacy Parser doesn't include in the TOC, which means it doesn't generate section edit links, div wrappers, etc.

One example:
https://igl.wikipedia.org/w/index.php?title=Wikip%C3%ADdiya:Uch%E1%BB%8Dl%E1%BB%8D_Wikimwdia_%E1%BB%8Djane_ileyi_chakadu

ABreault-WMF merged a task: T434168: Transcluding special page in Parsoid creates TOC.Thu, Aug 6, 2:17 PM
ABreault-WMF added a subscriber: Pppery.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits