Page MenuHomePhabricator

Replace usage of wfGetDB() in ResourceLoader before the 1.42 cut so it can be hard-deprecated
Closed, ResolvedPublic

Description

It's the only place in core that uses it. There is a patch for it already but it's failing in tests.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 1003462 had a related patch set uploaded (by Ladsgroup; author: Jforrester):

[mediawiki/core@master] [WIP] ResourceLoader: Migrate call from wfGetDB to ICP

https://gerrit.wikimedia.org/r/1003462

Change 1003462 abandoned by Jforrester:

[mediawiki/core@master] [WIP] ResourceLoader: Migrate call from wfGetDB to ICP

Reason:

Aha, thanks!

https://gerrit.wikimedia.org/r/1003462

Change 1009595 had a related patch set uploaded (by Jforrester; author: Mainframe98):

[mediawiki/core@master] [WIP] ResourceLoader: use ICP

https://gerrit.wikimedia.org/r/1009595

Change 1009849 had a related patch set uploaded (by Krinkle; author: Krinkle):

[mediawiki/core@master] ResourceLoader: Add missing `@group ResourceLoader` to various cases

https://gerrit.wikimedia.org/r/1009849

Change 1009850 had a related patch set uploaded (by Krinkle; author: Krinkle):

[mediawiki/core@master] ResourceLoader: Avoid Database connection in unit tests

https://gerrit.wikimedia.org/r/1009850

Change 1009851 had a related patch set uploaded (by Krinkle; author: Krinkle):

[mediawiki/core@master] ResourceLoader: Add preload for foreign WikiModule title info

https://gerrit.wikimedia.org/r/1009851

Change 1009849 merged by jenkins-bot:

[mediawiki/core@master] ResourceLoader: Add missing `@group ResourceLoader` to various cases

https://gerrit.wikimedia.org/r/1009849

Note: [Wikitech-l] MediaWiki 1.42-alpha will be branched as a beta on 9 April 2024

Krinkle triaged this task as Medium priority.

Change 1009595 merged by jenkins-bot:

[mediawiki/core@master] ResourceLoader: Migrate wfGetDB call to ICP and move to WikiModule

https://gerrit.wikimedia.org/r/1009595

Change 1009851 merged by jenkins-bot:

[mediawiki/core@master] ResourceLoader: Add preload for foreign WikiModule title info

https://gerrit.wikimedia.org/r/1009851