| stjn | |
| Mar 23 2024, 5:03 PM |
| F49499190: screenshot 281.png | |
| Tue, Apr 30, 7:08 PM |
| F49499189: screenshot 280.png | |
| Tue, Apr 30, 7:08 PM |
Steps to replicate the issue (include links if applicable):
Compare:
Italic and smaller font is done by styles in Russian Wikipedia, but tag markers also lack parentheses () that are added via CSS. They should have them.
| AC | Status | Details |
|---|---|---|
| 1 | ❓ | T360843#9759247 |
Change #1013700 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):
[mediawiki/core@master] Special:NewPages should generate markup consistent with other pager pages
Change #1015656 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):
[mediawiki/skins/MinervaNeue@master] Style Special:NewPage consistently with Special:RecentChanges
Right now the NewPages HTML is inconsistent with other pages that look similar. There are two issues here that need to be fixed in core for this to be styled correctly in Minerva and consistent with other pages:
/** @var bool Whether to group items by date */ public $mGroupByDate = true;
Change #1013700 merged by jenkins-bot:
[mediawiki/core@master] Special:NewPages should generate markup consistent with other pager pages
Status: ❓
Environment: beta
OS: macOS Sonoma
Browser: Chrome
Device: MBA
Emulated Device:NA
Test Artifact(s):
@Jdlrobson, the task description isn't very clear as to what I should be looking for. Please see the two images in beta. If these are a pass feel free to move to ready for signoff and resolve, also please leave a comment/screenshot annotation that clarifies what we should be looking for specifically when we test this in production.
Seems like tag markers are still displayed without parentheses, @Jdlrobson are you sure it is resolved?
Thanks for the ping! I was mistaken. Looks like we fixed the markup but not the styles:
@jsn.sherman will review https://gerrit.wikimedia.org/r/c/mediawiki/skins/MinervaNeue/+/1015656 shortly
ack, removing the deploy tag to make clearer that this wasn't resolved in that release.
Thanks @Jdlrobson, from the comments it looks like this will need to be retested again when the new patch is deployed in beta. I will remove the Verified tag and we will remove it from the deployment ticket table.