Page MenuHomePhabricator
Create Task
Maniphest T361031

Add HTML output tests for all HTMLForm fields that support Codex
Open, MediumPublic5 Estimated Story Points
Actions

Description

Each HTMLFormField subclass should have a test that acts like a snapshot test:

  • Constructs the field with certain parameters
  • Asserts the correct HTML output for each display format

Let's start by adding these for the fields that have already been migrated to Codex, and then the other fields can have tests added before / at the same time that Codex support is added to them.

(Then later, write tests for other fields)

Details

SubjectRepoBranchLines +/-
tests: Add HTML output tests for HTMLTextFieldmediawiki/coremaster+57 -0
tests: Add HTML output tests for HTMLButtonFieldmediawiki/coremaster+73 -0
tests: Add HTML output tests for HTMLRadioFieldmediawiki/coremaster+114 -0
tests: Add HTML output tests for HTMLCheckFieldmediawiki/coremaster+92 -0
tests: Add test case class for HTMLFormField HTML output testsmediawiki/coremaster+69 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

Catrope created this task.Mar 26 2024, 4:31 PM
Catrope added a project: Design-System-Team.
Catrope moved this task from Inbox to Up Next on the Design-System-Team board.
CCiufo-WMF renamed this task from Add HTML output tests for all fields that support Codex to Add HTML output tests for all HTMLForm fields that support Codex.Mar 26 2024, 7:11 PM
CCiufo-WMF triaged this task as Medium priority.Mon, Apr 1, 1:54 PM
CCiufo-WMF raised the priority of this task from Medium to High.Mon, Apr 1, 4:59 PM
Catrope set the point value for this task to 5.Mon, Apr 1, 5:24 PM
Catrope moved this task from Up Next to DST-Sprint-20 (2024-04-01 to 2024-04-12) on the Design-System-Team board.
Catrope edited projects, added Design-System-Team (DST-Sprint-20 (2024-04-01 to 2024-04-12)); removed Design-System-Team.
Catrope claimed this task.Tue, Apr 2, 5:41 PM
gerritbot added a comment.Mon, Apr 8, 4:49 PM

Change #1017907 had a related patch set uploaded (by Catrope; author: Catrope):

[mediawiki/core@master] tests: Add test case class for HTMLFormField HTML output tests

https://gerrit.wikimedia.org/r/1017907

gerritbot added a project: Patch-For-Review.Mon, Apr 8, 4:49 PM

Change #1017908 had a related patch set uploaded (by Catrope; author: Catrope):

[mediawiki/core@master] tests: Add HTML output tests for HTMLButtonField

https://gerrit.wikimedia.org/r/1017908

gerritbot added a comment.Mon, Apr 8, 4:54 PM

Change #1017909 had a related patch set uploaded (by Catrope; author: Catrope):

[mediawiki/core@master] tests: Add HTML output tests for HTMLCheckField

https://gerrit.wikimedia.org/r/1017909

gerritbot added a comment.Mon, Apr 8, 4:56 PM

Change #1017910 had a related patch set uploaded (by Catrope; author: Catrope):

[mediawiki/core@master] tests: Add HTML output tests for HTMLRadioField

https://gerrit.wikimedia.org/r/1017910

gerritbot added a comment.Mon, Apr 8, 4:57 PM

Change #1017911 had a related patch set uploaded (by Catrope; author: Catrope):

[mediawiki/core@master] tests: Add HTML output tests for HTMLTextField

https://gerrit.wikimedia.org/r/1017911

Catrope updated the task description. (Show Details)Mon, Apr 8, 4:57 PM
Jdforrester-WMF updated the task description. (Show Details)Mon, Apr 8, 5:44 PM
gerritbot added a comment.Mon, Apr 8, 5:59 PM

Change #1017907 merged by jenkins-bot:

[mediawiki/core@master] tests: Add test case class for HTMLFormField HTML output tests

https://gerrit.wikimedia.org/r/1017907

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.26; 2024-04-09).Mon, Apr 8, 6:00 PM
gerritbot added a comment.Mon, Apr 8, 6:25 PM

Change #1017909 merged by jenkins-bot:

[mediawiki/core@master] tests: Add HTML output tests for HTMLCheckField

https://gerrit.wikimedia.org/r/1017909

gerritbot added a comment.Mon, Apr 8, 6:26 PM

Change #1017908 merged by jenkins-bot:

[mediawiki/core@master] tests: Add HTML output tests for HTMLButtonField

https://gerrit.wikimedia.org/r/1017908

gerritbot added a comment.Mon, Apr 8, 6:28 PM

Change #1017910 merged by jenkins-bot:

[mediawiki/core@master] tests: Add HTML output tests for HTMLRadioField

https://gerrit.wikimedia.org/r/1017910

Jdforrester-WMF updated the task description. (Show Details)Mon, Apr 8, 7:55 PM
Catrope moved this task from Committed to In Progress on the Design-System-Team (DST-Sprint-20 (2024-04-01 to 2024-04-12)) board.Mon, Apr 8, 8:01 PM
CCiufo-WMF removed Catrope as the assignee of this task.Mon, Apr 15, 4:53 PM
CCiufo-WMF lowered the priority of this task from High to Medium.
CCiufo-WMF moved this task from DST-Sprint-20 (2024-04-01 to 2024-04-12) to Up Next on the Design-System-Team board.
CCiufo-WMF edited projects, added Design-System-Team; removed Design-System-Team (DST-Sprint-20 (2024-04-01 to 2024-04-12)).
CCiufo-WMF moved this task from Up Next to DST-Sprint-21 (2024-04-15 to 2024-04-26) on the Design-System-Team board.Mon, Apr 15, 5:28 PM
CCiufo-WMF edited projects, added Design-System-Team (DST-Sprint-21 (2024-04-15 to 2024-04-26)); removed Design-System-Team.
DTorsani-WMF moved this task from DST-Sprint-21 (2024-04-15 to 2024-04-26) to Up Next on the Design-System-Team board.Mon, Apr 29, 4:55 PM
DTorsani-WMF edited projects, added Design-System-Team; removed Design-System-Team (DST-Sprint-21 (2024-04-15 to 2024-04-26)).
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL