CodexHTMLForm should feature a max-width for Codex components
Closed, ResolvedPublic1 Estimated Story Points
Actions

Assigned To

Authored By

	Volker_E
	Thu, Apr 4, 8:06 AM

Description

Background

Unlike OOUIHTMLForm we don't have max-width on our new Codex components, which is a weird user-facing presentation.
We should add max-width to components, or even the whole codex-htmlform selector.

In Codex we currently have put out a recommendation of “maximum width of size-3200 (equivalent to 512px in the default Codex theme)”

Open question

For the whole form, should we go for size-3200 as well as max-width, or should we consider the widest size-5600 instead?

@DTorsani-WMF came up with a comparison in T362270 and we've decided to go with a new size-4000.

Acceptance criteria

Set max-width on ~~either~~ CodexHTMLForm ~~in special.less or on Special:Block specific stylesheet~~

Details

	Subject	Repo	Branch	Lines +/-
	CodexHTMLForm: Use maximum width for CodexHTMLForm	mediawiki/core	master	+2 -0

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
In Progress	bmartinezcalvo	T355148 [EPIC] Multiblocks
Resolved	Volker_E	T361783 CodexHTMLForm should feature a max-width for Codex components
Resolved	DTorsani-WMF	T362270 Add new spacing token of 40rem

Event Timeline

Volker_E created this task.Thu, Apr 4, 8:06 AM

Restricted Application added a project: Design-System-Team. · View Herald TranscriptThu, Apr 4, 8:06 AM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

This captures the problems with both size tokens quite well:

I think in a Vector 2022 context, size-3200 is too small. What you think @DTorsani-WMF?

Change #1017172 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/core@master] CodexHTMLForm: Use maximum width for CodexHTMLForm

https://gerrit.wikimedia.org/r/1017172

gerritbot added a project: Patch-For-Review.Fri, Apr 5, 1:16 AM

CCiufo-WMF moved this task from Inbox to Triaging on the Design-System-Team board.Fri, Apr 5, 2:22 PM

@Volker_E I would agree that it feels a bit small, but the next one up, size-5600, feels too big, and I think the smaller one works better for character length in one line. Maybe it is time for a new sizing token?

I agree with your statement @DTorsani-WMF. Would you make a proposal (with my help in testing on Special:Block, as already shared we had somewhat arbitray 50em on OOUI) and discuss it in next design sync?

@Volker_E yes I can work on a proposal to present at design sync.

CCiufo-WMF added a parent task: T359012: Migrate Special:Block to CodexHTMLForm.Tue, Apr 9, 7:31 PM

CCiufo-WMF edited parent tasks, added: T355148: [EPIC] Multiblocks; removed: T359012: Migrate Special:Block to CodexHTMLForm.

Noting here that this task will address this request per our conversation in design sync 2024/04/10.

CCiufo-WMF added a subtask: T362270: Add new spacing token of 40rem.Thu, Apr 11, 3:06 PM

CCiufo-WMF moved this task from Triaging to Up Next on the Design-System-Team board.

Volker_E renamed this task from CodexHTMLForm for Multiblocks should feature a max-width for Codex components to CodexHTMLForm should feature a max-width for Codex components.Thu, Apr 11, 5:18 PM

Volker_E updated the task description. (Show Details)

CCiufo-WMF triaged this task as Medium priority.Mon, Apr 15, 3:22 PM

CCiufo-WMF set the point value for this task to 1.Mon, Apr 15, 5:29 PM

CCiufo-WMF moved this task from Up Next to DST-Sprint-21 (2024-04-15 to 2024-04-26) on the Design-System-Team board.

CCiufo-WMF edited projects, added Design-System-Team (DST-Sprint-21 (2024-04-15 to 2024-04-26)); removed Design-System-Team.

egardner closed subtask T362270: Add new spacing token of 40rem as Resolved.Wed, Apr 17, 10:26 PM

Change #1017172 merged by LWatson:

[mediawiki/core@master] CodexHTMLForm: Use maximum width for CodexHTMLForm

https://gerrit.wikimedia.org/r/1017172

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.2; 2024-04-23).Fri, Apr 19, 3:00 PM

Volker_E closed this task as Resolved.Wed, Apr 24, 7:59 AM

Volker_E claimed this task.