Maniphest T361933

Community configuration: Special:CommunityConfiguration/PROVIDER should display the provider name in the header instead of provider ID
Closed, ResolvedPublic1 Estimated Story Points
Actions

Assigned To

Authored By

	Urbanecm_WMF
	Apr 5 2024, 11:49 AM

Description

With the T360473 patch loaded, http://localhost:8080/wiki/Special:CommunityConfiguration/GrowthHomepage looks like this:

In the headline, it says "Editing 'GrowthHomepage'", where GrowthHomepage is the technical ID under which the provider is registered. This shouldn't be displayed to the user – instead, we should be displaying the provider name. This issue is not visible without that patch, as for Mentorship, the ID and the name is the same.

Note that part of MediaWiki-extensions-CommunityConfiguration codebase uses "provider name" with the now-wrong meaning (referring to the ID rather than the actual human readable name). Please see T361931 for explanation.

Within this task, we should also remove the apostrophes.

Acceptance Criteria:

Fix the title
Review for other occurrences of this problem

Details

Related Changes in Gerrit:

Subject	Repo	Branch	Lines +/-
Drop the apostrophes around the localized title of the config editor	mediawiki/extensions/CommunityConfiguration	master	+2 -2
Show the provider name in the editor title, not the Id	mediawiki/extensions/CommunityConfiguration	master	+17 -14
Rename parameter and private field providerName to providerId	mediawiki/extensions/CommunityConfiguration	master	+4 -4

Customize query in gerrit

Related Objects

Mentioned In: T358335: Allow to display informational header text in the editor
T362728: [QA task] Community Configuration - testing in production
T361324: [QA task] Community Configuration UI evaluation
Mentioned Here: T362728: [QA task] Community Configuration - testing in production
T360473: Growth features: Migrate Homepage settings from Special:EditGrowthConfig to Community configuration 2.0
T361931: CommunityConfiguration: Use a single term to describe a provider ID

Event Timeline

Urbanecm_WMF created this task.Apr 5 2024, 11:49 AM

Restricted Application added a project: Growth-Team. · View Herald TranscriptApr 5 2024, 11:49 AM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Urbanecm_WMF moved this task from Inbox to Estimated tasks backlog on the Growth-Team board.Apr 5 2024, 11:50 AM

Urbanecm_WMF renamed this task from Community configuration: Special:CommunityConfiguration/PROVIDER should use the provider name in the description, not provider ID to Community configuration: Special:CommunityConfiguration/PROVIDER should display the provider name in the header instead of provider ID.Apr 6 2024, 12:09 PM

Urbanecm_WMF updated the task description. (Show Details)

Urbanecm_WMF triaged this task as High priority.Apr 6 2024, 1:40 PM

Urbanecm_WMF moved this task from Backlog to Support non-Growth use cases on the MediaWiki-extensions-CommunityConfiguration board.

Urbanecm updated the task description. (Show Details)Apr 6 2024, 11:02 PM

Urbanecm_WMF updated the task description. (Show Details)Apr 8 2024, 8:40 AM

Urbanecm_WMF mentioned this in T361324: [QA task] Community Configuration UI evaluation .Apr 8 2024, 8:46 AM

KStoller-WMF moved this task from Estimated tasks backlog to Sprint 12 (Growth Team) on the Growth-Team board.Apr 16 2024, 4:45 PM

KStoller-WMF edited projects, added Growth-Team (Sprint 12 (Growth Team)); removed Growth-Team.

Urbanecm_WMF updated the task description. (Show Details)Apr 16 2024, 4:47 PM

KStoller-WMF set the point value for this task to 1.Apr 16 2024, 4:50 PM

KStoller-WMF updated the task description. (Show Details)

Michael claimed this task.Apr 16 2024, 5:31 PM

Michael moved this task from Incoming to Doing on the Growth-Team (Sprint 12 (Growth Team)) board.

Restricted Application added a project: User-Michael. · View Herald TranscriptApr 16 2024, 5:31 PM

Change #1020301 had a related patch set uploaded (by Michael Große; author: Michael Große):

[mediawiki/extensions/CommunityConfiguration@master] Rename parameter and private field providerName to providerId

https://gerrit.wikimedia.org/r/1020301

Change #1020302 had a related patch set uploaded (by Michael Große; author: Michael Große):

[mediawiki/extensions/CommunityConfiguration@master] Show the provider name in the editor title, not the Id

https://gerrit.wikimedia.org/r/1020302

Michael moved this task from Doing to Code Review on the Growth-Team (Sprint 12 (Growth Team)) board.Apr 16 2024, 5:59 PM

Change #1020301 merged by jenkins-bot:

[mediawiki/extensions/CommunityConfiguration@master] Rename parameter and private field providerName to providerId

https://gerrit.wikimedia.org/r/1020301

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.2; 2024-04-23).Apr 16 2024, 7:00 PM

Urbanecm_WMF moved this task from Code Review to QA on the Growth-Team (Sprint 12 (Growth Team)) board.Apr 18 2024, 8:57 AM

Change #1020302 merged by jenkins-bot:

[mediawiki/extensions/CommunityConfiguration@master] Show the provider name in the editor title, not the Id

https://gerrit.wikimedia.org/r/1020302

Can be seen on https://es.wikipedia.beta.wmflabs.org/wiki/Especial:CommunityConfiguration/GrowthHomepage?uselang=en

It now says "Editing 'Newcomer Homepage'" in English and something Spanish in Spanish, instead of always just saying "Editing 'GrowthHomepage'".

In T361933#9727431, @Michael wrote:

Can be seen on https://es.wikipedia.beta.wmflabs.org/wiki/Especial:CommunityConfiguration/GrowthHomepage?uselang=en

It now says "Editing 'Newcomer Homepage'" in English and something Spanish in Spanish, instead of always just saying "Editing 'GrowthHomepage'".

@Michael - the task description says:

Within this task, we should also remove the apostrophes.

The apostrophes are still present in the title when he form is edited (the screenshot also shows that the apostrophes are not present in the Save box) :

Screen Shot 2024-04-18 at 5.12.43 PM.png (1×1 px, 229 KB)

In T361933#9728493, @Etonkovidova wrote:

In T361933#9727431, @Michael wrote:

@Michael - the task description says:

Within this task, we should also remove the apostrophes.

The apostrophes are still present in the title when he form is edited

I totally missed that line. Thank you for pointing it out! Will fix right away.

Change #1021872 had a related patch set uploaded (by Michael Große; author: Michael Große):

[mediawiki/extensions/CommunityConfiguration@master] Drop the apostrophes around the localized title of the config editor

https://gerrit.wikimedia.org/r/1021872

gerritbot added a project: Patch-For-Review.Apr 19 2024, 8:59 AM

Michael moved this task from Doing to Code Review on the Growth-Team (Sprint 12 (Growth Team)) board.Apr 19 2024, 9:18 AM

Change #1021872 merged by jenkins-bot:

[mediawiki/extensions/CommunityConfiguration@master] Drop the apostrophes around the localized title of the config editor

https://gerrit.wikimedia.org/r/1021872

Urbanecm_WMF removed a project: Patch-For-Review.Apr 22 2024, 8:28 AM

Urbanecm_WMF moved this task from Code Review to QA on the Growth-Team (Sprint 12 (Growth Team)) board.

Etonkovidova mentioned this in T362728: [QA task] Community Configuration - testing in production .Apr 22 2024, 4:58 PM

Checked in eswiki beta - the fix is in place; added as a test case to T362728: [QA task] Community Configuration - testing in production

Screen Shot 2024-04-22 at 9.55.30 AM.png (1×2 px, 235 KB)

Sgs mentioned this in T358335: Allow to display informational header text in the editor.May 14 2024, 12:20 PM

	F48121893: Screen Shot 2024-04-22 at 9.55.30 AM.png
	Apr 22 2024, 5:01 PM

	F47425765: Screen Shot 2024-04-18 at 5.12.43 PM.png
	Apr 19 2024, 12:36 AM

Community configuration: Special:CommunityConfiguration/PROVIDER should display the provider name in the header instead of provider IDClosed, ResolvedPublic1 Estimated Story PointsActions