Page MenuHomePhabricator

Community configuration: Special:CommunityConfiguration/PROVIDER should display the provider name in the header instead of provider ID
Closed, ResolvedPublic1 Estimated Story Points

Description

With the T360473 patch loaded, http://localhost:8080/wiki/Special:CommunityConfiguration/GrowthHomepage looks like this:

image.png (307×1 px, 35 KB)

In the headline, it says "Editing 'GrowthHomepage'", where GrowthHomepage is the technical ID under which the provider is registered. This shouldn't be displayed to the user – instead, we should be displaying the provider name. This issue is not visible without that patch, as for Mentorship, the ID and the name is the same.

Note that part of MediaWiki-extensions-CommunityConfiguration codebase uses "provider name" with the now-wrong meaning (referring to the ID rather than the actual human readable name). Please see T361931 for explanation.

Within this task, we should also remove the apostrophes.

Acceptance Criteria:

Fix the title
Review for other occurrences of this problem

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Urbanecm_WMF renamed this task from Community configuration: Special:CommunityConfiguration/PROVIDER should use the provider name in the description, not provider ID to Community configuration: Special:CommunityConfiguration/PROVIDER should display the provider name in the header instead of provider ID.Apr 6 2024, 12:09 PM
Urbanecm_WMF updated the task description. (Show Details)
KStoller-WMF set the point value for this task to 1.Apr 16 2024, 4:50 PM
KStoller-WMF updated the task description. (Show Details)

Change #1020301 had a related patch set uploaded (by Michael Große; author: Michael Große):

[mediawiki/extensions/CommunityConfiguration@master] Rename parameter and private field providerName to providerId

https://gerrit.wikimedia.org/r/1020301

Change #1020302 had a related patch set uploaded (by Michael Große; author: Michael Große):

[mediawiki/extensions/CommunityConfiguration@master] Show the provider name in the editor title, not the Id

https://gerrit.wikimedia.org/r/1020302

Change #1020301 merged by jenkins-bot:

[mediawiki/extensions/CommunityConfiguration@master] Rename parameter and private field providerName to providerId

https://gerrit.wikimedia.org/r/1020301

Change #1020302 merged by jenkins-bot:

[mediawiki/extensions/CommunityConfiguration@master] Show the provider name in the editor title, not the Id

https://gerrit.wikimedia.org/r/1020302

Can be seen on https://es.wikipedia.beta.wmflabs.org/wiki/Especial:CommunityConfiguration/GrowthHomepage?uselang=en

It now says "Editing 'Newcomer Homepage'" in English and something Spanish in Spanish, instead of always just saying "Editing 'GrowthHomepage'".

Can be seen on https://es.wikipedia.beta.wmflabs.org/wiki/Especial:CommunityConfiguration/GrowthHomepage?uselang=en

It now says "Editing 'Newcomer Homepage'" in English and something Spanish in Spanish, instead of always just saying "Editing 'GrowthHomepage'".

@Michael - the task description says:

Within this task, we should also remove the apostrophes.

The apostrophes are still present in the title when he form is edited (the screenshot also shows that the apostrophes are not present in the Save box) :

Screen Shot 2024-04-18 at 5.12.43 PM.png (1×1 px, 229 KB)

@Michael - the task description says:

Within this task, we should also remove the apostrophes.

The apostrophes are still present in the title when he form is edited

I totally missed that line. Thank you for pointing it out! Will fix right away.

Change #1021872 had a related patch set uploaded (by Michael Große; author: Michael Große):

[mediawiki/extensions/CommunityConfiguration@master] Drop the apostrophes around the localized title of the config editor

https://gerrit.wikimedia.org/r/1021872

Change #1021872 merged by jenkins-bot:

[mediawiki/extensions/CommunityConfiguration@master] Drop the apostrophes around the localized title of the config editor

https://gerrit.wikimedia.org/r/1021872

Checked in eswiki beta - the fix is in place; added as a test case to T362728: [QA task] Community Configuration - testing in production

Screen Shot 2024-04-22 at 9.55.30 AM.png (1×2 px, 235 KB)