Page MenuHomePhabricator

[QA task] Community Configuration UI evaluation
Closed, ResolvedPublic

Description

DONE

DONE (1) - will be addressed in T358659 The fields correctly intercept invalid value such as 0.002 - the warning appears. But the suggested values (from the value selector at the end of the field) include negative values.

Screen Shot 2024-03-28 at 1.39.51 PM.png (252×3 px, 88 KB)

Another example of handling numbers in the fields - large numbers are accepted and converted to scientific notation:
Screen Shot 2024-03-28 at 2.10.24 PM.png (774×1 px, 144 KB)

DONE (2 - the single quotes are removed as part of T361933) Do we need single quotes around Mentorship?

Screen Shot 2024-03-28 at 1.47.45 PM.png (664×1 px, 88 KB)

DONE (3)- resolved x (in the above screenshot) I didn't find the presence of this control in figma design

DONE (4) - will be addressed; see the comment https://phabricator.wikimedia.org/T361324#9699966**
Mentorship** section in Special:EditGrowthConfig has information that is not present on Special:CommunityConfiguration/Mentorship

Screen Shot 2024-03-28 at 4.45.37 PM.png (1×2 px, 225 KB)
Screen Shot 2024-06-07 at 4.42.28 PM.png (1×2 px, 272 KB)

DONE (5) - will be addressed The fields occupy the whole page width (Special:EditGrowthConfig limits the fields length).

DONE (6) - To be covered in T367133: Community Configuration: Save Changes Edit Summary improvements @Tacsipacsi comment T354463#9674654

Screen Shot 2024-03-28 at 2.52.10 PM.png (960×1 px, 162 KB)

I noticed two differences that I’m not sure if they are intentional:

  • The (optional) text is bold. In both designs in the description, it has a normal weight.
  • The summary box is huge. In one design, it’s a two-line textbox, in the other one, it’s a one-line input; in the implementation, it’s eight lines >tall. This gives the impression that the edit summary can be however long I want it to be (and indeed, nothing on the frontend prevents me >from writing an over 1000 characters long summary, even though the backend (MW core) caps the summary at 500 characters).

    Two minor questions:
    • on submitting edits in VE, there is a footer with legal clause with links to licensees and to the Terms of Use. Do we need a link to the Terms of Use in the Edit Summary too?
    • the placement of the Reminder is the same as for the footer for saving edits which might confuse those users who used to see different footer.

      What if both messages were displayed below each other, with the Reminder being above and maybe on a grey background (like the checkboxes in VE)? Especially the color difference would stress that this is not just the usual stuff.

DONE (7)- works as intended from T357710#9733651

  • The list of suggestions displays the titles in black, not in blue (as links) as they are displayed in produciton:
eswiki betaproduction
Screen Shot 2024-04-22 at 5.31.01 PM.png (1×3 px, 212 KB)
Screen Shot 2024-04-22 at 5.47.59 PM.png (1×1 px, 173 KB)
  • the text field doesn't have the input text placeholder
  • the invalid input (no matching pages) has no indication that it's invalid
eswiki betaproduction
Screen Shot 2024-04-22 at 5.43.57 PM.png (766×1 px, 101 KB)
Screen Shot 2024-04-22 at 4.45.42 PM.png (838×2 px, 129 KB)
Screen Shot 2024-04-22 at 5.53.22 PM.png (520×2 px, 97 KB)
Screen Shot 2024-04-22 at 4.45.25 PM.png (566×2 px, 97 KB)

DONE (8) will be done in T366270 The first field on Special:CommunityConfiguration/GrowthSuggestedEdits - Infobox templates in its current implementation doesn't have links

Figma design has such links.

DONE (9) - addressed, see this comment https://phabricator.wikimedia.org/T361324#9877929 Should "Give feedback" option be on every module page?

Screen Shot 2024-06-07 at 4.59.06 PM.png (1×1 px, 195 KB)

(10) and (11) are from this comment - T360471#9831541

DONE (10) - will be addressed in https://phabricator.wikimedia.org/T361324
Add a link section
Currently in production two add link tasks (structured and un-structured types) have the same title: Add links between articles. The figma design also uses the same title for both type of tasks (to differentiate them two icons are used). On Special:CommunityConfiguration/GrowthSuggestedEdits two different titles are used - Add links between articles and Add a link - was it documented somewhere that there would be two different titles?
The robot icon was used to differentiate between structured (algorithm-suggested) tasks and others - in betalabs the robot icon was not present.

DONE (11) will be done in T367201 there are two fields added to the end of Special:CommunityConfiguration/GrowthSuggestedEdits page - Weight of underlinked articles and Minimum required link score. Those fields are not present on Special:EditGrowthConfig or in the figma design. Such fields might require some technical knowledge and an additional understanding of a suggested link algorithm - is it expected from admin users?

Related Objects

Mentioned In
T358659: Client side form validation
T364846: Collection items fields should be wrapped in a module like box
T357710: Page titles selector control
T362044: Community configuration: Decision about how to display the boolean controls in Special:CommunityConfiguration/Mentorship
T354463: Community Configuration Edit Summary
T356622: Community configuration 2.0 editing form MVP
Mentioned Here
T367201: Community Configuration: Improve explanation for "underlinkedWeight" and "minimumLinkScore" in Suggested Edits form
T357712: Single page title selector control
T366270: Support links in help messages & field descriptions
T367133: Community Configuration: Save Changes Edit Summary improvements
T360471: Growth features: Migrate Suggested edits from Special:EditGrowthConfig to Community configuration 2.0
T357710: Page titles selector control
T362203: Community Configuration: Help Links
T362285: Community Configuration: Add Character count to Edit Summary
T350629: Community Configuration 2.0: Help documentation for communities
T358335: Allow to display informational header text in the editor
T358659: Client side form validation
T360473: Growth features: Migrate Homepage settings from Special:EditGrowthConfig to Community configuration 2.0
T361933: Community configuration: Special:CommunityConfiguration/PROVIDER should display the provider name in the header instead of provider ID
T362044: Community configuration: Decision about how to display the boolean controls in Special:CommunityConfiguration/Mentorship
T354463: Community Configuration Edit Summary

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Thanks for the testing notes Elena!

(1) The fields correctly intercept invalid value such as 0.002 - the warning appears. But the suggested values (from the value selector at the end of the field) include negative values.

This is because we currently do not have no support for rules that are stricter than a datatype. In other words, we can specify the form should accept an integer, but we cannot specify that we're interested in an integer from a specific range. As a result, negative integers are suggested (as they are integers as well). T358659 will likely change that (note the task's scope is wider than its name).

(2) Do we need apostrophes around Mentorship?

Probably not. There is a different bug in that line as well (one which cannot be seen now, but will be visible with T360473), which I filled as T361933: Community configuration: Special:CommunityConfiguration/PROVIDER should display the provider name in the header instead of provider ID last Friday. I added a note to remove the apostrophes as part of that task as well.

(3) x (in the above screenshot) I didn't find the presence of this control in figma design

Filled as T362044: Community configuration: Decision about how to display the boolean controls in Special:CommunityConfiguration/Mentorship. Thanks for the reminder!

Going through the rest of the testing notes.

(4) Mentorship section in Special:EditGrowthConfig has information that is not present on Special:CommunityConfiguration/Mentorship
What Special:EditGrowthConfig has:

  • short explanation of Mentors roles, a suggestion, and a link to more information

This is yet to be implemented as part of T358335: Allow to display informational header text in the editor.

  • "Are mentorship features enabled?" is the first question

Indeed. This is to be decided on in T362044: Community configuration: Decision about how to display the boolean controls in Special:CommunityConfiguration/Mentorship (and implemented in an engineering follow-up task, once a decision's been made).

Also, should we have "Send us your feedback" on Special:CommunityConfiguration/Mentorship?

Maybe? @JFernandez-WMF, I don't see the feedback link in the Figma designs. Is that intentional? Do we want to have it somewhere? There's also a help link included – I'm not filling a task yet, as I don't think we have anything useful to link (T350629), but noting just in case.

(5) The fields occupy the whole page width (Special:EditGrowthConfig limits the fields length).

@JFernandez-WMF Do you have any thoughts on what is the intended behaviour here, plese?

(6) @Tacsipacsi comment https://phabricator.wikimedia.org/T354463#9674654

IMO, issues highlighted there should be resolved. Since the T354463 task is now in Design Review, I'll leave it up to @JFernandez-WMF and/or @KStoller-WMF to either move it back to Doing (if we should make changes as part of this task), or to fill a new task for follow-up improvements.

I don't see the feedback link in the Figma designs. Is that intentional? Do we want to have it somewhere? There's also a help link included – I'm not filling a task yet, as I don't think we have anything useful to link (T350629), but noting just in case.

I added T362203: Community Configuration: Help Links.

Since the T354463 task is now in Design Review, I'll leave it up to @JFernandez-WMF and/or @KStoller-WMF to either move it back to Doing (if we should make changes as part of this task), or to fill a new task for follow-up improvements.

I added T362285: Community Configuration: Add Character count to Edit Summary

(5) The fields occupy the whole page width (Special:EditGrowthConfig limits the fields length).

@JFernandez-WMF thoughts on this?
The very wide fields don't look great in my perspective, but curious if there is any official design guidance on this.

Screenshot 2024-04-10 at 4.25.49 PM.png (1×2 px, 276 KB)

KStoller-WMF triaged this task as Medium priority.
KStoller-WMF moved this task from Backlog to Up Next on the Growth-Team board.

It looks like this task is ongoing / in progress, so I'll move it to Up Next so we pull it into the next sprint.

(5) The fields occupy the whole page width (Special:EditGrowthConfig limits the fields length).

@JFernandez-WMF thoughts on this?
The very wide fields don't look great in my perspective, but curious if there is any official design guidance on this.

Screenshot 2024-04-10 at 4.25.49 PM.png (1×2 px, 276 KB)

@KStoller-WMF sorry, I just saw this ping here 🤦🏻‍♀️ This is indeed something that we can improve. We have received feedback previously on a usage of 512 max width for fields being a better option. @Sgs curious if this is something we can try to see if it improves readability.

@KStoller-WMF sorry, I just saw this ping here 🤦🏻‍♀️ This is indeed something that we can improve. We have received feedback previously on a usage of 512 max width for fields being a better option. @Sgs curious if this is something we can try to see if it improves readability.

I did some tests with max-width: 512px on all of our fields. All screenshots take on laptop wide screen 3582px.

growth-config-cs-3582.png (2×3 px, 1 MB)
suggested-edits-3582.png (1×3 px, 551 KB)
help-panel-3582.png (1×3 px, 433 KB)
Screenshot 2024-06-06 at 17.21.21.png (1×3 px, 469 KB)
current config in cswikiCC2.0 suggested editsCC2.0 help panelCC2.0 help panel with sidebars

I can see some problems:

  1. 512px maybe to narrow in wide screens, see help panel example
  2. The chip input selectors (namespaces & and page titles) can grow vertically quite a lot like in the infobox templates case. Narrowing the control increases that vertical height
  3. The horizontal gutter is different if the sidebars are hidden or not

Some ideas:

  • extend the 512 limit
  • make the limit relative to the screen width
  • apply different limit to the chip input selectors than the rest of fields
  • investigate how to "flex" the form width or fields width based on sidebars hidden or not

I broke #6 into: T367133: Community Configuration: Save Changes Edit Summary improvements

We should create a task for #7 & 8. I'll create them tomorrow unless someone beats me to it.

#9 We opted to add a general "Give feedback" call to action on the dashboard, and then link each form to an associated Help page (where people can navigate to the Talk page to give feedback). My guess is that's enough for experienced editors, but I'm open to a larger Feedback call to action on each form if others think it would be an improvement.

#11 this definitely needs a follow up task. I'll create a task to suggest a solution.

Change #1041590 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):

[mediawiki/extensions/GrowthExperiments@master] Config: add minimum to integers in schemas

https://gerrit.wikimedia.org/r/1041590

We should create a task for #7 & 8. I'll create them tomorrow unless someone beats me to it.

I think for (7) DST gave the ok in T357712#9765356 for all labels to be black. For (8) I've added an acceptance criteria item in T366270 which should suffice

#11 this definitely needs a follow up task. I'll create a task to suggest a solution.

🙏

(11) there are two fields added to the end of Special:CommunityConfiguration/GrowthSuggestedEdits page - Weight of underlinked articles and Minimum required link score. Those fields are not present on Special:EditGrowthConfig or in the figma design. Such fields might require some technical knowledge and an additional understanding of a suggested link algorithm - is it expected from admin users?

I've added T367201: Community Configuration: Improve explanation for "underlinkedWeight" and "minimumLinkScore" in Suggested Edits form.

Etonkovidova updated the task description. (Show Details)

Reviewed - all reported issues/questions have been addressed/captured in different tickets or accepted as a current behavior. Closing as Resolved

I did some tests with max-width: 512px on all of our fields. All screenshots take on laptop wide screen 3582px.

growth-config-cs-3582.png (2×3 px, 1 MB)
suggested-edits-3582.png (1×3 px, 551 KB)
help-panel-3582.png (1×3 px, 433 KB)
Screenshot 2024-06-06 at 17.21.21.png (1×3 px, 469 KB)
current config in cswikiCC2.0 suggested editsCC2.0 help panelCC2.0 help panel with sidebars

I can see some problems:

  1. 512px maybe to narrow in wide screens, see help panel example
  2. The chip input selectors (namespaces & and page titles) can grow vertically quite a lot like in the infobox templates case. Narrowing the control increases that vertical height
  3. The horizontal gutter is different if the sidebars are hidden or not

    Some ideas:
  4. extend the 512 limit
  5. make the limit relative to the screen width
  6. apply different limit to the chip input selectors than the rest of fields
  7. investigate how to "flex" the form width or fields width based on sidebars hidden or not

Thanks @Sgs, I consulted with DST and the maximum field width has changed from 512px to 640 px and they have a new token for that, which is size-4000. I think it would be best to test this new width, if we see that we keep having problems, then we can considerate some of the other suggestions. I can create a task to track this discussion if we think it is necessary.

Thanks @Sgs, I consulted with DST and the maximum field width has changed from 512px to 640 px and they have a new token for that, which is size-4000. I think it would be best to test this new width, if we see that we keep having problems, then we can considerate some of the other suggestions. I can create a task to track this discussion if we think it is necessary.

I went ahead and used the "size-4000 (640px) limit so you can see how it looks in Beta as soon as it is merged. This is a local screenshot:

Screenshot 2024-06-13 at 13.18.29.png (2×2 px, 517 KB)

Change #1041590 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Config: add minimum to integers in schemas

https://gerrit.wikimedia.org/r/1041590

Thanks @Sgs, I consulted with DST and the maximum field width has changed from 512px to 640 px and they have a new token for that, which is size-4000. I think it would be best to test this new width, if we see that we keep having problems, then we can considerate some of the other suggestions. I can create a task to track this discussion if we think it is necessary.

I went ahead and used the "size-4000 (640px) limit so you can see how it looks in Beta as soon as it is merged. This is a local screenshot:

Screenshot 2024-06-13 at 13.18.29.png (2×2 px, 517 KB)

Checked - looks great:

Screen Shot 2024-06-17 at 5.50.04 PM.png (1×1 px, 303 KB)