Page MenuHomePhabricator

[QA task] Community Configuration UI evaluation
Open, MediumPublic

Description

(1) The fields correctly intercept invalid value such as 0.002 - the warning appears. But the suggested values (from the value selector at the end of the field) include negative values.

Screen Shot 2024-03-28 at 1.39.51 PM.png (252×3 px, 88 KB)

Another example of handling numbers in the fields - large numbers are accepted and converted to scientific notation:
Screen Shot 2024-03-28 at 2.10.24 PM.png (774×1 px, 144 KB)

DONE (2) Do we need single quotes around Mentorship? - the single quotes are removed as part of T361933

Screen Shot 2024-03-28 at 1.47.45 PM.png (664×1 px, 88 KB)

(3) x (in the above screenshot) I didn't find the presence of this control in figma design
(4) Mentorship section in Special:EditGrowthConfig has information that is not present on Special:CommunityConfiguration/Mentorship

Screen Shot 2024-03-28 at 4.45.37 PM.png (1×2 px, 225 KB)
Screen Shot 2024-03-28 at 4.48.11 PM.png (1×2 px, 265 KB)

What Special:EditGrowthConfig has:

  • short explanation of Mentors roles, a suggestion, and a link to more information
  • "Are mentorship features enabled?" is the first question

Also, should we have "Send us your feedback" on Special:CommunityConfiguration/Mentorship?
(5) The fields occupy the whole page width (Special:EditGrowthConfig limits the fields length).

(6) @Tacsipacsi comment https://phabricator.wikimedia.org/T354463#9674654

(7) from https://phabricator.wikimedia.org/T357710#9733651

  • The list of suggestions displays the titles in black, not in blue (as links) as they are displayed in produciton:
eswiki betaproduction
Screen Shot 2024-04-22 at 5.31.01 PM.png (1×3 px, 212 KB)
Screen Shot 2024-04-22 at 5.47.59 PM.png (1×1 px, 173 KB)
  • the text field doesn't have the input text placeholder
  • the invalid input (no matching pages) has no indication that it's invalid
eswiki betaproduction
Screen Shot 2024-04-22 at 5.43.57 PM.png (766×1 px, 101 KB)
Screen Shot 2024-04-22 at 4.45.42 PM.png (838×2 px, 129 KB)
Screen Shot 2024-04-22 at 5.53.22 PM.png (520×2 px, 97 KB)
Screen Shot 2024-04-22 at 4.45.25 PM.png (566×2 px, 97 KB)

Additional Notes:

As it's implemented now on `eswiki beta
(1) The text is not present on a page: "Some types of suggested edits are surfaced through ..."

(2) The text "These templates are needed for the image suggestions newcomer task feature. Articles containing these templates will not be listed as image suggestion tasks." doesn't have a link for image suggestions .

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Thanks for the testing notes Elena!

(1) The fields correctly intercept invalid value such as 0.002 - the warning appears. But the suggested values (from the value selector at the end of the field) include negative values.

This is because we currently do not have no support for rules that are stricter than a datatype. In other words, we can specify the form should accept an integer, but we cannot specify that we're interested in an integer from a specific range. As a result, negative integers are suggested (as they are integers as well). T358659 will likely change that (note the task's scope is wider than its name).

(2) Do we need apostrophes around Mentorship?

Probably not. There is a different bug in that line as well (one which cannot be seen now, but will be visible with T360473), which I filled as T361933: Community configuration: Special:CommunityConfiguration/PROVIDER should display the provider name in the header instead of provider ID last Friday. I added a note to remove the apostrophes as part of that task as well.

(3) x (in the above screenshot) I didn't find the presence of this control in figma design

Filled as T362044: Community configuration: Decision about how to display the boolean controls in Special:CommunityConfiguration/Mentorship. Thanks for the reminder!

Going through the rest of the testing notes.

(4) Mentorship section in Special:EditGrowthConfig has information that is not present on Special:CommunityConfiguration/Mentorship
What Special:EditGrowthConfig has:

  • short explanation of Mentors roles, a suggestion, and a link to more information

This is yet to be implemented as part of T358335: Allow to display informational header text in the editor.

  • "Are mentorship features enabled?" is the first question

Indeed. This is to be decided on in T362044: Community configuration: Decision about how to display the boolean controls in Special:CommunityConfiguration/Mentorship (and implemented in an engineering follow-up task, once a decision's been made).

Also, should we have "Send us your feedback" on Special:CommunityConfiguration/Mentorship?

Maybe? @JFernandez-WMF, I don't see the feedback link in the Figma designs. Is that intentional? Do we want to have it somewhere? There's also a help link included – I'm not filling a task yet, as I don't think we have anything useful to link (T350629), but noting just in case.

(5) The fields occupy the whole page width (Special:EditGrowthConfig limits the fields length).

@JFernandez-WMF Do you have any thoughts on what is the intended behaviour here, plese?

(6) @Tacsipacsi comment https://phabricator.wikimedia.org/T354463#9674654

IMO, issues highlighted there should be resolved. Since the T354463 task is now in Design Review, I'll leave it up to @JFernandez-WMF and/or @KStoller-WMF to either move it back to Doing (if we should make changes as part of this task), or to fill a new task for follow-up improvements.

I don't see the feedback link in the Figma designs. Is that intentional? Do we want to have it somewhere? There's also a help link included – I'm not filling a task yet, as I don't think we have anything useful to link (T350629), but noting just in case.

I added T362203: Community Configuration: Help Links.

Since the T354463 task is now in Design Review, I'll leave it up to @JFernandez-WMF and/or @KStoller-WMF to either move it back to Doing (if we should make changes as part of this task), or to fill a new task for follow-up improvements.

I added T362285: Community Configuration: Add Character count to Edit Summary

(5) The fields occupy the whole page width (Special:EditGrowthConfig limits the fields length).

@JFernandez-WMF thoughts on this?
The very wide fields don't look great in my perspective, but curious if there is any official design guidance on this.

Screenshot 2024-04-10 at 4.25.49 PM.png (1×2 px, 276 KB)

KStoller-WMF triaged this task as Medium priority.
KStoller-WMF moved this task from Backlog to Up Next on the Growth-Team board.

It looks like this task is ongoing / in progress, so I'll move it to Up Next so we pull it into the next sprint.

(5) The fields occupy the whole page width (Special:EditGrowthConfig limits the fields length).

@JFernandez-WMF thoughts on this?
The very wide fields don't look great in my perspective, but curious if there is any official design guidance on this.

Screenshot 2024-04-10 at 4.25.49 PM.png (1×2 px, 276 KB)

@KStoller-WMF sorry, I just saw this ping here 🤦🏻‍♀️ This is indeed something that we can improve. We have received feedback previously on a usage of 512 max width for fields being a better option. @Sgs curious if this is something we can try to see if it improves readability.