This is currently blocked on implementing the agreed-on changes to T357718: Support schema references. Moving to Blocked to reflect that.

Change #1017865 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@master] [WIP] Add SuggestedEditsSchema

https://gerrit.wikimedia.org/r/1017865

This is blocked by T362098: Community configuration: References that do not have a dedicated control assigned should work normally, as copy-pasting a very long array for every single suggested edit type seems far from ideal.

Change #1022451 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):

[mediawiki/extensions/GrowthExperiments@master] Add suggested edits partial config schema

https://gerrit.wikimedia.org/r/1022451

Change #1022451 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Config: add partial suggested edits schema

https://gerrit.wikimedia.org/r/1022451

Based on a discussion with @Sgs yesterday, this is now ready for code review. The form as of now looks very ugly – namely, it looks like this: https://ctrlv.cz/1zNn. There are two main issues in that form:

• Config for template-based tasks does not display at all: This is caused by T362098, and will be fixed as part of that task.
• Labels for structured edits other than Add Image do not display: This is caused by T363477, and will be fixed as part of that task.

The second issue is also why the checkbox is melded with other form fields – if the label did display, it would look properly.

With all of those caveats mentioned, moving to Code Review. @Etonkovidova, please note those two issues when QAing if possible. Thanks!

Change #1017865 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Add SuggestedEditsSchema

https://gerrit.wikimedia.org/r/1017865

Change #1025408 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@master] Community configuration: Add missing messages for Suggested edits

https://gerrit.wikimedia.org/r/1025408

In T360471#9747902, @Urbanecm_WMF wrote:

• Config for template-based tasks does not display at all: This is caused by T362098, and will be fixed as part of that task.
• Labels for structured edits other than Add Image do not display: This is caused by T363477, and will be fixed as part of that task.

Both of those issues should be resolved now. I uploaded a patch to fix the labels. Now, Special:CommunityConfiguration/GrowthSuggestedEdits should meet expectations.

Change #1025408 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Community configuration: Fix labels for Suggested edits

https://gerrit.wikimedia.org/r/1025408

We are missing the config options for notifications in this form, GELevelingUpGetStartedMaxTotalEdits and GELevelingUpKeepGoingNotificationThresholds-maximum. Re-opening since the task has not yet been QA'ed.

Unfortunately, adding those two options is more problematic than it looks like. I filled T365612: Growth features: Add Levelling up related configuration for that problem. The list of infoboxes settings is currently ignored as well, I filled that problem as T365606: List of infobox templates in Special:CommunityConfiguration/GrowthSuggestedEdits is ignored.

Apart from that, this should be working and ready for QA, so I'm moving it back to that column. FYI @Etonkovidova .

In T360471#9821886, @Urbanecm_WMF wrote:

Unfortunately, adding those two options is more problematic than it looks like. I filled T365612: Growth features: Add Levelling up related configuration for that problem. The list of infoboxes settings is currently ignored as well, I filled that problem as T365606: List of infobox templates in Special:CommunityConfiguration/GrowthSuggestedEdits is ignored.

Apart from that, this should be working and ready for QA, so I'm moving it back to that column. FYI @Etonkovidova .

Thx, @Urbanecm_WMF for clarifying the task scope?

Questions:
(1) Suggested Special:CommunityConfiguration/GrowthSuggestedEdits UI doesn't match the figma design. Do you think we should keep this tasks as WIP until all UI specs will be in place?
(2) Questions on Add a link section

• currently in production two add link tasks (structured and un-structured types) have the same title: Add links between articles. The figma design also uses the same title for both type of tasks (to differentiate them two icons are used). On Special:CommunityConfiguration/GrowthSuggestedEdits two different titles are used - Add links between articles and Add a link - was it documented somewhere that there would be two different titles?

✅ DONE - it seems that a field under List of excluded sections from the Add link task is missing?
And, the label displayed immediately after (The maximum number of "Add an image to an article section" suggested tasks a newcomer can complete daily) has a reference to "an image" instead of "a link".

• there are two fields added to the end of Special:CommunityConfiguration/GrowthSuggestedEdits page - Weight of underlinked articles and Minimum required link score. Those fields are not present on Special:EditGrowthConfig or in the figma design. Such fields might require some technical knowledge and an additional understanding of a suggested link algorithm - is it expected from admin users?