Page MenuHomePhabricator

Error /validation states: wish form
Open, In Progress, HighPublic

Description

Background
We want to inform users when their form is incomplete, so that they can publish a valid form response. This ticket is for clicking publish when there is no "draft" state.

User story / requirement
Given that I am filling out the form and miss a required field, when I click submit, then I should see validation errors on invalid form fields, and be able to edit my response.

Show an error state when a user hasn't selected a required field, or if a field doesn't hit a character limit

  • Title: min 5 characters, max 70
  • Description: 50+ characters
  • "wish type": Select 1
  • Project(s): Select 1+ or “other”. Other needs 3+ characters
  • Impacted users: 5+ characters

Optional fields:

  • Phab ticket

All form validation language should follow convention of codex principles.

Relevant figma: https://www.figma.com/design/JcTMFwbEJPpCKBiZ16Jkel/Future-of-the-Wishlist?node-id=1368-14631&t=CrKXOpbCpA53k5z5-0

Details

TitleReferenceAuthorSource BranchDest Branch
Add 'Terms of Use' field to intake formrepos/commtech/wishlist-intake!27samwilsontermsofuse-T364959main
Customize query in GitLab

Event Timeline

JWheeler-WMF renamed this task from Error states: form to Error /validation states: wish form.Apr 23 2024, 8:19 PM
JSengupta-WMF changed the task status from Open to In Progress.EditedWed, May 29, 10:23 AM
JSengupta-WMF subscribed.

General error states example here

Intake Form error.jpg (2×1 px, 687 KB)

Here are the specific error messages as per the ticket description

  • Title 10+ characters, max 70: "Title must be between 10 - 70 characters long."
  • Description: 50+ characters: "Description must be at least 50 characters long."
  • Idea type Select 1: "Select an idea type."
  • Project(s) Select 1 or enter something else (something else needs 3+ characters): "Select at least one related project." if other is selected and too short then "External project name must be at least 3 characters long."
  • Impacted users: 10+ characters: "Impacted user must be at least 10 characters long."
  • Error under the submit button: "Please complete all the mandatory fields before submitting this idea or save it as a draft to complete later."
JWheeler-WMF raised the priority of this task from Medium to High.Wed, Jun 5, 3:17 PM
KSiebert added a subscriber: TheresNoTime.

We are not implementing error validation states anymore.
As per the decision made on June 5th, 2024.
Reason: this is extra scope. While it is an optimization and potentially better UX, we don't know how users will interact with the form, and users will still be able to "draft" wishes in their sandbox environments. We can implement draft mode as a fast follow.