Page MenuHomePhabricator

Bottom of page notification/toast is not readable in dark mode
Open, HighPublic2 Estimated Story PointsBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

  • Enable dark mode on mobile site - log in, click settings, click "advanced mode" to make the dark mode show up
  • Do something which triggers a bottom of page notification / toast e.g. watch a page

What happens?:

Text is black on a dark background and unreadable

en.m.wikipedia.org_wiki_Ichthyotitan(iPhone SE).png (1×750 px, 194 KB)

What should have happened instead?:

Either text should be light, or background should be light

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

  • Notes for first-time taskers **
  • Click "mobile view" at the bottom of the page to get mobile site
  • you will need to install Extension:MobileFrontend to test this
  • The fix will live in the https://www.mediawiki.org/wiki/Skin:Minerva_Neue skin
  • Adding the notheme class to any element will make the element look the same in night and day themes - this should be used here.

Event Timeline

Jdlrobson subscribed.

This appears to apply only to the parser migration alert.

Not for me, it's happening for other notifications such as watch/unwatch and redirected. The parsoid one actually looks okay to me https://en.m.wikipedia.org/wiki/Dorothy_Olsen?useparsoid=1

en.m.wikipedia.org_wiki_Dorothy_Olsen_useparsoid=1(iPhone SE).png (1×750 px, 401 KB)

Jdlrobson added a subscriber: DTorsani-WMF.

It looks like @color-inverted is wrong in the dark mode theme @DTorsani-WMF

Jdlrobson added a project: good first task.
Jdlrobson updated the task description. (Show Details)

Talking to @egardner this can be fixed by adding @color-inverted-fixed or adding notheme class to last modified bar - as it should look the same in day or night theme.

@Jdlrobson Glad you spoke with Eric about this. These cases are exactly why we created the @color-inverted-fixed token.

This seems like an issue we need to fix in Minerva, not Codex.

ovasileva set the point value for this task to 2.Thu, May 16, 5:57 PM