Page MenuHomePhabricator

Last modified bar (when page recently edited) has insufficient contrast in dark mode
Closed, ResolvedPublic1 Estimated Story PointsBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

  • Enable dark mode on mobile site - log in, click settings, click "advanced mode" to make the dark mode show up
  • Visit a page which has been recently edited
  • Scroll down to bottom of page

What happens?:

Text is #101418 on background #36c with a contrast ratio of 3.44:1, not sufficient for WCAG AA compliance

en.m.wikipedia.org_wiki_2024_Croatian_parliamentary_election(iPhone SE) (1).png (96×750 px, 10 KB)

Notes for first-time taskers

  • Click "mobile view" at the bottom of the page to get mobile site
  • you will need to install Extension:MobileFrontend to test this
  • The fix will live in the https://www.mediawiki.org/wiki/Skin:Minerva_Neue skin
  • Adding the notheme class to any element will make the element look the same in night and day themes - this should be used here.

Requirement

Ensure that the "last modified" bar has sufficient contrast in dark mode on mobile, making the text legible and compliant with WCAG AA standards.

BDD

Feature: Sufficient Contrast for "Last Modified" Bar in Dark Mode

  Scenario: Ensure "last modified" bar contrast in dark mode
    Given the user has enabled dark mode on the mobile site
    When the user visits a recently edited page and scrolls to the bottom
    Then the text in the "last modified" bar should have sufficient contrast and be legible

Test Steps

Test Case 1: Ensure Sufficient Contrast for "Last Modified" Bar in Dark Mode

  1. Enable dark mode on the mobile site by logging in, clicking settings, and enabling "advanced mode."
  2. Visit a page that has been recently edited.
  3. Scroll to the bottom of the page.
  4. AC1: Confirm that the text in the "last modified" bar has sufficient contrast and is legible, meeting WCAG AA standards.

QA Results - Beta

ACStatusDetails
1T364123#9823907

QA Results - PROD

ACStatusDetails
1T364123#9844453

Event Timeline

Same issue as T364117: color-inverted is not the correct color in the dark mode theme

We probably need to fix this by adding the notheme class to the last modified bar.

Jdlrobson added a subscriber: egardner.

Talking to @egardner this can be fixed by adding @color-inverted-fixed or adding notheme class to last modified bar - as it should look the same in day or night theme.

SToyofuku-WMF subscribed.

Picking this up a day early as our current sprint is pretty much wrapped up

Change #1032874 had a related patch set uploaded (by Stoyofuku-wmf; author: Stoyofuku-wmf):

[mediawiki/skins/MinervaNeue@master] Fix inverted text in (recently) last modified bar

https://gerrit.wikimedia.org/r/1032874

Change #1032874 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] Fix inverted text in (recently) last modified bar

https://gerrit.wikimedia.org/r/1032874

Edtadros subscribed.

Test Result - Beta

Status: ✅ PASS
Environment: Beta
OS: macOS Sonoma
Browser: Chrome
Device: MBA
Emulated Device: NA

Test Artifact(s):

Test Steps

Test Case 1: Ensure Sufficient Contrast for "Last Modified" Bar in Dark Mode

  1. Enable dark mode on the mobile site by logging in, clicking settings, and enabling "advanced mode."
  2. Visit a page that has been recently edited.
  3. Scroll to the bottom of the page.
  4. AC1: Confirm that the text in the "last modified" bar has sufficient contrast and is legible, meeting WCAG AA standards.

screenshot 369.png (904×1 px, 160 KB)

Test Result - PROD

Status: ✅ PASS
Environment: PROD
OS: macOS Sonoma 14.5
Browser: Chrome 125
Device: MBA
Emulated Device: NA

Test Artifact(s):

Test Steps

Test Case 1: Ensure Sufficient Contrast for "Last Modified" Bar in Dark Mode

  1. Enable dark mode on the mobile site by logging in, clicking settings, and enabling "advanced mode."
  2. Visit a page that has been recently edited (ex. https://en.m.wikipedia.org/w/index.php?title=Mohd_Amri_Yahyah&direction=next&oldid=1226283241&minervanightmode=1)
  3. Scroll to the bottom of the page.
  4. AC1: Confirm that the text in the "last modified" bar has sufficient contrast and is legible, meeting WCAG AA standards.

2024-05-29_15-12-46.png (1×3 px, 550 KB)

Jdlrobson claimed this task.