Maniphest T364123

Last modified bar (when page recently edited) has insufficient contrast in dark mode
Open, HighPublic1 Estimated Story PointsBUG REPORT
Actions

Description

Steps to replicate the issue (include links if applicable):

Enable dark mode on mobile site - log in, click settings, click "advanced mode" to make the dark mode show up
Visit a page which has been recently edited
Scroll down to bottom of page

What happens?:

Text is #101418 on background #36c with a contrast ratio of 3.44:1, not sufficient for WCAG AA compliance

Notes for first-time taskers

Click "mobile view" at the bottom of the page to get mobile site
you will need to install Extension:MobileFrontend to test this
The fix will live in the https://www.mediawiki.org/wiki/Skin:Minerva_Neue skin
Adding the notheme class to any element will make the element look the same in night and day themes - this should be used here.

Details

	Subject	Repo	Branch	Lines +/-
	Fix inverted text in (recently) last modified bar	mediawiki/skins/MinervaNeue	master	+3 -3

Customize query in gerrit

Related Objects

Mentioned Here: T364117: Bottom of page notification/toast is not readable in dark mode

Event Timeline

Pcoombe created this task.Fri, May 3, 1:23 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFri, May 3, 1:23 PM

Pcoombe added a project: WCAG-Level-AA.Fri, May 3, 1:24 PM

Aklapper moved this task from Backlog to Hacking projects on the Wikimedia-Hackathon-2024 board.Fri, May 3, 1:35 PM

Same issue as T364117: color-inverted is not the correct color in the dark mode theme

We probably need to fix this by adding the notheme class to the last modified bar.

Jdlrobson updated the task description. (Show Details)Sat, May 4, 6:58 PM

Jdlrobson updated the task description. (Show Details)

Jdlrobson added a project: Web-Team-Backlog (FY2023-24 Q4 Sprint 3).

Talking to @egardner this can be fixed by adding @color-inverted-fixed or adding notheme class to last modified bar - as it should look the same in day or night theme.

ovasileva edited projects, added Web-Team-Backlog (FY2023-24 Q4 Sprint 4); removed Web-Team-Backlog (FY2023-24 Q4 Sprint 3).Tue, May 7, 9:23 AM

CCiufo-WMF moved this task from Inbox to Following on the Design-System-Team board.Tue, May 7, 4:52 PM

ovasileva set the point value for this task to 1.Thu, May 16, 5:52 PM

ovasileva moved this task from Backlog to Ready for Development on the Web-Team-Backlog (FY2023-24 Q4 Sprint 4) board.

Picking this up a day early as our current sprint is pretty much wrapped up

Change #1032874 had a related patch set uploaded (by Stoyofuku-wmf; author: Stoyofuku-wmf):

[mediawiki/skins/MinervaNeue@master] Fix inverted text in (recently) last modified bar

https://gerrit.wikimedia.org/r/1032874

gerritbot added a project: Patch-For-Review.Fri, May 17, 9:20 PM

SToyofuku-WMF removed SToyofuku-WMF as the assignee of this task.Fri, May 17, 9:44 PM

SToyofuku-WMF moved this task from Doing to Code Review on the Web-Team-Backlog (FY2023-24 Q4 Sprint 4) board.

SToyofuku-WMF assigned this task to Edtadros.Fri, May 17, 10:00 PM

SToyofuku-WMF moved this task from Code Review to QA on the Web-Team-Backlog (FY2023-24 Q4 Sprint 4) board.

Change #1032874 merged by jenkins-bot: