Page MenuHomePhabricator

Update MediaWiki and Codex to Vue 3.4
Closed, ResolvedPublic3 Estimated Story Points

Description

Vue 3.4 was released in December 2023. It improves performance and adds some minor new features, notably same-name prop bindings (<cdx-button :action> as a shorthand for <cdx-button :action="action">) and allowing prop validators to access the values of other props.

We should upgrade both MW core and Codex to the latest version of Vue (right now this is 3.4.27).

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change #1031516 had a related patch set uploaded (by Eric Gardner; author: Eric Gardner):

[design/codex@main] build: Update key dependencies

https://gerrit.wikimedia.org/r/1031516

Change #1031566 had a related patch set uploaded (by Eric Gardner; author: Eric Gardner):

[design/codex@main] build: update vue-tsc dependency

https://gerrit.wikimedia.org/r/1031566

Change #1031568 had a related patch set uploaded (by Eric Gardner; author: Eric Gardner):

[design/codex@main] build: Update Vite

https://gerrit.wikimedia.org/r/1031568

Change #1031569 had a related patch set uploaded (by Eric Gardner; author: Eric Gardner):

[design/codex@main] build: Update Vue and related libs

https://gerrit.wikimedia.org/r/1031569

Change #1031516 abandoned by Eric Gardner:

[design/codex@main] build: Update key dependencies

Reason:

Abandoned in favor of the patch chain here: https://gerrit.wikimedia.org/r/c/design/codex/+/1031566

https://gerrit.wikimedia.org/r/1031516

Change #1031567 had a related patch set uploaded (by Eric Gardner; author: Eric Gardner):

[design/codex@main] build: Update @vitejs/plugin-vue

https://gerrit.wikimedia.org/r/1031567

Change #1031566 merged by jenkins-bot:

[design/codex@main] build: update vue-tsc dependency

https://gerrit.wikimedia.org/r/1031566

Change #1031567 merged by jenkins-bot:

[design/codex@main] build: Update @vitejs/plugin-vue

https://gerrit.wikimedia.org/r/1031567

One issue with this – in order to get Codex onto Vue 3.4.x, we need to update @vitejs/plugin-vue to 5.x, which also means we need to update Vite from 4.x (our current ) to 5.x.

See https://blog.vuejs.org/posts/vue-3-4 for more.

I've opened a series of patches so that we can tackle the updates one at a time.

Change #1032095 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/core@master] Update Codex from 1.5.0 to 1.6.0

https://gerrit.wikimedia.org/r/1032095

Change #1032095 merged by jenkins-bot:

[mediawiki/core@master] Update Codex from 1.5.0 to 1.6.0

https://gerrit.wikimedia.org/r/1032095

Change #1031569 abandoned by Eric Gardner:

[design/codex@main] build: Update Vue and related libs

Reason:

Moved these changes into the parent

https://gerrit.wikimedia.org/r/1031569

Change #1032114 had a related patch set uploaded (by Eric Gardner; author: Eric Gardner):

[mediawiki/core@master] Update Vue.js to 3.4.27

https://gerrit.wikimedia.org/r/1032114

Change #1032533 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/WikiLambda@master] [DNM] build: Upgrade Vue from 3.3.9 to 3.4.27, now MediaWiki/Codex has

https://gerrit.wikimedia.org/r/1032533

Change #1031568 merged by jenkins-bot:

[design/codex@main] build: Update Vue, Vite and Vitepress, and related dependencies

https://gerrit.wikimedia.org/r/1031568

Krinkle subscribed.

Thanks for the heads-up and visibility into patches. I assume we're only tagged for awareness of on-going work (which I am indeed happy to follow and keep up to date with via IRC notifs), but I understand nothing is currently actively needed from us. Let us know if otherwise!

Change #1037103 had a related patch set uploaded (by Anne Tomasevich; author: Anne Tomasevich):

[mediawiki/core@master] Update Codex from v1.6.0 to v1.6.1

https://gerrit.wikimedia.org/r/1037103

Test wiki created on Patch demo by ATomasevich (WMF) using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/ce0a74a0e6/w

Change #1037103 merged by jenkins-bot:

[mediawiki/core@master] Update Codex from v1.6.0 to v1.6.1

https://gerrit.wikimedia.org/r/1037103

Change #1032114 merged by jenkins-bot:

[mediawiki/core@master] Update Vue.js to 3.4.27

https://gerrit.wikimedia.org/r/1032114

Change #1032533 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] build: Upgrade Codex from 1.6.0 to 1.6.1 and Vue from 3.3.9 to 3.4.27, now MediaWiki/Codex has

https://gerrit.wikimedia.org/r/1032533

Test wiki on Patch demo by ATomasevich (WMF) using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/ce0a74a0e6/w/